Received-SPF: pass (google.com: domain of linux-kernel+bounces-127520-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: <Divya.Koppera@microchip.com>
To: <Horatiu.Vultur@microchip.com>, <andrew@lunn.ch>, <hkallweit1@gmail.com>,
	<linux@armlinux.org.uk>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <richardcochran@gmail.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<UNGLinuxDriver@microchip.com>, <Horatiu.Vultur@microchip.com>
Subject: RE: [PATCH net] net: phy: micrel: lan8814: Fix when
 enabling/disabling 1-step timestamping
Thread-Topic: [PATCH net] net: phy: micrel: lan8814: Fix when
 enabling/disabling 1-step timestamping
Thread-Index: AQHahM3zwhdD08oLdUe6JysjzcSjGrFUm6KQ
Date: Tue, 2 Apr 2024 07:55:28 +0000
Message-ID: <CO1PR11MB47719CB09438652F66E084F9E23E2@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20240402071634.2483524-1-horatiu.vultur@microchip.com>
In-Reply-To: <20240402071634.2483524-1-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GS2Z3HBxhsSN2CKvaK1cVvbLLXKdVeYMvG7WutpSyvmSS1D2cswNP0GZMlWC?=
 =?us-ascii?Q?RW55DNfNXj6Cl/XexdOcv2VA+Ev5L2GJ+cBBndVCjuSGYZ+z54Jkm1xvsc3F?=
 =?us-ascii?Q?cbKm7MxuBQGCMwiEozyNsGYlKELzdF6Io3+uuyz40AveEc3oYNy3UUYZeB7A?=
 =?us-ascii?Q?Dqtd8u8gdqC4eElXTpbh1RsnPUJpI8DRgWOyYdv4hXGBtpZQtoRYKEfiW/LQ?=
 =?us-ascii?Q?uIKzOz208k5SLDNhrGCKHiaAr/j48TLp0b04kFx2vBHJIbIu0TXxv0hF/fBW?=
 =?us-ascii?Q?XxXH/KzfaMNUJf218Wtad4y0T5aV1k5r6Qs+Fbfn4zYo+kgzjYp7v9f/4Lqn?=
 =?us-ascii?Q?ufnB4gcKR8XdFQw7DNFT2xOSpuzQR4AfkQHnl4yGFXTMxt99+QRzRXwJdbN5?=
 =?us-ascii?Q?2iIfq9h/AepiR+0xtHsj2LPkpFsOrGL0qmMQj40CJgJ6J1jwNKkxAsy9D14d?=
 =?us-ascii?Q?6F6FavxMMB+guoDwEIlLcgUR28xnYfjV6SRyvIsqaaSu7FJTMiddzijNRKJ/?=
 =?us-ascii?Q?qyWxsa/yszvbPUyDLJmRw0i5/S7SrjCIr5vlxcEfcaQ4a+dVV0g+8XK19Gpg?=
 =?us-ascii?Q?RwDMz8HRCN70Is/RdlLMvIRLoADfwXYGYnTqcagwvS3iVH4QeqJByltrM5UB?=
 =?us-ascii?Q?9WaljukURNbDLWBtVkFOWs92TY5wHwVd/QFLrj+EKdOQocpw083jMMelmIo5?=
 =?us-ascii?Q?5cNOxLmrruw3P/lOD00RjjxB59QK+1Sq7DldV1Fwx9sg4jlVpE7/2ejI//r4?=
 =?us-ascii?Q?vTjX8eqMpIfzwi9KvwIDgCrWoYitNGmSyNFbAxj5NDsPs/Wq5TDAlXhVmSFl?=
 =?us-ascii?Q?Jak2P+sa0CaJfdnHaUSoAHjI+O0UkiXr6vAm5z/j4halicaPdOsOQ0TLjvU4?=
 =?us-ascii?Q?OSrCfDxk+00AHeYVlWg4WIUNYZVqVI1oXtoVXoyEczJIDpHGTKwAXNRYVJyV?=
 =?us-ascii?Q?ryzralgdfd50Yb3E9gD/hI/1H2mNTLx8xssxr/+HVbc+31G38RhiBuRiZoCW?=
 =?us-ascii?Q?/H9IKbrveb0KM8SiRMqk93BwUL14VNhieFSfO14BbPCEo361vwvl9tClhIZC?=
 =?us-ascii?Q?jGuSr1h/eUCo+AhTZnwXpdU+As/jvLCRj9e/OY0o7moRSHsoXFQJIqSDsKl3?=
 =?us-ascii?Q?vmVugM3TxK1OpCWjwsPSAylgcAxy1PD6cq08swDnYD24rdOQvqAiHgBYMuQV?=
 =?us-ascii?Q?E/vJEWbRCAB1ZQBIwjGl0R28grJ7j+vePmz/66BLCx3F0TSiqVm3d7mUysd3?=
 =?us-ascii?Q?Dw2BZxgf1nfrNPLRU342dBHHIFBeFJ77Cr/mPEm9VzGlFtSnY4yBFAMIjJ6O?=
 =?us-ascii?Q?n8CYYYef189r/u+mp+CtKlci7KYE6Du+ZfXDnIgjETpRERGYzs0Y1VTpIOuz?=
 =?us-ascii?Q?ya1+MgH62b5RiuVV5L+CmsvV3XL9xJtQB5ghoWM1M2ig328eJCFPXJtrK9+d?=
 =?us-ascii?Q?+3aIJzR8Ze0mRldaNefrGfFySQ2n5IOCl9pl+aVqnbrrzv2NxhOZGjM1yUEF?=
 =?us-ascii?Q?Rk7yTBtbQ3qE4+JZIkQP3VaOSgMx1YTZhGPqIyk0hW6r4aB0K1kcqtDQXHgj?=
 =?us-ascii?Q?tjK4b8MCEXxH+2tmVE7UDB/JKsyYAMflYkiKndewyY0pMS6RquK7/fz976vc?=
 =?us-ascii?Q?PA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 969e49fc-077c-47f2-8ab7-08dc52ea432e
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 07:55:28.2191
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Gc2qYVdJxnO+NUVUZaII9+8lx7H/tnuryNwpdjoWZP/EdN7pMRG7LbFIcr9nK9vyXoS7+MDFCnTIIe1JyRiDbSa3A7sy4PLLaQ5qbEbpf5c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8116

> There are 2 issues with the blamed commit.
> 1. When the phy is initialized, it would enable the disabled of UDPv4
>    checksums. The UDPv6 checksum is already enabled by default. So when
>    1-step is configured then it would clear these flags.
> 2. After the 1-step is configured, then if 2-step is configured then the
>    1-step would be still configured because it is not clearing the flag.
>    So the sync frames will still have origin timestamps set.
>=20
> Fix this by reading first the value of the register and then just change =
bit 12 as
> this one determines if the timestamp needs to be inserted in the frame,
> without changing any other bits.
>=20
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  drivers/net/phy/micrel.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Reviewed-by: Divya Koppera <divya.koppera@microchip.com>