Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1921460lqz; Tue, 2 Apr 2024 01:31:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW4hwYEFBuC8/fU3nt1iYPBy7lepXgKlfP5VzLuEjU+zZiEQQIVYom8jTP/yX87nVxuVTTt/b1C3OVCg5+ra9xiScq8fH+Vcx70FPxHBQ== X-Google-Smtp-Source: AGHT+IHqRQB5uYZdadz2AG3tfQz7qJV+2gjx//ANj42N2Kgwc9zMAt/eKZBBcylqkTZ+j0uK96xo X-Received: by 2002:ac8:7d44:0:b0:432:b56b:41d6 with SMTP id h4-20020ac87d44000000b00432b56b41d6mr14829847qtb.2.1712046695249; Tue, 02 Apr 2024 01:31:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712046695; cv=pass; d=google.com; s=arc-20160816; b=H9GNYmaXWlyarbCzW6YfJ/97lhRTAK5QlM3cBY1RU0gVeH4IkBYE/uN74IcQtso4t/ 4zn0H8QHOO29IUAm2HZTiDw+351GVjMgwxTNmNDAfb1JNXAmrHwmvX+qQyOlNHeUDItG YTu+FnVYXXhYi1zXPPlJyR4n+F61rFU5eSoDtbph5/GvDQ+rRtkv/6zyj4gzFU04/xSC yVHPfY1G6gbf2djJcWKHMrIDcys/8GRlwpVSz33fROpXkLFqiDJ6vLBPq0vUp8rijvpT SCondHvLkpDnArReiaYMq1R1+q9e3V+8nUq3X0IvAFoGzkcZmAA/NDkYaFgqoOXFb+XJ 6/fA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=W/oyCBYCJRvlLZj0UsgTNVHsWGqL/lyvcEbw/Rw5ARc=; fh=av74Ve5kyfz++ZEN/OGUWBfXqcnMC8B8ghjpO1Ubqec=; b=Bye9fwO+U7QklDso0BcRtLU1NRD1oVLI54PH8w7HA67zZt72FmhpA/zb2klDkO/vl+ BYh8i4gjDIRo1MwVmjHHjC+YcQRYikRZHn891tohJ691Hf+Lcsw02bHZH9hRkdbxHhrw qXF3PQMf3Vp52rhxKzUIC5pUCWxXE0vMAnxj1bhXqwArxpUQWYKjSjpxWt16EwJisEXO nsr3eiNhP/qB166LV5QRO4J5jlyv5ntLVFR/IZ+DLA2a+FaRQXJq/49Ng/O6Q/Y89ncj rAOJbP/Nt3aJgXnohSjQalpLXaAw9Pn7nSPIjnun3Zf5M1o1yIROdoAbsIs4+3v61gp+ UXWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MzptfXme; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-127549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127549-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id eh5-20020a05622a578500b00432c448d06dsi8095435qtb.291.2024.04.02.01.31.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 01:31:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MzptfXme; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-127549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127549-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F3E171C20DB1 for ; Tue, 2 Apr 2024 08:31:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 28EEB4E1D6; Tue, 2 Apr 2024 08:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MzptfXme" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42A792EAF7; Tue, 2 Apr 2024 08:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712046630; cv=none; b=TEnP9aBZFIHT9q9cLes71jUU754dPTOm5pKrb/ndSaVHNQwT8LeIrzyhzH/7AjLmcH7ZG6GlgtSlC47nVisoA979mlP3hIqxUFfVC1Xj0u6uous4RwGGlm07rAqoYP7aKCEcn3OE0vAZxLq14DpVpFIzyrQdsGgx/BTPYXaSdhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712046630; c=relaxed/simple; bh=Yp6tOq+QIQyi5+nIO0v06Gfl2kI+9Jdp7GY7P6Wta6Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QHCnWiFaydnzESdkiedPmpkRT425DxVObXK56zYij7GOVrQglQ6+Stmcs4LQbZU2EFbAykKc++0E6TLT2bOI/PlBjpcO7w+MQm1B5tMCocwBrhVJNF3hSWodfJj9g3j/UKK9H3VrYhZpgzUmJoyPPKb6tAoVAIxduggXSBgJfqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MzptfXme; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11CDAC433F1; Tue, 2 Apr 2024 08:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712046629; bh=Yp6tOq+QIQyi5+nIO0v06Gfl2kI+9Jdp7GY7P6Wta6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MzptfXmea8EAAT6BfV+z3zRkEHP/d2OdUwsF67JVWH/gV1/vr9lozyUpzO5m80hTG /YRNMjd1o+7iaWTA2Z+tYXt4v9thJOSsFSgoIbKgG8zc2xKXBeS/mND48HiW8KNQae WI1or/7fD/AJU6p1kf+QI3lk3vJPsmltGj4lnxK47MEKUyWUWOr5Ev18DnAn2NVJPb QeAvE15C5LwEvdSAp27897yvqVc08e4CVhEiDiyJdZcjmPT3XLhM5qqRdIVcDa9DP+ 9zJ54Nc40khlIExdwrH6X3xaDi7A+yGeLUwuDLcbZR0xe0cRfck/GELT6io6BtFepn EhWdvNWlpoKyQ== Date: Tue, 2 Apr 2024 09:30:25 +0100 From: Simon Horman To: Christophe JAILLET Cc: rkannoth@marvell.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16 Message-ID: <20240402083025.GH26556@kernel.org> References: <8c1160501f69b64bb2d45ce9f26f746eec80ac77.1711787352.git.christophe.jaillet@wanadoo.fr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c1160501f69b64bb2d45ce9f26f746eec80ac77.1711787352.git.christophe.jaillet@wanadoo.fr> On Sat, Mar 30, 2024 at 09:32:12AM +0100, Christophe JAILLET wrote: > UTILITY_NAME_LENGTH is 16. So better use the former when defining the > 'utility_name' array. This makes the intent clearer when it is used around > line 260. > > While at it, declare variable in reverse xmas tree style. > > Signed-off-by: Christophe JAILLET Reviewed-by: Simon Horman