Received-SPF: pass (google.com: domain of linux-kernel+bounces-127560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: multipart/signed;
 boundary=92633de13f80d4722cab62876e75f1f46a1ce5d8254bdf21234f6f54d746;
 micalg=pgp-sha384; protocol="application/pgp-signature"
Date: Tue, 02 Apr 2024 10:34:52 +0200
Message-Id: <D09HZ0PN0QB9.2TJR29LQ2F570@kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: macronix: Add support for mx25um51245g
Cc: <linux-mtd@lists.infradead.org>
From: "Michael Walle" <mwalle@kernel.org>
To: "Witold Sadowski" <wsadowski@marvell.com>, <linux-spi@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <broonie@kernel.org>
References: <20240328115225.1783-1-wsadowski@marvell.com>
In-Reply-To: <20240328115225.1783-1-wsadowski@marvell.com>
Precedence: bulk

--92633de13f80d4722cab62876e75f1f46a1ce5d8254bdf21234f6f54d746
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

[+ linux-mtd ]

Hi,

On Thu Mar 28, 2024 at 12:52 PM CET, Witold Sadowski wrote:
> The Macronix mx25um51245g is a 1.8V, 512Mbit (64MB) device that
> supports x1, or x8 operation.
>
> Tested on Marvell Octeon SoC hardware with a Cadence xSPI controller.
>
> Signed-off-by: Witold Sadowski <wsadowski@marvell.com>

You haven't CC'ed the correct list, therefore it's unlikely this
will get a proper review/getting merged at all.

As Krzysztof already pointed out on another series of yours, please
read submitting-patches.rst.

For nor flash related submissions please also read:
https://docs.kernel.org/driver-api/mtd/spi-nor.html

> ---
>  drivers/mtd/spi-nor/macronix.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macroni=
x.c
> index ea6be95e75a5..f5fbdb7912e0 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -182,6 +182,12 @@ static const struct flash_info macronix_nor_parts[] =
=3D {
>  		.name =3D "mx25l3255e",
>  		.size =3D SZ_4M,
>  		.no_sfdp_flags =3D SECT_4K,
> +	}, {
> +                .id =3D SNOR_ID(0xc2, 0x80, 0x3a),

Wrong indentation?. Please use checkpatch.pl.

> +                .name =3D "mx25um51245g",

drop the name.

> +                .size =3D SZ_64M,

This is also autodetected. Drop it.

> +                .no_sfdp_flags =3D SECT_4K,

No "no_sfdp_flags" for SFDP capable flashes. Drop it.


> +                .fixup_flags =3D SPI_NOR_4B_OPCODES,

Doesn't the flash have proper a 4BAIT table?

-michael

--92633de13f80d4722cab62876e75f1f46a1ce5d8254bdf21234f6f54d746
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCZgvDLRIcbXdhbGxlQGtl
cm5lbC5vcmcACgkQEic87j4CH/jOzgF+KSOzHoPsP7oOG25ae5P4lNDk1qp6LWMv
Vx6iQft3Sn8zwAqBytHxaG7tzw/x0wHnAYDnH/uN4T9V/ZDc5xhO/0oHsFXQWxFt
fOsRGlwuKLLrxY3mTAs9UnSXSxXQ2GA+iKY=
=MbwG
-----END PGP SIGNATURE-----

--92633de13f80d4722cab62876e75f1f46a1ce5d8254bdf21234f6f54d746--