Received-SPF: pass (google.com: domain of linux-kernel+bounces-127584-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240325171804.3375280-1-andriy.shevchenko@linux.intel.com> <20240325171804.3375280-3-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240325171804.3375280-3-andriy.shevchenko@linux.intel.com>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Tue, 2 Apr 2024 10:50:00 +0200
Message-ID: <CAMRc=McE-CcRrWpa6Zw_5NGgYJhg+4Ru=uqcaW_WeQ_P25utgA@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] gpiolib: use dev_err() when gpiod_configure_flags failed
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, 
	Peng Fan <peng.fan@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 25, 2024 at 6:18=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> When gpio-ranges property was missed to be added in the gpio node,
> using dev_err() to show an error message will helping to locate issues
> easier.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index b98cbf4335e3..5589e085ba25 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -4236,7 +4236,7 @@ struct gpio_desc *gpiod_find_and_request(struct dev=
ice *consumer,
>         ret =3D gpiod_configure_flags(desc, con_id, lookupflags, flags);
>         if (ret < 0) {
>                 gpiod_put(desc);
> -               dev_dbg(consumer, "setup of GPIO %s failed\n", name);
> +               dev_err(consumer, "setup of GPIO %s failed: %d\n", name, =
ret);
>                 return ERR_PTR(ret);
>         }
>
> --
> 2.43.0.rc1.1.gbec44491f096
>

Applied, thanks!

Bart