Received-SPF: pass (google.com: domain of linux-kernel+bounces-127588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 2 Apr 2024 16:52:46 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
Subject: Re: [PATCH v19 105/130] KVM: TDX: handle KVM hypercall with
 TDG.VP.VMCALL
Message-ID: <ZgvHXk/jiWzTrcWM@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <ab54980da397e6e9b7b8d6636dc88c11c303364f.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ab54980da397e6e9b7b8d6636dc88c11c303364f.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XR66TyzM6MmCBgjHLfCUO2Zyuz4rfVZjg5V/p2Mn/RFoIbxII1YWuwVw4NJw?=
 =?us-ascii?Q?2fAC44nb89MRLlHs53odMOlLmzjz2zuTHvKhgwYlhrlWSNyLlg5PkUGwEZPK?=
 =?us-ascii?Q?iK4/KxPPH2ZG2QZcJMx9e0dAP6O+KSi/JF8LkVJU9yozMKcpltazK4OGyfTP?=
 =?us-ascii?Q?sozSfMte7GetGbDvfw03883Agh6Z1sPosXhBArcfBjhoHnIWE+km1Zohg253?=
 =?us-ascii?Q?2qwuoVCGGgTftpo+pXm7c35Khnn88bceA513WhwIjWUtXyPk4fgeJG9SXfir?=
 =?us-ascii?Q?2vsCMOLw8At4eaGe+59QF8c5mWlc47RsZSaZlZdYgoM6C+nxm2B8Mw7sHk77?=
 =?us-ascii?Q?Inp34fsWozmRfeo7uxl+1hRvhcsbK/wgwEBsdC1UxYZGI+bn13er/pVVBl8J?=
 =?us-ascii?Q?vuhczFZ4Hyxq/Ocq3hWCYlE1kzkhll5rZYmtkHt5U05ETnxM+2zL8TAxa7la?=
 =?us-ascii?Q?kLj0bqGuqEmTJ6yvPN0R0S+C/caHM5iahmpH68am6y7dR9EnGs5IcKY6GCP6?=
 =?us-ascii?Q?r8OY0vrkc9B1EJ5IBfO0h41sZ+2hkN4P0+5em4DQ50e67NCMa4WDnJj/2l5h?=
 =?us-ascii?Q?PSwoTXldZzoJHvP8NWiJT4+sqktwJMeDW6vDarLCr/xVKwGBnkXr05TpTUjT?=
 =?us-ascii?Q?P5BNxC85Tuel/59d90FaZhIlP1F4orw2OCZW5JULbrwDlKNfB3Qd7X3fZCzN?=
 =?us-ascii?Q?iauwuZi7eN7UQYUWg89jO/mQ/ALGeAlDosN8rzrh50KZBLmk31EtWGUVQJOU?=
 =?us-ascii?Q?5+bk9TRjcBHZJhEWnCo+RfH+W43R71qWdWqiyDbQclzPeGtuJm6HJfJg7a5F?=
 =?us-ascii?Q?P0PXE8QG9DQe5egUBQSFfqeu3l8UVUL3naRotgr4aE4wQjkC0ALI2qCC4/g7?=
 =?us-ascii?Q?n00FPdhT1T7VrCdK4us4o9UhUvPTDX/pR9dYlO5mLPaELlKM1bj7j0ZlRWCv?=
 =?us-ascii?Q?xN542r3xPgVxoovBVDOTov7knZByFGm6bnqZUq8Txg5JzuHbKrr5v+/JTwt3?=
 =?us-ascii?Q?J9w8sjmfMpyVUwZCXw+FVtb/q9e0ZaOk8nRGiv0RLzIdndKr+dhb8zBUek7P?=
 =?us-ascii?Q?yTdUB9/G1jvaIfp1PLzItuGXFWgEvgHyHQT9DK2MyuotOythl79oAC1ITMwB?=
 =?us-ascii?Q?TXP1c5diOoH5cYEOcHHuCwM1ruiBWqBjxXblDN57UPyMbFEwyNnyB0IqjHTO?=
 =?us-ascii?Q?h54b64NP4Mn02Uu0co4m/AQ0gs/2G2AArH/W421khffASLkmHSYXtaxBuAVE?=
 =?us-ascii?Q?kIfU53zGB2LpecZB/g6zYE5N6MIOmG1GMzh34M/a4/1dfF9stsmX/Bxv3ORd?=
 =?us-ascii?Q?5dUULPFP5qO2GV4jfHG8vBOjzh9/Frjj3YKQDd87yfTf4Kg+CIsuo734c7Nq?=
 =?us-ascii?Q?DcrxgKCidYmFIwzAAuq9oJjQzxE9ZBA9J7PDI06uat6kRaqr21jCxxSCulO8?=
 =?us-ascii?Q?RHBVtvXfw0hqNZ84bmbJ8yJ9rBp3Kd6GO7Wagc7xwmxRDGQYD1dEyMxto21J?=
 =?us-ascii?Q?WJHwPiViAQl6OjtCOrg/NkiQ3ZZ29gJeZA1LdsJHaw8h+zSky4HWI1RUGSXN?=
 =?us-ascii?Q?7ncTujEKFOsJAMj2dTkF/kmQ+9Fq8abz9c0a6OBR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbf73535-3304-4c33-6a79-08dc52f24967
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 08:52:54.8052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EjVsKh/Zo/YYh+P2idGu9LQe5VF+UEDzJt1FarTsVE37FHAjUZ5FlvXKyMUqM+af0Ks2MjudT56bTScga8PzEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8700
X-OriginatorOrg: intel.com

>+static int tdx_emulate_vmcall(struct kvm_vcpu *vcpu)
>+{
>+	unsigned long nr, a0, a1, a2, a3, ret;
>+

do you need to emulate xen/hyper-v hypercalls here?

Nothing tells userspace that xen/hyper-v hypercalls are not supported and
so userspace may expose related CPUID leafs to TD guests.

>+	/*
>+	 * ABI for KVM tdvmcall argument:
>+	 * In Guest-Hypervisor Communication Interface(GHCI) specification,
>+	 * Non-zero leaf number (R10 != 0) is defined to indicate
>+	 * vendor-specific.  KVM uses this for KVM hypercall.  NOTE: KVM
>+	 * hypercall number starts from one.  Zero isn't used for KVM hypercall
>+	 * number.
>+	 *
>+	 * R10: KVM hypercall number
>+	 * arguments: R11, R12, R13, R14.
>+	 */
>+	nr = kvm_r10_read(vcpu);
>+	a0 = kvm_r11_read(vcpu);
>+	a1 = kvm_r12_read(vcpu);
>+	a2 = kvm_r13_read(vcpu);
>+	a3 = kvm_r14_read(vcpu);
>+
>+	ret = __kvm_emulate_hypercall(vcpu, nr, a0, a1, a2, a3, true, 0);
>+
>+	tdvmcall_set_return_code(vcpu, ret);
>+
>+	if (nr == KVM_HC_MAP_GPA_RANGE && !ret)
>+		return 0;

Can you add a comment to call out that KVM_HC_MAP_GPA_RANGE is redirected to
the userspace?

>+	return 1;
>+}