Received-SPF: pass (google.com: domain of linux-kernel+bounces-127447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 2 Apr 2024 14:30:57 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-fpga@vger.kernel.org
Subject: Re: [PATCH] fpga: altera-cvp: Remove an unused field in struct
 altera_cvp_conf
Message-ID: <ZgumIQV3fUpxNqno@yilunxu-OptiPlex-7050>
References: <7986690e79fa6f7880bc1db783cb0e46a1c2723e.1711976883.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7986690e79fa6f7880bc1db783cb0e46a1c2723e.1711976883.git.christophe.jaillet@wanadoo.fr>

On Mon, Apr 01, 2024 at 03:08:21PM +0200, Christophe JAILLET wrote:
> In "struct altera_cvp_conf", the 'mgr' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Applied to for-next.

> ---
> Apparently, it has never been used. It is not a left-over from a
> refactoring.
> 
> The address of the 'fpga_manager' is handled via pci_[s|g]et_drvdata().
> 
> Compile tested only.
> ---
>  drivers/fpga/altera-cvp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
> index 4ffb9da537d8..6b0914432445 100644
> --- a/drivers/fpga/altera-cvp.c
> +++ b/drivers/fpga/altera-cvp.c
> @@ -72,7 +72,6 @@ static bool altera_cvp_chkcfg;
>  struct cvp_priv;
>  
>  struct altera_cvp_conf {
> -	struct fpga_manager	*mgr;
>  	struct pci_dev		*pci_dev;
>  	void __iomem		*map;
>  	void			(*write_data)(struct altera_cvp_conf *conf,
> -- 
> 2.44.0
> 
>