Received-SPF: pass (google.com: domain of linux-kernel+bounces-127652-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <CAFGhKbzev7W4aHwhFPWwMZQEHenVgZUj7=aunFieVqZg3mt14A@mail.gmail.com>
 <CAFULd4a75kS=3cJzYKsOcJ3ULjW8k5M1cvPYZQ25zZqTo3QX9Q@mail.gmail.com> <CAFGhKbx3dzrMC0euRMNe5=sAhM87v=6gLwOT+c9HwWKZrWc5Gg@mail.gmail.com>
In-Reply-To: <CAFGhKbx3dzrMC0euRMNe5=sAhM87v=6gLwOT+c9HwWKZrWc5Gg@mail.gmail.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Tue, 2 Apr 2024 11:43:02 +0200
Message-ID: <CAFULd4ZNi7eONVu8syiWyA5ek2TgHTf6jTM+Pf7SaSG6WyHoNw@mail.gmail.com>
Subject: Re: warning: cast removes address space '__percpu' of expression
To: Charlemagne Lasse <charlemagnelasse@gmail.com>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>, 
	Luc Van Oostenryck <lucvoo@kernel.org>, Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>, 
	Brian Gerst <brgerst@gmail.com>, Denys Vlasenko <dvlasenk@redhat.com>, 
	"H . Peter Anvin" <hpa@zytor.com>, Linus Torvalds <torvalds@linux-foundation.org>, 
	Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, 
	Borislav Petkov <bp@alien8.de>, Josh Poimboeuf <jpoimboe@redhat.com>
Content-Type: multipart/mixed; boundary="0000000000005bf77c061519effc"

--0000000000005bf77c061519effc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 2, 2024 at 9:56=E2=80=AFAM Charlemagne Lasse
<charlemagnelasse@gmail.com> wrote:
>
> Am Mo., 1. Apr. 2024 um 21:16 Uhr schrieb Uros Bizjak <ubizjak@gmail.com>=
:
> > > I would even go as far as saying that 1ca3683cc6d2 ("x86/percpu:
> > > Enable named address spaces with known compiler version") together
> > > with 3a1d3829e193 ("x86/percpu: Avoid sparse warning with cast to
> > > named address space") triggered this problem
>
> I think 1ca3683cc6d2 was wrong and is the last working one.
>
>
> Just switch to 1ca3683cc6d2c2ce4204df519c4e4730d037905a and you won't
> see the messages.
>
> ```
> git reset --hard 1ca3683cc6d2c2ce4204df519c4e4730d037905a
> git clean -dfx
> make allnoconfig -j$(nproc)
> make kvm_guest.config
> make prepare -j$(nproc)
> touch include/linux/netdevice.h
> make C=3D1 net/core/dev.o CHECK=3D"sparse -Wcast-from-as"
> ```
>
> Go to 9a462b9eafa6dda16ea8429b151edb1fb535d744 and cherry-pick
> 3a1d3829e193c091475ceab481c5f8deab385023 and you would see the error.
> On amd64  with 12.2.0, this would look like this:
>
> ```
> git reset --hard 9a462b9eafa6dda16ea8429b151edb1fb535d744
> git cherry-pick 3a1d3829e193c091475ceab481c5f8deab385023
> git clean -dfx
> make allnoconfig -j$(nproc)
> make kvm_guest.config
> make prepare -j$(nproc)
> touch include/linux/netdevice.h
> make C=3D1 net/core/dev.o CHECK=3D"sparse -Wcast-from-as"
> ```
>
> I would recommend to use `-Wsparse-all` for testing but for this
> demonstration, it is easier to use `-Wcast-from-as` to reduce the
> amount of noise in the demonstrator.

Oh, I see the problem now. We *do* cast away from __percpu space, this
is how we switch between GCC's named address spaces [1]:

--q--
6.17.5 x86 Named Address Spaces

..

The respective segment base must be set via some method specific to
the operating system. Rather than require an expensive system call to
retrieve the segment base, these address spaces are not considered to
be subspaces of the generic (flat) address space. This means that
explicit casts are required to convert pointers between these address
spaces and the generic address space. In practice the application
should cast to uintptr_t and apply the segment base offset that it
installed previously.
--/q--

Please try the attached patch that informs sparse about this action.

BTW: Please also note recent discussion about different checks for
__percpu name space that can be implemented using GCC's named address
spaces feature [2].

[1] https://gcc.gnu.org/onlinedocs/gcc/Named-Address-Spaces.html
[2[ https://lore.kernel.org/lkml/87bk7ux4e9.ffs@tglx/#t

Thanks,
Uros.

--0000000000005bf77c061519effc
Content-Type: text/plain; charset="US-ASCII"; name="p.diff.txt"
Content-Disposition: attachment; filename="p.diff.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_lui6xxmg0>
X-Attachment-Id: f_lui6xxmg0

ZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BlcmNwdS5oIGIvYXJjaC94ODYvaW5j
bHVkZS9hc20vcGVyY3B1LmgKaW5kZXggNDQ5NThlYmFmNjI2Li44ZmM4ZDIzNmMyNTUgMTAwNjQ0
Ci0tLSBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BlcmNwdS5oCisrKyBiL2FyY2gveDg2L2luY2x1
ZGUvYXNtL3BlcmNwdS5oCkBAIC03MCw3ICs3MCw3IEBACiAJdW5zaWduZWQgbG9uZyB0Y3BfcHRy
X187CQkJCVwKIAl0Y3BfcHRyX18gPSBfX3Jhd19jcHVfcmVhZCgsIHRoaXNfY3B1X29mZik7CQlc
CiAJCQkJCQkJCVwKLQl0Y3BfcHRyX18gKz0gKHVuc2lnbmVkIGxvbmcpKHB0cik7CQkJXAorCXRj
cF9wdHJfXyArPSAoX19mb3JjZSB1bnNpZ25lZCBsb25nKShwdHIpOwkJXAogCSh0eXBlb2YoKihw
dHIpKSBfX2tlcm5lbCBfX2ZvcmNlICopdGNwX3B0cl9fOwkJXAogfSkKICNlbHNlIC8qIENPTkZJ
R19VU0VfWDg2X1NFR19TVVBQT1JUICovCkBAIC04NSw3ICs4NSw3IEBACiAJICAgICA6ICI9ciIg
KHRjcF9wdHJfXykJCQkJCVwKIAkgICAgIDogIm0iIChfX215X2NwdV92YXIodGhpc19jcHVfb2Zm
KSkpOwkJXAogCQkJCQkJCQlcCi0JdGNwX3B0cl9fICs9ICh1bnNpZ25lZCBsb25nKShwdHIpOwkJ
CVwKKwl0Y3BfcHRyX18gKz0gKF9fZm9yY2UgdW5zaWduZWQgbG9uZykocHRyKTsJCVwKIAkodHlw
ZW9mKCoocHRyKSkgX19rZXJuZWwgX19mb3JjZSAqKXRjcF9wdHJfXzsJCVwKIH0pCiAjZW5kaWYg
LyogQ09ORklHX1VTRV9YODZfU0VHX1NVUFBPUlQgKi8KQEAgLTEwMiw4ICsxMDIsOCBAQAogI2Vu
ZGlmIC8qIENPTkZJR19TTVAgKi8KIAogI2RlZmluZSBfX215X2NwdV90eXBlKHZhcikJdHlwZW9m
KHZhcikgX19wZXJjcHVfc2VnX292ZXJyaWRlCi0jZGVmaW5lIF9fbXlfY3B1X3B0cihwdHIpCShf
X215X2NwdV90eXBlKCpwdHIpICopKHVpbnRwdHJfdCkocHRyKQotI2RlZmluZSBfX215X2NwdV92
YXIodmFyKQkoKl9fbXlfY3B1X3B0cigmdmFyKSkKKyNkZWZpbmUgX19teV9jcHVfcHRyKHB0cikJ
KF9fbXlfY3B1X3R5cGUoKnB0cikgKikoX19mb3JjZSB1aW50cHRyX3QpKHB0cikKKyNkZWZpbmUg
X19teV9jcHVfdmFyKHZhcikJKCpfX215X2NwdV9wdHIoJih2YXIpKSkKICNkZWZpbmUgX19wZXJj
cHVfYXJnKHgpCQlfX3BlcmNwdV9wcmVmaXggIiUiICN4CiAjZGVmaW5lIF9fZm9yY2VfcGVyY3B1
X2FyZyh4KQlfX2ZvcmNlX3BlcmNwdV9wcmVmaXggIiUiICN4CiAK
--0000000000005bf77c061519effc--