Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1958686lqz; Tue, 2 Apr 2024 03:02:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUvjtrntLc5fhqKfznZLovgMtQxpNV7YnW2d6QIlSwQA8CMsCvEnPBRTy0yFBIDHgHXNOGWBCsCwPYh4e9m4jRCBghWmnQrxX1k2tNC9A== X-Google-Smtp-Source: AGHT+IH/JlD2PFuDO6mUswq8eXub8ndKi9jE63yNtNJslLmieibFniW9Tj5NVOHzTdqpM5mJaEWD X-Received: by 2002:a05:6a21:6d92:b0:1a3:c503:8e78 with SMTP id wl18-20020a056a216d9200b001a3c5038e78mr14801417pzb.8.1712052157104; Tue, 02 Apr 2024 03:02:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712052157; cv=pass; d=google.com; s=arc-20160816; b=UGFLWN92GSd2kUjTAeBxda+Z4UJiocBaTHBG+tpYYGDukB8hpuISGKiVUbOawjv7YI cwTWbGUWcuUb2WUWmdeNDtSmUNE6mAVrTxhpSYRQoYJBmIhpFX2ym79KPwGaycrwQmRe FR4DvH1BfJe2vlfBhgbPrsZXoU0SdhKw/cUVbVRhIWiOObi4ILYzrTK6HCInsULDLRo9 TJ62loDmO7xgrPKJpJ6xi+DxyJcABq2JrVhoazuKezjzPEHm9bO55dOVBmhVTzY5W7X3 QVLDRUOPTqB/enk4GdOIvUEIfWZNC1iFDd5uzpRxs+h/4bFA8GXSpBXopih0ndBzxqON ztcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=ld5/UZMRVCPDO/dKTQcgFxFhH+C0bdjqoU583UYXs7Q=; fh=GeTEhjMs2QlIt5y5WCRjmoIQhhISpe8GI9/Ud4n5Uk4=; b=msYlpCLp4DSzSY84fllTAcjfbn6VKWxUH7x1QSUPhzTYXHiHZHPZ31iLACSzc4AxBi kOLVlgyNtJuU/CJ7twgDGRhrGKyHy1Nd1FmCMz6GmgOjmdMhClU5TlkdsH4kWFCII+jV r/UafS865B5A43dYF34F6r/qAMQDuJZkKRJxEYsFM5c2hHJ5DN1e90fUJNxYwBxBxOD8 0zlq38DULDTMVpszPdr1/X1c9h+M6hKDwAqRXLCIxq/Z7LixO88yEHx9QSwYsieq/3Xf 7RApSMno9DJ/DYteCEBoaN625LjEpD0n7kvZ/6Hu0crFYzY3g+JxmDLZYmtHcEg0gqFL xMgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lW/riFUL"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-127678-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127678-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id j4-20020a170903028400b001e0ebb7519asi11407567plr.50.2024.04.02.03.02.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 03:02:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127678-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lW/riFUL"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-127678-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127678-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EF0E7B24680 for ; Tue, 2 Apr 2024 09:58:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A556B59176; Tue, 2 Apr 2024 09:58:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lW/riFUL" Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 258E61E4A1 for ; Tue, 2 Apr 2024 09:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712051896; cv=none; b=FtDQUYqDaOOCNeMV4JGBzRPG1dBEpVNmTKfjonk80MJv9vE7QO2vs0ApwgYnq8kjiD+QMbpRdrhlG4P1ciM60xzmoZ4bPubrjM59VoX2JCyyuCsJM5fqfS2xDNXFGLlLyGUOJ6fxwS88/7N2vNI+pcOOosvcv0EWTDNVg6bBNW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712051896; c=relaxed/simple; bh=i3dAA3EBuiwwRsOxrV8BH5VJ943ZUlY2pGSFcOqvWsw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=dmVzBtLVsWy9K1x8Pl3wedcZ48x+qgKU7Eg3xHMf6JMoR4YTOGZiK53uecvbD0B4w8aixi7r6UFUF01c67oszhbzcd6LIzkfojvTZi7ZR5HDoLQ9Fj1I3qLoULJg5IBRzDbfQItTwHpPs3JD20dzRdb5NntFKfijHw5cDPcTNIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lW/riFUL; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-56b0af675deso5523580a12.1 for ; Tue, 02 Apr 2024 02:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712051893; x=1712656693; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ld5/UZMRVCPDO/dKTQcgFxFhH+C0bdjqoU583UYXs7Q=; b=lW/riFULRJeVOWDl3FOtQ1mA7mgZZs3VeDZJhMPuHixSaBW/YqAfASuUZr+yY3T477 HuMkEpCUiKm1ONF2P4qWldjcuXHa+9et8ktaAQo6kfLRZ30L5cYzt7+ePek6EwbX18xR bwqJIQmOq26Hs5M/b/jDwdfxnNaoeEcoZdcx0S8zc7dnyPiSNoFDfUvCCDq4vpGQk6bG uL9xxE3ya/aTKjo/Ub49RpxPQhTPU+Sg/Eci1RI6vPihBC5hYGL5E9ZcEqwb4E30Sgv5 bIV2UMScktdCSkLT44zMkIdn6pvi7XfwbfV7wPEV+fyYnRIKqWHri+FZwI39HXu1RAOj clLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712051893; x=1712656693; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ld5/UZMRVCPDO/dKTQcgFxFhH+C0bdjqoU583UYXs7Q=; b=PL7Q+7QRzffBkNqvpUFMOz3+zZVV9ZyhSc3Tv1APi7F8XxJNxUtlfxXD3jMLxGgUir OjWwaovDZw9IJe2r3tHzPjFx0VrqjTEFT06ffq5abp6h8pD7R9HLFQs8Xt9kW7/OgAct pe+dX78EY4U62THb1AvhYXWrBUNaMbL10l1PW+aw/4Ml8sFf4wy+gP/V9BPHB7JixAzB lwlNPWO04Oqvl75UXsV/xDcKEWvMqd+k9O7xX9TuPH5qTqvtKInOzT4chFYpCwXTpUNX 69rCYpkx8gwif79Y/qVXIYA5DmGbxO+4DY8WmqFYTmXzkjmTExhOSKWELIrcmi1gUjfD FXQQ== X-Forwarded-Encrypted: i=1; AJvYcCU3x+saW/UHLvWWP5EbQQeH6ak0JUxOVkc5ylAgq7yLn1cc3Ark52nxXAtSxR0J/CH0Vv704Nkr9mg/YPRNr+E986WlerwD6HiLitiB X-Gm-Message-State: AOJu0YzbhHavtSESAvorDgXIJ5b8uc7eAdbcqF+qy+Fmo5pbyH6h/XUx gd1xvDyLQ5254KOy1nXmhLiSOFOVmBbp+2377ES8ZYs3rnR+Kd+h0iOuQGZ4XDE= X-Received: by 2002:a50:d4cc:0:b0:56b:9925:38a with SMTP id e12-20020a50d4cc000000b0056b9925038amr7967208edj.38.1712051893318; Tue, 02 Apr 2024 02:58:13 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id u22-20020aa7d556000000b0056c63ba1387sm5295464edr.86.2024.04.02.02.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 02:58:13 -0700 (PDT) Date: Tue, 2 Apr 2024 12:58:09 +0300 From: Dan Carpenter To: Boris Brezillon Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Grant Likely , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/panthor: Fix a couple -ENOMEM error codes Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding These error paths forgot to set the error code to -ENOMEM. Fixes: 647810ec2476 ("drm/panthor: Add the MMU/VM logical block") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/panthor/panthor_mmu.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c index fdd35249169f..a26b40aab261 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -1264,8 +1264,10 @@ static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx, op_ctx->rsvd_page_tables.pages = kcalloc(pt_count, sizeof(*op_ctx->rsvd_page_tables.pages), GFP_KERNEL); - if (!op_ctx->rsvd_page_tables.pages) + if (!op_ctx->rsvd_page_tables.pages) { + ret = -ENOMEM; goto err_cleanup; + } ret = kmem_cache_alloc_bulk(pt_cache, GFP_KERNEL, pt_count, op_ctx->rsvd_page_tables.pages); @@ -1318,8 +1320,10 @@ static int panthor_vm_prepare_unmap_op_ctx(struct panthor_vm_op_ctx *op_ctx, op_ctx->rsvd_page_tables.pages = kcalloc(pt_count, sizeof(*op_ctx->rsvd_page_tables.pages), GFP_KERNEL); - if (!op_ctx->rsvd_page_tables.pages) + if (!op_ctx->rsvd_page_tables.pages) { + ret = -ENOMEM; goto err_cleanup; + } ret = kmem_cache_alloc_bulk(pt_cache, GFP_KERNEL, pt_count, op_ctx->rsvd_page_tables.pages); -- 2.43.0