Received-SPF: pass (google.com: domain of linux-kernel+bounces-127720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Xu Yang <xu.yang_2@nxp.com>
To: Shawn Guo <shawnguo2@yeah.net>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>, "conor+dt@kernel.org"
	<conor+dt@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com"
	<festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>,
	"peter.chen@kernel.org" <peter.chen@kernel.org>, Jun Li <jun.li@nxp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "imx@lists.linux.dev"
	<imx@lists.linux.dev>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v10 02/11] arm64: dts: imx8ulp: add usb nodes
Thread-Topic: [EXT] Re: [PATCH v10 02/11] arm64: dts: imx8ulp: add usb nodes
Thread-Index: AQHae2fM64boqdCCnUiZChs5zmyRKbFUuWoAgAAeVpA=
Date: Tue, 2 Apr 2024 10:20:28 +0000
Message-ID:
 <DU2PR04MB88225A1F8A245C68071138228C3E2@DU2PR04MB8822.eurprd04.prod.outlook.com>
References: <20240321081439.541799-1-xu.yang_2@nxp.com>
 <20240321081439.541799-2-xu.yang_2@nxp.com> <ZgvCTgB4lp0F83Kn@dragon>
In-Reply-To: <ZgvCTgB4lp0F83Kn@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?amfzH5dVjo2hm9UQzLyZnVtt+6tsbqklQY4WJUMgsgyfmJONqkC0mDcCL0eS?=
 =?us-ascii?Q?BD65Pf5yww9E3SNPOVJjci9DwM6doN92hpNal7KhAw+7QATtkJPZG9RQeVKC?=
 =?us-ascii?Q?cjBaSVGlUxj6WQMyekt/0es23ejSjcx7coOz6EP+3Vafir1Ye1qKSfCiJ4JO?=
 =?us-ascii?Q?ZclKe6El7mnnA3hLF/KkfFEms2oGwJyJDPqxzqceLMomHFLhx/Ezn2yLvpgp?=
 =?us-ascii?Q?4v9YPohxxMkNfID81CezlWeUzMa4cQ1ACsbCsN9STS+YVh2zlHr+vmWI5kLJ?=
 =?us-ascii?Q?D3Prk2mW01TUifbA0EsbOGQxakDyVH4/xEAbxe9dSy9GVuMChpYOSUZxn6Iz?=
 =?us-ascii?Q?0m9kBynEyi6gxDIFBmukm6pyds5FfOBskAsTuC8whjvNN9kaJFaW6pSVb2AO?=
 =?us-ascii?Q?t80uE37BHrt89QnuHftKLBXFnHIztg4aCq8Ne4GDSD5VxBsfoGvGDNZsjlWo?=
 =?us-ascii?Q?xux+Pj25EDsplWex62PjLiOfIVUVqSeqGTTdAMT4vTqIg+b0T/HH3U/KwAPv?=
 =?us-ascii?Q?SHOOznVNf5zH3EbM3SYqVqe6/VV2BQ3rfedzeBo5OuOa9NjPjySURXSXeYQm?=
 =?us-ascii?Q?XuHVwksMEH3XuI+7Ak8KLDmzwGgQrgWTC4837NE1SwmdzSFeEB9tX7Vw1kk3?=
 =?us-ascii?Q?pN2dnBndjtIiHwHFp6ICvtJC5d09yGW4pFdliQt/Ev3SlnL27vaoVK80gqSQ?=
 =?us-ascii?Q?0LnLoUNgNjfAykqzheVPbKfKoudsYp9FOsJFdOGpUnYc/LnpdOKRqnd3irQI?=
 =?us-ascii?Q?zUHZlzNXEEh5a+1xxn5eHbtOzyeb1+8uSaKmD+gshfe9e7J8ga/5JJ4+68ce?=
 =?us-ascii?Q?KI4bMcyonm7QzJbLFDd7RaMbEAODPxJF9vnwfPNyAyqxoSi2dUQc+Vemql4m?=
 =?us-ascii?Q?7xufzxOHixeeoqPZL1oE7t9R1YIJmXkjZ9WSABYCtAZIyyiNFey7bIFkEf3p?=
 =?us-ascii?Q?Gf+wPaWln0nJ7NrKjcy84zvY1lumOKnKCiXUc9eYvGyvNVq776BA2dsmx5mb?=
 =?us-ascii?Q?sG0cC9iCfvGUKBhppk/jf0OQtzsaLrH3ts7/7GSGuvYpMJDqrI6wU3NRaFUf?=
 =?us-ascii?Q?mACufP0vSie5SgwJfslMYXb9GGs7Y6IQ2hlckmZoe+gN9pgcu8RMJJz4E0yo?=
 =?us-ascii?Q?dRQseCbp0giL3CHE25eNQ6A1Wd9I9nSjYK5RjA/pi6jpH0XFEAix8BSWw7Fn?=
 =?us-ascii?Q?Mf3Jv7nfOPBjSm/JfCxJ7yT0w3V3tfT30RMdFdsq2/XgY229h1UfM4L9s7wP?=
 =?us-ascii?Q?IVbBRyNhhd4XXQZV+x2ImGxFz3ZfIApViizUcjCDgYNLNFnSDQTejCjKTYJI?=
 =?us-ascii?Q?doo9gIWIPuyJkFBoTo0uzK1sfSdFpAwmD6v80O/LZZcdhC8qre+/oTe3Vxnc?=
 =?us-ascii?Q?nb88vYLljXXcdpAE5ONKNaFJMOfgli6FM8YnSHDPWFDSVRrMlGTsfEgRcsCt?=
 =?us-ascii?Q?20bwI06tAmenUdFe2g3qeh2u72rbPsVy1L1Os2dh3lJYjsBWoOy+UIunxF+V?=
 =?us-ascii?Q?fFp59nJxrpvm926voCuACC6MLprj872xw7Ms4t4oSP5WGxvWzuGZ+h8afms2?=
 =?us-ascii?Q?78mil8MNqEb0zeNgQOY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9055ae9e-f54c-453f-5671-08dc52fe8513
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 10:20:28.7239
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: avk+nfOAeuoAR+yE2o0BxOzQgbi0yaNVLcuOirqtg25T/qDZprdxle4IZnXNm7rlJzc0PsnJJ+emyCSfeSjnAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7885


>=20
> On Thu, Mar 21, 2024 at 04:14:30PM +0800, Xu Yang wrote:
> > Add USB nodes on i.MX8ULP platform which has 2 USB controllers.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> >  - no changes
> > Changes in v3:
> >  - no changes
> > Changes in v4:
> >  - no changes
> > Changes in v5:
> >  - no changes
> > Changes in v6:
> >  - drop usbphy aliases
> > Changes in v7:
> >  - no changes
> > Changes in v8:
> >  - no changes
> > Changes in v9:
> >  - no changes
> > Changes in v10:
> >  - no changes
> > ---
> >  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 62 ++++++++++++++++++++++
> >  1 file changed, 62 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/bo=
ot/dts/freescale/imx8ulp.dtsi
> > index c4a0082f30d3..7da9461a5745 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > @@ -472,6 +472,68 @@ usdhc2: mmc@298f0000 {
> >                               status =3D "disabled";
> >                       };
> >
> > +                     usbotg1: usb@29900000 {
> > +                             compatible =3D "fsl,imx8ulp-usb", "fsl,im=
x7ulp-usb", "fsl,imx6ul-usb";
> > +                             reg =3D <0x29900000 0x200>;
> > +                             interrupts =3D <GIC_SPI 103 IRQ_TYPE_LEVE=
L_HIGH>;
> > +                             clocks =3D <&pcc4 IMX8ULP_CLK_USB0>;
> > +                             power-domains =3D <&scmi_devpd IMX8ULP_PD=
_USB0>;
> > +                             phys =3D <&usbphy1>;
> > +                             fsl,usbmisc =3D <&usbmisc1 0>;
> > +                             ahb-burst-config =3D <0x0>;
> > +                             tx-burst-size-dword =3D <0x8>;
> > +                             rx-burst-size-dword =3D <0x8>;
> > +                             status =3D "disabled";
> > +                     };
> > +
> > +                     usbmisc1: usbmisc@29900200 {
> > +                             compatible =3D "fsl,imx8ulp-usbmisc", "fs=
l,imx7d-usbmisc",
> > +                                             "fsl,imx6q-usbmisc";
> > +                             #index-cells =3D <1>;
> > +                             reg =3D <0x29900200 0x200>;
>=20
> Could you move 'reg' above so that it's after compatible?

Okay.

>=20
> > +                             status =3D "disabled";
> > +                     };
> > +
> > +                     usbphy1: usb-phy@29910000 {
> > +                             compatible =3D "fsl,imx8ulp-usbphy", "fsl=
,imx7ulp-usbphy";
> > +                             reg =3D <0x29910000 0x10000>;
> > +                             interrupts =3D <GIC_SPI 104 IRQ_TYPE_LEVE=
L_HIGH>;
> > +                             clocks =3D <&pcc4 IMX8ULP_CLK_USB0_PHY>;
> > +                             #phy-cells =3D <0>;
> > +                             status =3D "disabled";
> > +                     };
> > +
> > +                     usbotg2: usb@29920000 {
> > +                             compatible =3D "fsl,imx8ulp-usb", "fsl,im=
x7ulp-usb", "fsl,imx6ul-usb";
> > +                             reg =3D <0x29920000 0x200>;
> > +                             interrupts =3D <GIC_SPI 105 IRQ_TYPE_LEVE=
L_HIGH>;
> > +                             clocks =3D <&pcc4 IMX8ULP_CLK_USB1>;
> > +                             power-domains =3D <&scmi_devpd IMX8ULP_PD=
_USDHC2_USB1>;
> > +                             phys =3D <&usbphy2>;
> > +                             fsl,usbmisc =3D <&usbmisc2 0>;
> > +                             ahb-burst-config =3D <0x0>;
> > +                             tx-burst-size-dword =3D <0x8>;
> > +                             rx-burst-size-dword =3D <0x8>;
> > +                             status =3D "disabled";
> > +                     };
> > +
> > +                     usbmisc2: usbmisc@29920200 {
> > +                             compatible =3D "fsl,imx8ulp-usbmisc", "fs=
l,imx7d-usbmisc",
> > +                                             "fsl,imx6q-usbmisc";
> > +                             #index-cells =3D <1>;
> > +                             reg =3D <0x29920200 0x200>;
>=20
> Ditto

Okay.

Thanks,
Xu Yang

>=20
> Shawn
>=20
> > +                             status =3D "disabled";
> > +                     };
> > +
> > +                     usbphy2: usb-phy@29930000 {
> > +                             compatible =3D "fsl,imx8ulp-usbphy", "fsl=
,imx7ulp-usbphy";
> > +                             reg =3D <0x29930000 0x10000>;
> > +                             interrupts =3D <GIC_SPI 106 IRQ_TYPE_LEVE=
L_HIGH>;
> > +                             clocks =3D <&pcc4 IMX8ULP_CLK_USB1_PHY>;
> > +                             #phy-cells =3D <0>;
> > +                             status =3D "disabled";
> > +                     };
> > +
> >                       fec: ethernet@29950000 {
> >                               compatible =3D "fsl,imx8ulp-fec", "fsl,im=
x6ul-fec", "fsl,imx6q-fec";
> >                               reg =3D <0x29950000 0x10000>;
> > --
> > 2.34.1
> >