Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1972947lqz; Tue, 2 Apr 2024 03:34:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUsSMIgA4AexdvDdkg4zQUaYs7mfSuL5h4G/bDAbA0IE6ADfG/cOSwtyImtUpWbcoU3E/TmzmYxEtIcdfo5WrgNTYveAMc//dP6dHgzUA== X-Google-Smtp-Source: AGHT+IFEsUa/S8NL1o+YWZ6Pi0qbQh+oqQWo0P5jH8dFrGkyUI+LkmzZZL/8PCLyTk1MpfZjzJs9 X-Received: by 2002:a05:6e02:1fc7:b0:368:75ce:a057 with SMTP id dj7-20020a056e021fc700b0036875cea057mr15399599ilb.28.1712054092355; Tue, 02 Apr 2024 03:34:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712054092; cv=pass; d=google.com; s=arc-20160816; b=pORPtifILtx9IcD0acypDN/3ziD1oGmZsJQiUqPNlZL0P/hzfzeb4gispjNHgNVojs KhNDFOn99J8U8M/JXMVvwWIVkqFySZF5+brHPxAZMs1eae6zSt6RFBkR8Ix2MPmQcd// JBxic92Nk+cLM6dfnocJ8wKaWNsfIX/FbinfHr7cjdlYNq2W/FgSQmWleaz9JTjt4dtJ WezLAhOKIS2OSEaS+ZqR9KKonHjGAd3TaM/Muq1MEemnk151GqxulNp+GkZwmli6+vZH xK3ju8VXLE7YNkgYJgl3p01waADxKdje9k2gyegicmktiOBpfRRW4+LIzAOhM9InzdMv GNZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=XvRJZS9/7BkVA1e8FeB9e+hNFisP/qtOlgVeJBDMQhA=; fh=01vijPOZ+gCavAsyrdEz9K9/AEOpllkWHTsZFq7mUHU=; b=Oizt5/aQ3mF0/9vHl91NVPYrAvgy0QsuOpfBPyQbgQ1Ub6mMuOF6SM1MuhGlD0oFb+ Ofj3dDWfB+TSLcHeDQR4CCf5jVdjXPpGEcyiITMFMs7tPHuMFkPJus3uJQfnFj5N+kzD NNFV4an7C3qDIGvX3l3qFFtnC75yLSP6xSp35yP9R2Xhkqpa7dZBg3SkXLENRAw4Izuu BUQAUZCNkFtgwmt2ndRAmzsN/Ory/WFrDVlljHkzCeUob08bZHQOSf81nb4yg0QrCkoS XEmcvUwOod3I694/BEuBG5NiElXwztfWexfmnzy59GIyFzzaBmy+ootG2xuE/QpwZu6U m+ow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F8HFVi6E; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-127736-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127736-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id m1-20020a632601000000b005f3d2aa7fa9si487825pgm.880.2024.04.02.03.34.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 03:34:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127736-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F8HFVi6E; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-127736-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127736-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 035092855E8 for ; Tue, 2 Apr 2024 10:34:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BC5664F897; Tue, 2 Apr 2024 10:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F8HFVi6E" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF7160DEA; Tue, 2 Apr 2024 10:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712054042; cv=none; b=Uq0U23Wj0BvarrtfnnFD0WUsMybmBLqIav9oERpiekziKYPOnssrOO1rITRK4hF+euKfWfx9mkQnBUntVyo4KAG7/3mauINhtOOXS447NTwMaAkpH6oeKKOW2I7kPwKpq4GIogYEEvvJOdpJp0WgrQGt2vNKlLg8dW8yyqy8mjE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712054042; c=relaxed/simple; bh=iitcsjz5f3Ckn5epCwD7TsbhsD3EMBPLfISwYi/UPLw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T9fXgnHll7FL2dbfgqDonXuNWFy1Zpusk2ql+qwqHj19QAx2kd9249JCDDiA+5XuCmDKAfE0ODLaOIGwl5R6QCfK+KZEcatNnIj8eOGkAlnDfhPojDxk8fAIjszAXZ7TEC3xCxx/SHAo0DXB7s0ILhLFWPTTRPcgucnyqQt7I2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F8HFVi6E; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4036CC433C7; Tue, 2 Apr 2024 10:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712054042; bh=iitcsjz5f3Ckn5epCwD7TsbhsD3EMBPLfISwYi/UPLw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F8HFVi6EHkStvMX6/pkYMuNU/GHsy7FJlMWgyo+DrIiixLToUEqndv6HzBmdDkLai 2rzB1rTY2ofTQ0dGh/bH6qpsxHXhVx6bEpneYEjKSBwgghd8lMH+pqdMJCjX171xNm PA2PqZ+RpicnL2sZTLNRRkRIobER7dXhAAAlsl7+rZKCrbt1gQmhgQhpNLDorsYUg4 jjDCS9p+4DJ7l0nGs0VlMvwXsqYDUPmvhLI+QIsk48KLquWaR0r2wJx7lpI4gWbYJG Dv/Bn+dMthjd+AN4qm82jYCt3TZQoWuVV2iu46E2JF69i1mZHz2+saURUIL8yR5tBm lq1jiXItJg0rg== From: Alexey Gladkov To: Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kbd@lists.linux.dev, linux-api@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-serial@vger.kernel.org, Helge Deller Subject: [RESEND PATCH v3 2/2] VT: Allow to get max font width and height Date: Tue, 2 Apr 2024 12:32:57 +0200 Message-ID: <78fcb9ad77b88edee8768806ce6a4d23f6d33118.1712053848.git.legion@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Console drivers has more restrictive font size limits than vt_ioctl. This leads to errors that are difficult to handle. If a font whose size is not supported is used, an EINVAL error will be returned, which is also returned in case of errors in the font itself. At the moment there is no way to understand what font sizes the current console driver supports. To solve this problem, we need to transfer information about the supported font to userspace from the console driver. Acked-by: Helge Deller Signed-off-by: Alexey Gladkov --- drivers/video/console/newport_con.c | 21 +++++++++++++++++---- drivers/video/console/sticon.c | 25 +++++++++++++++++++++++-- drivers/video/console/vgacon.c | 21 ++++++++++++++++++++- drivers/video/fbdev/core/fbcon.c | 22 +++++++++++++++++++++- 4 files changed, 81 insertions(+), 8 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c index e8e4f82cd4a1..87f174a95fa8 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -33,6 +33,9 @@ #define NEWPORT_LEN 0x10000 +#define NEWPORT_MAX_FONT_WIDTH 8 +#define NEWPORT_MAX_FONT_HEIGHT 16 + #define FONT_DATA ((unsigned char *)font_vga_8x16.data) static unsigned char *font_data[MAX_NR_CONSOLES]; @@ -328,8 +331,8 @@ static void newport_init(struct vc_data *vc, int init) { int cols, rows; - cols = newport_xsize / 8; - rows = newport_ysize / 16; + cols = newport_xsize / NEWPORT_MAX_FONT_WIDTH; + rows = newport_ysize / NEWPORT_MAX_FONT_HEIGHT; vc->vc_can_do_color = 1; if (init) { vc->vc_cols = cols; @@ -507,8 +510,8 @@ static int newport_set_font(int unit, struct console_font *op, unsigned int vpit /* ladis: when I grow up, there will be a day... and more sizes will * be supported ;-) */ - if ((w != 8) || (h != 16) || (vpitch != 32) - || (op->charcount != 256 && op->charcount != 512)) + if ((w != NEWPORT_MAX_FONT_WIDTH) || (h != NEWPORT_MAX_FONT_HEIGHT) || + (vpitch != 32) || (op->charcount != 256 && op->charcount != 512)) return -EINVAL; if (!(new_data = kmalloc(FONT_EXTRA_WORDS * sizeof(int) + size, @@ -569,6 +572,15 @@ static int newport_font_default(struct vc_data *vc, struct console_font *op, cha return newport_set_def_font(vc->vc_num, op); } +static int newport_font_info(struct vc_data *vc, struct console_font_info *info) +{ + info->min_width = info->max_width = NEWPORT_MAX_FONT_WIDTH; + info->min_height = info->max_height = NEWPORT_MAX_FONT_HEIGHT; + info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE; + + return 0; +} + static int newport_font_set(struct vc_data *vc, struct console_font *font, unsigned int vpitch, unsigned int flags) { @@ -688,6 +700,7 @@ const struct consw newport_con = { .con_scroll = newport_scroll, .con_switch = newport_switch, .con_blank = newport_blank, + .con_font_info = newport_font_info, .con_font_set = newport_font_set, .con_font_default = newport_font_default, .con_save_screen = newport_save_screen diff --git a/drivers/video/console/sticon.c b/drivers/video/console/sticon.c index 992a4fa431aa..d32ca458eb77 100644 --- a/drivers/video/console/sticon.c +++ b/drivers/video/console/sticon.c @@ -56,6 +56,11 @@ #define BLANK 0 static int vga_is_gfx; +#define STICON_MIN_FONT_WIDTH 6 +#define STICON_MIN_FONT_HEIGHT 6 +#define STICON_MAX_FONT_WIDTH 32 +#define STICON_MAX_FONT_HEIGHT 32 + #define STI_DEF_FONT sticon_sti->font /* borrowed from fbcon.c */ @@ -180,8 +185,10 @@ static int sticon_set_font(struct vc_data *vc, struct console_font *op, struct sti_cooked_font *cooked_font; unsigned char *data = op->data, *p; - if ((w < 6) || (h < 6) || (w > 32) || (h > 32) || (vpitch != 32) - || (op->charcount != 256 && op->charcount != 512)) + if (!in_range(w, STICON_MIN_FONT_WIDTH, STICON_MAX_FONT_WIDTH) || + !in_range(h, STICON_MIN_FONT_HEIGHT, STICON_MAX_FONT_HEIGHT) || + (vpitch != 32) || + (op->charcount != 256 && op->charcount != 512)) return -EINVAL; pitch = ALIGN(w, 8) / 8; bpc = pitch * h; @@ -273,6 +280,19 @@ static int sticon_font_set(struct vc_data *vc, struct console_font *font, return sticon_set_font(vc, font, vpitch); } +static int sticon_font_info(struct vc_data *vc, struct console_font_info *info) +{ + info->min_width = STICON_MIN_FONT_WIDTH; + info->min_height = STICON_MIN_FONT_HEIGHT; + + info->max_width = STICON_MAX_FONT_WIDTH; + info->max_height = STICON_MAX_FONT_HEIGHT; + + info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE; + + return 0; +} + static void sticon_init(struct vc_data *c, int init) { struct sti_struct *sti = sticon_sti; @@ -371,6 +391,7 @@ static const struct consw sti_con = { .con_scroll = sticon_scroll, .con_switch = sticon_switch, .con_blank = sticon_blank, + .con_font_info = sticon_font_info, .con_font_set = sticon_font_set, .con_font_default = sticon_font_default, .con_build_attr = sticon_build_attr, diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c index 8ef1579fa57f..b75d31ef3353 100644 --- a/drivers/video/console/vgacon.c +++ b/drivers/video/console/vgacon.c @@ -61,6 +61,10 @@ static struct vgastate vgastate; #define BLANK 0x0020 #define VGA_FONTWIDTH 8 /* VGA does not support fontwidths != 8 */ + +#define VGACON_MAX_FONT_WIDTH VGA_FONTWIDTH +#define VGACON_MAX_FONT_HEIGHT 32 + /* * Interface used by the world */ @@ -1013,6 +1017,19 @@ static int vgacon_adjust_height(struct vc_data *vc, unsigned fontheight) return 0; } +static int vgacon_font_info(struct vc_data *vc, struct console_font_info *info) +{ + info->min_width = VGACON_MAX_FONT_WIDTH; + info->min_height = 0; + + info->max_width = VGACON_MAX_FONT_WIDTH; + info->max_height = VGACON_MAX_FONT_HEIGHT; + + info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE; + + return 0; +} + static int vgacon_font_set(struct vc_data *c, struct console_font *font, unsigned int vpitch, unsigned int flags) { @@ -1022,7 +1039,8 @@ static int vgacon_font_set(struct vc_data *c, struct console_font *font, if (vga_video_type < VIDEO_TYPE_EGAM) return -EINVAL; - if (font->width != VGA_FONTWIDTH || font->height > 32 || vpitch != 32 || + if (font->width != VGACON_MAX_FONT_WIDTH || + font->height > VGACON_MAX_FONT_HEIGHT || vpitch != 32 || (charcount != 256 && charcount != 512)) return -EINVAL; @@ -1177,6 +1195,7 @@ const struct consw vga_con = { .con_scroll = vgacon_scroll, .con_switch = vgacon_switch, .con_blank = vgacon_blank, + .con_font_info = vgacon_font_info, .con_font_set = vgacon_font_set, .con_font_get = vgacon_font_get, .con_resize = vgacon_resize, diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 46823c2e2ba1..e10abe416159 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -101,6 +101,9 @@ enum { FBCON_LOGO_DONTSHOW = -3 /* do not show the logo */ }; +#define FBCON_MAX_FONT_WIDTH 32 +#define FBCON_MAX_FONT_HEIGHT 32 + static struct fbcon_display fb_display[MAX_NR_CONSOLES]; static struct fb_info *fbcon_registered_fb[FB_MAX]; @@ -2456,6 +2459,21 @@ static int fbcon_do_set_font(struct vc_data *vc, int w, int h, int charcount, return ret; } + +static int fbcon_font_info(struct vc_data *vc, struct console_font_info *info) +{ + info->min_width = 0; + info->min_height = 0; + + info->max_width = FBCON_MAX_FONT_WIDTH; + info->max_height = FBCON_MAX_FONT_HEIGHT; + + info->flags = KD_FONT_INFO_FLAG_LOW_SIZE | KD_FONT_INFO_FLAG_HIGH_SIZE; + + return 0; +} + + /* * User asked to set font; we are guaranteed that charcount does not exceed 512 * but lets not assume that, since charcount of 512 is small for unicode support. @@ -2483,7 +2501,8 @@ static int fbcon_set_font(struct vc_data *vc, struct console_font *font, h > FBCON_SWAP(info->var.rotate, info->var.yres, info->var.xres)) return -EINVAL; - if (font->width > 32 || font->height > 32) + if (font->width > FBCON_MAX_FONT_WIDTH || + font->height > FBCON_MAX_FONT_HEIGHT) return -EINVAL; /* Make sure drawing engine can handle the font */ @@ -3158,6 +3177,7 @@ static const struct consw fb_con = { .con_scroll = fbcon_scroll, .con_switch = fbcon_switch, .con_blank = fbcon_blank, + .con_font_info = fbcon_font_info, .con_font_set = fbcon_set_font, .con_font_get = fbcon_get_font, .con_font_default = fbcon_set_def_font, -- 2.44.0