Received-SPF: pass (google.com: domain of linux-kernel+bounces-127822-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Xu Yang <xu.yang_2@nxp.com>
To: Shawn Guo <shawnguo2@yeah.net>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>, "conor+dt@kernel.org"
	<conor+dt@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com"
	<festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>,
	"peter.chen@kernel.org" <peter.chen@kernel.org>, Jun Li <jun.li@nxp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "imx@lists.linux.dev"
	<imx@lists.linux.dev>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v10 03/11] arm64: dts: imx8ulp-evk: enable usb
 nodes and add ptn5150 nodes
Thread-Topic: [EXT] Re: [PATCH v10 03/11] arm64: dts: imx8ulp-evk: enable usb
 nodes and add ptn5150 nodes
Thread-Index: AQHae2fPbeVGy74CDUG/al6WTudLvLFUupkAgAAp8YA=
Date: Tue, 2 Apr 2024 11:06:26 +0000
Message-ID:
 <DU2PR04MB8822308A80FDCBB9547DB9208C3E2@DU2PR04MB8822.eurprd04.prod.outlook.com>
References: <20240321081439.541799-1-xu.yang_2@nxp.com>
 <20240321081439.541799-3-xu.yang_2@nxp.com> <ZgvDTPiBM65l3F+U@dragon>
In-Reply-To: <ZgvDTPiBM65l3F+U@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?krS/Ipl6YNZhv9gXncoTtjvK8/haNN4wFYM5EuxaQWI7lbDl+ppHjZL/FDTW?=
 =?us-ascii?Q?5eN8pwptvBjYGng2DcvR/zd+navFuFU9XB7+TdWJlaR1X3ZAL+zcptb//IRa?=
 =?us-ascii?Q?s54IRpIC9c8ABGa9ZAvSBKw8eMCv5PKV4JzcWHLnKqvIEkaQc7OhYFMQRQsf?=
 =?us-ascii?Q?Yi+BOcONdNVwv2u+df/Gb0iqNJYhM4SSjhXkpZJPkKtR5jp3JLE1weQXep80?=
 =?us-ascii?Q?vO5BCLHdRamJyq4ZqN6U0fpGxsllBnh5C6G3aITfeZ83oPXaIPoSYIpUNPFT?=
 =?us-ascii?Q?Pyy7POTSu9oy1LXYGtyIgSz6TuWmm99srzpqRbv0xzJn4QHz6OhcATnzYoSF?=
 =?us-ascii?Q?dpfjfpJotQZaxK/SflHC46TxVRRwB1XL9SOzzMogXeYrVs2ThJG7dZh+WZcq?=
 =?us-ascii?Q?etvM8bm0TnNVml/7IoFc2tKW6GKD7xkLN5o7nvJECbeIphOYcW++OW7gg2uq?=
 =?us-ascii?Q?mV/E6rQYl+FvnTGbr97/HK3hzDRytderWk9LUGHQe9Qob+89U82ePpJx0jKR?=
 =?us-ascii?Q?oU1q0r+DCv18z8j2Ggh9C3wTYkQJlngL2VstkEk3AgOctAUiAyGqK7YgIoJ4?=
 =?us-ascii?Q?Nj1CSMHwezWb2w+xWBCGiowxaLySwZdoFygzZjF0JqPAetLsRyrY+xtIG8Pf?=
 =?us-ascii?Q?/vvLcuPqfqCW4ew49z2Saeuso3f9emfixKD/NhZLHUgKhsXgo6KLsl8gY0b8?=
 =?us-ascii?Q?xDHsXC9bIjwEqezd3x9yxtlHREbO0NSUJB3CQZJDYWR7VpGXr7ONfd5JwHpH?=
 =?us-ascii?Q?mxM8UE0Lr8TRZvuQJClnpiFDWKPs9r5AreQw1PgWfmb8PRh+4n6vO4SWt729?=
 =?us-ascii?Q?ykWDJCkbVMbUZKFB9MvTcL1jEXgOhMmUCzLBMGpkrwZk9VgygqLuUK6fL/WN?=
 =?us-ascii?Q?rVaTfoDYGSta/36I4RstWrijX0z0tLk0tdFy5atEIn0hOdCcP6sNMuRBEGZN?=
 =?us-ascii?Q?GSThJ758RH04Tls8S1meW2hkUeHryR1IHTroBESELfPgYsMlTUmEX+RZPhJZ?=
 =?us-ascii?Q?9U8ikxwtkrKYC9bL3XeQscPOjDSEemEgwgZgfwyakScdQwr/b9FQVJmv5ovJ?=
 =?us-ascii?Q?JyoylP2SHYbOtAUPsrXuhZ7+1/CFYAolAaAa5IUcwVzx4pD2lGJ3od47bjZH?=
 =?us-ascii?Q?IVeUKfkHyJgORBCx/6yjGdUOqG59+M4wrOkJjrXbTwcnCH2CzYuAG3V9QW3/?=
 =?us-ascii?Q?GhlqUwjK0wE3lAX2/jqWQnW2ilaaTjEDVQPqCz6mOqT3G8AXXqMchHANRi+w?=
 =?us-ascii?Q?MsVdnRZQdObKDXeNlqlg3t2Q7tEeOV4lfJwHFAGW0lob9wq879Zy5x4/hc+Q?=
 =?us-ascii?Q?gzzNpJW4tdoo3g/ruecjGKDpBxglIQWM0Sb/zHtVcYukdS6ZueZVApOiaiQW?=
 =?us-ascii?Q?xFqjlCWVDIVdTGFL9l6JhtY7KuWy8oRZdQXRELYZJe8xmH1uhXvPlCpIOdfi?=
 =?us-ascii?Q?OOOPw4YYovSNqMJ7KAozZIIMwkNzMBhNysQCFAZUWwkpKck2CZUlI03Bs+wp?=
 =?us-ascii?Q?kbUdIAii/YMTNNMF+vwpLnivQzcPg3OFhGLS884qqNNJh7QpevVk+0AxsipA?=
 =?us-ascii?Q?1mrSQzcfYV+xTs95cHk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c9e8080-411b-4d81-7462-08dc5304f0a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 11:06:26.1790
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6ZRhAYzqqtpU297QQYg/VAnOTxW/QruQ6agFGHKkZEIAXBj74vl1SCffQIbJKHP+bCB7zzdcvxk1iE5Ze+ABag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9253


>=20
> On Thu, Mar 21, 2024 at 04:14:31PM +0800, Xu Yang wrote:
> > Enable 2 USB nodes and add 2 PTN5150 nodes on i.MX8ULP evk board.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> >  - fix format as suggusted by Fabio
> >  - add PTN5150 nodes
> > Changes in v3:
> >  - no changes
> > Changes in v4:
> >  - no changes
> > Changes in v5:
> >  - no changes
> > Changes in v6:
> >  - no changes
> > Changes in v7:
> >  - no changes
> > Changes in v8:
> >  - no changes
> > Changes in v9:
> >  - no changes
> > Changes in v10:
> >  - no changes
> > ---
> >  arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 84 +++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64=
/boot/dts/freescale/imx8ulp-evk.dts
> > index 69dd8e31027c..bf418af31039 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> > @@ -133,6 +133,64 @@ pcal6408: gpio@21 {
> >               gpio-controller;
> >               #gpio-cells =3D <2>;
> >       };
> > +
> > +     ptn5150_1: typec@1d {
>=20
> Could you sort devices in unit-address?

Okay.

>=20
> > +             compatible =3D "nxp,ptn5150";
> > +             reg =3D <0x1d>;
> > +             int-gpios =3D <&gpiof 3 IRQ_TYPE_EDGE_FALLING>;
> > +             pinctrl-names =3D "default";
> > +             pinctrl-0 =3D <&pinctrl_typec1>;
> > +             status =3D "disabled";
> > +     };
> > +
> > +     ptn5150_2: typec@3d {
> > +             compatible =3D "nxp,ptn5150";
> > +             reg =3D <0x3d>;
> > +             int-gpios =3D <&gpiof 5 IRQ_TYPE_EDGE_FALLING>;
> > +                     pinctrl-names =3D "default";
>=20
> Broken indent?

Yes, will fix it.

Thanks,
Xu Yang

>=20
> Shawn
>=20
> > +             pinctrl-0 =3D <&pinctrl_typec2>;
> > +             status =3D "disabled";
> > +     };
> > +};
> > +
> > +&usbotg1 {
> > +     pinctrl-names =3D "default";
> > +     pinctrl-0 =3D <&pinctrl_usb1>;
> > +     dr_mode =3D "otg";
> > +     hnp-disable;
> > +     srp-disable;
> > +     adp-disable;
> > +     over-current-active-low;
> > +     status =3D "okay";
> > +};
> > +
> > +&usbphy1 {
> > +     fsl,tx-d-cal =3D <110>;
> > +     status =3D "okay";
> > +};
> > +
> > +&usbmisc1 {
> > +     status =3D "okay";
> > +};
> > +
> > +&usbotg2 {
> > +     pinctrl-names =3D "default";
> > +     pinctrl-0 =3D <&pinctrl_usb2>;
> > +     dr_mode =3D "otg";
> > +     hnp-disable;
> > +     srp-disable;
> > +     adp-disable;
> > +     over-current-active-low;
> > +     status =3D "okay";
> > +};
> > +
> > +&usbphy2 {
> > +     fsl,tx-d-cal =3D <110>;
> > +     status =3D "okay";
> > +};
> > +
> > +&usbmisc2 {
> > +     status =3D "okay";
> >  };
> >
> >  &usdhc0 {
> > @@ -224,6 +282,32 @@ MX8ULP_PAD_PTE13__LPI2C7_SDA     0x20
> >               >;
> >       };
> >
> > +     pinctrl_typec1: typec1grp {
> > +             fsl,pins =3D <
> > +                     MX8ULP_PAD_PTF3__PTF3           0x3
> > +             >;
> > +     };
> > +
> > +     pinctrl_typec2: typec2grp {
> > +             fsl,pins =3D <
> > +                     MX8ULP_PAD_PTF5__PTF5           0x3
> > +             >;
> > +     };
> > +
> > +     pinctrl_usb1: usb1grp {
> > +             fsl,pins =3D <
> > +                     MX8ULP_PAD_PTF2__USB0_ID        0x10003
> > +                     MX8ULP_PAD_PTF4__USB0_OC        0x10003
> > +             >;
> > +     };
> > +
> > +     pinctrl_usb2: usb2grp {
> > +             fsl,pins =3D <
> > +                     MX8ULP_PAD_PTD23__USB1_ID       0x10003
> > +                     MX8ULP_PAD_PTF6__USB1_OC        0x10003
> > +             >;
> > +     };
> > +
> >       pinctrl_usdhc0: usdhc0grp {
> >               fsl,pins =3D <
> >                       MX8ULP_PAD_PTD1__SDHC0_CMD      0x3
> > --
> > 2.34.1
> >