Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1990692lqz; Tue, 2 Apr 2024 04:13:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV0yASNBdsQOZDuakjO0X6zeZkzQau5a2VXuJVPpJh0/19JlmT6kZR3DDwlSGdGMeaMy1t9Tdsbh+UzYO34MjbzeJF6EgjO4NaIdzT6Nw== X-Google-Smtp-Source: AGHT+IGjYYAlsv75ZTWmpUp+OLaJX3y/ySMg4ioJhsAVyVaZtq3OfcH3StnT3/YNQx10H0zE8asE X-Received: by 2002:a05:6a21:2d8c:b0:1a3:6833:1cf5 with SMTP id ty12-20020a056a212d8c00b001a368331cf5mr11321967pzb.29.1712056421521; Tue, 02 Apr 2024 04:13:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712056421; cv=pass; d=google.com; s=arc-20160816; b=TKkO0cJCCzP3LOLzondw6K9JXP7Hlg88fXtonqSER9swICW60N3t9iVgnHG1gi4iif vk3qmozxOKmg7Yj6Oe056oG1yQHGFZGrTZhnO3ArcPSFTvfiixAVn9G3fWfD97MN+YBI xCLqIuBkDLiZMzUoO6Mv13BKJGZJk522So6j0VtTwWK620ELKsy5eo4p6GCZBA+FV0G9 LXtXb/FnRacLEPc0CLRK5W3LDF8Q2GlLKjwVhdyna72rmWqBuiIhZ8tZjpc9BfPlK7nA jMLml7p6W2uLnJe/kLrUtiCza4Ol503kSfcuTa/2I5nu2nnnA27K+agyYUtUbaUQLfe7 5/TA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=+wScIIYCuS3okuM5iCNhPB7h15aR5cz5zXHllkO0Azc=; fh=48pWJh10ReEOXY9ip3gNq4ZZTYr6yuWa2E49V7YNpTY=; b=rPVCnB0QG9nVVpd4twTJ7aF42QQ2P+2ti1tS0J8/JQnA55KJxiHX8KjBS+xREf5ITF sXVsBUNyl3X8KwSh43x3EKGsUIWhH/vkX479slB+IkpH0B2OxN3hyqQ7qiXnOuIdAt3g Ljk4uHN+3bEpuAGS63tcESH6SeCDZibT5BjY8AOOPtYC+fmLbXemwmRhAZkCWqj2tYCi m5OG1kdT7rSIYidB/K5KNY5mjH5uH3sb4S5v82FU19gUzHfxgicZSiC106wS61tOxAjg FUsFnWw4zCfU4pCC5U8+Vxl46iiQHe9HZSZRVxqIenNPZegZFG9k0RNVMCMunYAvSzmU vaZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ttPHB8Im; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-127796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127796-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id c5-20020a170902b68500b001e20290828fsi10304181pls.637.2024.04.02.04.13.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 04:13:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ttPHB8Im; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-127796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127796-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 31A42B26507 for ; Tue, 2 Apr 2024 10:58:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 78BF2612EB; Tue, 2 Apr 2024 10:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ttPHB8Im" Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 762F07691F for ; Tue, 2 Apr 2024 10:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712055463; cv=none; b=EglVKcNGs0l4102lVw8yOXiOIGfyHy6WnjC9oUJsOTSe9mGaN8BfvoKo7XC4OB81p6+Meq1GEIAtigd+tmxY8o52atbs+OrFNkaVF98RLEMFCIZoiyBxDzErlSw7k6E1VCnDf2I9hKg4G/rcWXoepEJMCBtBbY3lIfZEBtiPWN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712055463; c=relaxed/simple; bh=wb8z4B2R8uSmX36QzPxkA3oErAbdtrPTFeokB1Hj6n4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=golfg70L8BWj3J8QipToZWpIe4Eq6Rhy3BcT5+wSavm3bMWaOk3mPCNYV25CxeZRB3LZaieTo8yCXyQQrCfbbMld7v25P3MYKOfQlozb4BjhjWYqjRf2hWWZ6AHai0beqelkwb8g2FUOl7Kvzs5Tg1OlFelkfE2V1seR/7LoMvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ttPHB8Im; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-60a104601dcso51334457b3.2 for ; Tue, 02 Apr 2024 03:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712055460; x=1712660260; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+wScIIYCuS3okuM5iCNhPB7h15aR5cz5zXHllkO0Azc=; b=ttPHB8ImvMyUiFYkAXv74ieSO8lUozsfq9L3DdR0WS23Qgt35kGyG5kFNJIWls2Ykl e5GLoaIp6U91wFM7ZiT3ArW7Ta3I3WOmO4YKeCmWQ5H1uJHK967kAg7tZlM25yrqRGkL oN6yzOySfUxhY2t5HZolxwUVvWOUPS2/HpRnqvudTv0Un+OFcQpjVwPUqP2z8HEW5DhV 7aCTMU9xx50ghxDashLoFkhcfAVGycBomwn30S68aKBezMb8Uuky1ZqgIVUIRL/IgsHr Nkm28+bxRYJ3nVo+FbcBYxUByNQRsCQLL5oRDchF87r7vyHcaIucGiiUceiAglYVFJRV krFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712055460; x=1712660260; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+wScIIYCuS3okuM5iCNhPB7h15aR5cz5zXHllkO0Azc=; b=EhIwhjIxkF6a1pqoNejfnPZjTkF10A0Lzkd0G88UUUEnoPLiuOB+5/f/n6N+FQ1vX9 GLP+mq66Fx1hTsvP97QUbvRBdj7v+Q5Kp7M+vM/YfpFy8QzGbRUV8FbNVHV/9dE8GCXp blTK9clOoMzBe8dtDweMeri/HQ8DL+KHxolUEvsp2n3Ge9z1/32wyZW7q0g6dlhmIh8B M6erInsfjV20TBSPJKg1TjE2FqBZSiYFVBG5L+FvoUzZ3BVouk6qVADGjkbqn5UMxZlK oCB/KqtwdqMQLP5k8SOCH5Rowuh8NGSVlvi7q2kaG7OYKN8Jux4xfuCrPyQsRGYk+SF6 a3Rg== X-Forwarded-Encrypted: i=1; AJvYcCX793ntp4jkV0ma1Hkgz6L1AEIUDQfPjn34Y8uPblBZPSTr1iBRtuFtuq1qn/YLkF7fdTwapBjVIJ3BwUxEUUeJSVYq3S7/XoD/DSYT X-Gm-Message-State: AOJu0Yxz2xN2FGkhMTZz0VZIuG0yJstlO/yo9sP/Lsg/Yv653b1ixv3O 4icjOPgo7DHNIGwXKXv3NdXslP4+2lrdZM7fk1f8wpOEWBfZ4Re2UsrZJa7mkUhxGVJgYGOyBPD Q3/DAVHAOTKOBUnWti0D2Hu2iPyS1jvpgf3+9Vg== X-Received: by 2002:a81:9194:0:b0:615:15fe:3cbc with SMTP id i142-20020a819194000000b0061515fe3cbcmr2251957ywg.25.1712055459131; Tue, 02 Apr 2024 03:57:39 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240327214831.1544595-1-helgaas@kernel.org> In-Reply-To: <20240327214831.1544595-1-helgaas@kernel.org> From: Ulf Hansson Date: Tue, 2 Apr 2024 12:57:03 +0200 Message-ID: Subject: Re: [PATCH 0/2] mmc: sdhci-pci-gli: Remove unnecessary device-dependent code To: Bjorn Helgaas Cc: Adrian Hunter , Victor Shih , Ben Chuang , Kai-Heng Feng , Sven van Ashbrook , Stanislaw Kardach , Brian Norris , Jason Lai , Renius Chen , linux-pci@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Content-Type: text/plain; charset="UTF-8" On Wed, 27 Mar 2024 at 22:48, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > Previously the driver hard-coded the config space locations of the Power > Management and the AER Capabilities and included device-specific #defines > for bits defined by the PCI spec. This replaces those with the equivalents > from the PCI core. > > This also replace hard-coded power state changes (to D3hot and back to D0) > with the pci_set_power_state() interface, which takes care of the required > delays after these transitions. > > Bjorn Helgaas (2): > mmc: sdhci-pci-gli: Use PCI AER definitions, not hard-coded values > mmc: sdhci-pci-gli: Use pci_set_power_state(), not direct PMCSR writes > > drivers/mmc/host/sdhci-pci-gli.c | 46 +++++++++++++------------------- > 1 file changed, 18 insertions(+), 28 deletions(-) > The series applied for next, thanks! Kind regards Uffe