Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1991275lqz; Tue, 2 Apr 2024 04:14:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXHfjK9DiDbOTVlbN7HBNYJVruOWjXfqhP65lAedSbGD8WrkccQqNgyKu+bUW/v00Z6RT2e6yUcn4SpiroERy2knuIihNpE9k1rZ42rpw== X-Google-Smtp-Source: AGHT+IHOiMuiN36d8sz3OmtZSRXBmNWkNuMoGs5ZIUiXMGBE1s30aqvnF/0770xj9e3FOcE59nFH X-Received: by 2002:a17:906:b48:b0:a4e:76c2:433a with SMTP id v8-20020a1709060b4800b00a4e76c2433amr2704770ejg.12.1712056449991; Tue, 02 Apr 2024 04:14:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712056449; cv=pass; d=google.com; s=arc-20160816; b=yaZEXefkfTQxkoYQo9m0kirdbNTble3vuXRL3l7Kw6yCWYIoSGkZK8Z8dS/Neh6Oij EuVHFcTMhdiv6xQ6uFNfQLjLtYtWwCbPRKG4L+isvgwipElNaUhg4WAPraxlhhy6Am7t m+CsPZ94chf9g00bJEY7VUmWdEzXPvwV/mVdMXlRuRXsQV3OV+obfmFJlLqXx54/8ULS 123dDytkxLV8nIupZGokeVhqXyigA8X0XQJaUGFbFS26+Jgm85KzKAH6w8DJBfvCZxMC c7dPP1sqtU/GEVZMIkpQZfKjVLQMY8LUBiLTgxOTsgZpsm9CUgt65daqgMZeGwl5YMQy oSTw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=bdHGBjHeM/eH4nxLFN9E9T1YEtTeIIrF9DVxdAAHQvU=; fh=m0DMVbfcHg173zkr1Tem/0RhgKBGcpk8Qi9vpOXL5Ig=; b=HKzf290H3xYPWPjKhxcVtszecuYWxEDqokh/A2elcX9WKyla5n9L9Y0K1eRSqx4/DI LDNoaTjVuvk1OkBXaa9/AG0Aj4t3Do/hKBG1+le16V0RHjnV51qFKxTcor2T9dNeB36l 9DOv8rQ9bxET74yYEsQNBfr8xrkLBa2rSmMmvagwPNTzS9xdUtuDn+6nMEvp72pUwxyy FVQz3VoHk4kk//UFw+LvE5YH8UEfosmZfK2k/3nAhEmQlns4VxEjdRE1AEqbiNqOZkt5 phUQQ+QnRqd2hOSD9g1/ICOgRWiNUXK6R7ND45qibbOfXiYVnRPZljSlDpvYUvySBzP1 MXKA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MRyTGaz6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-127831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127831-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 20-20020a170906059400b00a468bcde798si5631036ejn.59.2024.04.02.04.14.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 04:14:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MRyTGaz6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-127831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127831-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B49561F24609 for ; Tue, 2 Apr 2024 11:14:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CEE4160EF9; Tue, 2 Apr 2024 11:14:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MRyTGaz6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E714B604BB for ; Tue, 2 Apr 2024 11:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712056444; cv=none; b=DYPCSBBhWK4deJ3Vcc4rElzNQy0n0t4LQ65tiZz9zSrUqbYsGmYpSEhFOzSdtAu34f7butru/5iiwlKBa9XArATO3v6ZwuYLyfh9ogwcDR+TM3IuS465nM0ttJZCp0k6qfbkJgOjiiPj101MGD9peyZUROjeZBvMByxwEOpCSo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712056444; c=relaxed/simple; bh=yU3K+x6V4mI+yyO9moASq0ZRGkVzd9BUouUOy0FupEg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cYA9RI7wE1JXkukWs/ZS/fIGAMDp36OpZfqEkfi7L5pMUhAtv9bW9aUniRURGmrmmvN8jlvhLI/5AbrkTMzabyQqVQZnivbXEeZUAAokWGcx/4YqH5D+V2YeFHOFXRt8pewqO28KGrtt6xvdlKDItGilq7UppvOEGTwqLAInLAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MRyTGaz6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECB6DC433F1; Tue, 2 Apr 2024 11:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712056443; bh=yU3K+x6V4mI+yyO9moASq0ZRGkVzd9BUouUOy0FupEg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MRyTGaz6lpX+nputpagH/tmjwEMeTzZCafdimJ5AUMg/jfayewlFDUKRqXoUQ0TNf ZyWpfne0cLPL4VSzCfn935XOlqZR3evboLei5rU1FH52Tuj3ANln68pvR84P/dRFH2 Ln2ZYC8mvqCfXIwLpt5uARrWKZ3FSuJQv4cc4IMrLt/DBO2vGLp2gRQlWk2/DJsUjy D+LswAAGDczSFEKWBncXcXvcj2nXVMsMqTxkIO+qpQ2YcauQtz7UNVL8Zdemz8zoPC dhgI9AATdKYm4eLDlXaHlhhuPlGZCUcduuHb04vMrh+N5JsM8aPXKaITqbPD78stLY lPiB28KCav7wQ== From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= To: Samuel Holland , Palmer Dabbelt Cc: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Samuel Holland Subject: Re: [PATCH v2 4/7] riscv: Simplify text patching loops In-Reply-To: <20240327160520.791322-5-samuel.holland@sifive.com> References: <20240327160520.791322-1-samuel.holland@sifive.com> <20240327160520.791322-5-samuel.holland@sifive.com> Date: Tue, 02 Apr 2024 13:13:59 +0200 Message-ID: <87h6gkrp8o.fsf@all.your.base.are.belong.to.us> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Samuel Holland writes: > This reduces the number of variables and makes the code easier to parse. > > Signed-off-by: Samuel Holland > --- > > Changes in v2: > - Further simplify patch_insn_set()/patch_insn_write() loop conditions > - Use min() instead of min_t() since both sides are unsigned long Thanks for addressing the changes! Nice cleanup! Reviewed-by: Bj=C3=B6rn T=C3=B6pel