Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1994736lqz; Tue, 2 Apr 2024 04:20:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWnNMRNK4XfVX21BsrXYUBIop5ZoPzepUyInphofAMQpmKPhkJYP0y/3DfJKBtQrpsi43Bk7qgFD7EZ2I3s9qVxCvRnTpVmZXEatehReg== X-Google-Smtp-Source: AGHT+IGZJnsS57xXZ6Kvxd84n8Sq0EBe5umfWxhTqBmnyR99ZsL8LkdTgEqTdtnnn2yiE4NB1y0U X-Received: by 2002:a05:6871:3317:b0:22a:107c:4dd9 with SMTP id nf23-20020a056871331700b0022a107c4dd9mr12474868oac.56.1712056852810; Tue, 02 Apr 2024 04:20:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712056852; cv=pass; d=google.com; s=arc-20160816; b=nF990LiX9Nl9CFavrjTh66DTXsLyjrmi+K4CVvjsc+rxxV8X1XhuacnwI/H2IWuP+B M7U5m9BJ58EGHMTkFcM5078wY31ZNB8rBOzmxxB44g8l+6LojJJr4knnxGLqncubJIQJ MWRW0OpQc4A4pFQxa4d33kKDI3HEm5pCFURF5YomQtq51FKc2GoJVgefTV8FtlJb5EEq HUK1xvdb+emsBGAsFbAuH9bNP/qs+h5UkbsOYhNVrzKqD2vOpruBPJrBKedkT9w+jK9Y /fUrsAzOMCOV+JAXtRKKZPGvJ1Ty5OMS0tSTTHaaPF85zUryZHLTAJzBnmKzMrxh9xpz TY4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=apA0Uu4D1AgfLqcwFbImK2prYt2oHJJeyB/JlM/93O4=; fh=un/7AXazoEIibWjEhGIYzoVpGud9WBpRFG5JjZGiHEA=; b=1FBiGwbCC3zYNNV7nuG6sOAR3MtdFHkaK0PAajH2V3hn6gS2BjQjpf3S28ci0gM9V1 hxfIxQY5GIwbCzVDK/FPMPWkXOBBumvClYvhJV/DqV6NbG0zKirYAtgJxpBr9P3Mi72r mtXE8mUPXskR0Yev6xzD9yH+cZFw0IAQDWxA93aQqQUT/f0tXf7PwrMU1udzLs3MSJYI Dsqxyh2TmiEZyTMpeNYTWFnqSpInyNhBocxlIQg2QYWVJQSwuISmW2J4iId+ued6EH4x bDkYlQpgp/zZeZOPGXcMtHk5AIRpvyd1JtB++ocyz7ZgzYQR+HrN3jEfT08KRaO4PLPz uCgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=NnExroUT; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-127851-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127851-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d15-20020a63f24f000000b005dc785e4a28si10823072pgk.30.2024.04.02.04.20.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 04:20:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127851-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=NnExroUT; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-127851-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127851-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 71FAF281832 for ; Tue, 2 Apr 2024 11:20:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A64E9627FC; Tue, 2 Apr 2024 11:20:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="NnExroUT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="lBv/XW6m" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 187CA5A4C7 for ; Tue, 2 Apr 2024 11:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712056841; cv=none; b=E7ZVdsDgOYGEQaGWXe5IfGLipvvBkApwTz8d7H4BFiKOSG8ikLxri6kQhGTDZhorWYalegOzwr/dQy6io0UVGg0HoxqTuzKsCIuQNDQwXa+mBTiylQ1GoPD+4YA2WyeTmLoUfm5VXiQdMueYp4GLAZcDIu23dYhLx1OTFcOzrbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712056841; c=relaxed/simple; bh=I6RChiJFjQVbbUTWSKLmo+I28HKacpVxofusIsEVe24=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i/TK3W0rcN4SFZDU8pLltMy7pzSkqPlxPiXV13OEIq5YwCMdRQmozhOLVBLLqFpe9q5rxkwpQ3+2RidL2vWBpeIVVYZeOrpySl9DdLHNNnOEU//lt8w1EVbi+dL5g8xlEJ9xq8mhblIzCRcvB3NFF8Jms/7eRzK9MOD9PRli8u8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=NnExroUT; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=lBv/XW6m; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 52C6622419; Tue, 2 Apr 2024 11:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712056838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apA0Uu4D1AgfLqcwFbImK2prYt2oHJJeyB/JlM/93O4=; b=NnExroUT5vh/JpIUPeU+/Mg0nEpSEqcSvofpvlMqhpkjGO4a0AX6onoxENkOrRCFsVB/ED J9tPeDE/m2BGDSM8cy/dnPENfLIaFlF/k1zxagj0zvUK4XNCpiRbWb+tf35M3W6NYJqudo CWY0Jxa0580cCwhVAZVDNefnfTvIQLo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712056838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apA0Uu4D1AgfLqcwFbImK2prYt2oHJJeyB/JlM/93O4=; b=lBv/XW6mYKDUmkY/I0LALpdkywTpCO8tOoTCxrk/8M+0QNllVNsDrpjXe7tF7t9OwBr9HZ vTSo5OjReWMd82Cg== Authentication-Results: smtp-out1.suse.de; dkim=none Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id D3E5B13357; Tue, 2 Apr 2024 11:20:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id UYQtMQXqC2YVKAAAn2gu4w (envelope-from ); Tue, 02 Apr 2024 11:20:37 +0000 Date: Tue, 2 Apr 2024 13:22:02 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v3 3/3] mm,page_owner: Fix accounting of pages when migrating Message-ID: References: <20240326063036.6242-1-osalvador@suse.de> <20240326063036.6242-4-osalvador@suse.de> <50f31489-b5c3-480e-a7db-20edbbb2c9c2@suse.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50f31489-b5c3-480e-a7db-20edbbb2c9c2@suse.cz> X-Spam-Score: 0.31 X-Spamd-Bar: / X-Spam-Flag: NO X-Spamd-Result: default: False [0.31 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; NEURAL_HAM_LONG(-1.00)[-0.995]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[linux-foundation.org,vger.kernel.org,kvack.org,suse.com,google.com,gmail.com]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.59)[81.59%]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:98:from] X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 52C6622419 On Tue, Apr 02, 2024 at 12:26:51PM +0200, Vlastimil Babka wrote: > Can the migration still fail after __folio_copy_owner()? That goes again to > the comment you changed in patch 1/3. If it can, this will kinda create a > mess with the old folio's handles not reflecting reality? (although > refcounts will be ok) According to my research (I replied in patch#1), no, migration cannot fail after __folio_copy_owner(), so we are safe here (Tm). -- Oscar Salvador SUSE Labs