Received-SPF: pass (google.com: domain of linux-kernel+bounces-127857-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 2 Apr 2024 13:23:19 +0200
From: Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Haitao Huang <haitao.huang@linux.intel.com>, 
	dave.hansen@linux.intel.com, tj@kernel.org, linux-kernel@vger.kernel.org, 
	linux-sgx@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, tglx@linutronix.de, 
	mingo@redhat.com, bp@alien8.de, hpa@zytor.com, sohil.mehta@intel.com, 
	tim.c.chen@linux.intel.com, zhiquan1.li@intel.com, kristen@linux.intel.com, 
	seanjc@google.com, zhanb@microsoft.com, anakrish@microsoft.com, 
	mikko.ylinen@linux.intel.com, yangjie@microsoft.com, chrisyan@microsoft.com
Subject: Re: Re: [PATCH v9 15/15] selftests/sgx: Add scripts for EPC cgroup
 testing
Message-ID: <htiz5jgsby5v262saphhomcsxtixb2u7ot6jcghpfhvgz65ht6@qlz3gpdwapaa>
References: <20240205210638.157741-1-haitao.huang@linux.intel.com>
 <20240205210638.157741-16-haitao.huang@linux.intel.com>
 <4be7b291010973c203ed8c7bcd25b626c1290231.camel@kernel.org>
 <D04OVW6I8MUA.1OAIHFQ8943SM@kernel.org>
 <op.2lbjl0oawjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <D071OAFZ80O6.XEDXJ8AF4PK9@kernel.org>
 <D071QIHLW7MP.UM9R3VYETIOK@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yhu3ebu6ybc3o4aj"
Content-Disposition: inline
In-Reply-To: <D071QIHLW7MP.UM9R3VYETIOK@kernel.org>


--yhu3ebu6ybc3o4aj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello.

On Sat, Mar 30, 2024 at 01:26:08PM +0200, Jarkko Sakkinen <jarkko@kernel.or=
g> wrote:
> > > It'd be more complicated and less readable to do all the stuff withou=
t the =20
> > > cgroup-tools, esp cgexec. I checked dependency, cgroup-tools only dep=
ends =20
> > > on libc so I hope this would not cause too much inconvenience.
> >
> > As per cgroup-tools, please prove this. It makes the job for more
> > complicated *for you* and you are making the job more  complicated
> > to every possible person in the planet running any kernel QA.
> >
> > I weight the latter more than the former. And it is exactly the
> > reason why we did custom user space kselftest in the first place.
> > Let's keep the tradition. All I can say is that kselftest is=20
> > unfinished in its current form.
> >
> > What is "esp cgexec"?
>=20
> Also in kselftest we don't drive ultimate simplicity, we drive
> efficient CI/QA. By open coding something like subset of
> cgroup-tools needed to run the test you also help us later
> on to backtrack the kernel changes. With cgroups-tools you
> would have to use strace to get the same info.

FWIW, see also functions in
tools/testing/selftests/cgroup/cgroup_util.{h,c}.
They likely cover what you need already -- if the tests are in C.

(I admit that stuff in tools/testing/selftests/cgroup/ is best
understood with strace.)

HTH,
Michal

--yhu3ebu6ybc3o4aj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZgvqoQAKCRAGvrMr/1gc
jlAqAP9I+NeX7O9Wk3opsGFG1Fr8xK5z/v51TgzJ8ZmcnNxyHwD/aF7TmuF17oXt
aq0+sYznVp7gX2pLq4q7YyJ28in9uQM=
=9sGJ
-----END PGP SIGNATURE-----

--yhu3ebu6ybc3o4aj--