Received-SPF: pass (google.com: domain of linux-kernel+bounces-127854-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Subject: Re: [PATCH] LoongArch: KVM: Remove useless MODULE macro for
 MODULE_DEVICE_TABLE
To: Wentao Guan <guanwentao@uniontech.com>, zhaotianrui@loongson.cn
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
 Yuli Wang <wangyuli@uniontech.com>
References: <20240402103942.20049-1-guanwentao@uniontech.com>
From: maobibo <maobibo@loongson.cn>
Message-ID: <31d39556-79d9-52eb-36aa-5897aea6e28e@loongson.cn>
Date: Tue, 2 Apr 2024 19:21:55 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240402103942.20049-1-guanwentao@uniontech.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit


On 2024/4/2 下午6:39, Wentao Guan wrote:
> MODULE_DEVICE_TABLE use ifdef MODULE macro in module.h,
> just clean it up.
> 
> Suggested-by: Yuli Wang <wangyuli@uniontech.com>
> Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
> ---
>   arch/loongarch/kvm/main.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/loongarch/kvm/main.c b/arch/loongarch/kvm/main.c
> index 86a2f2d0cb27..7f2bd9a0814c 100644
> --- a/arch/loongarch/kvm/main.c
> +++ b/arch/loongarch/kvm/main.c
> @@ -410,10 +410,8 @@ static void kvm_loongarch_exit(void)
>   module_init(kvm_loongarch_init);
>   module_exit(kvm_loongarch_exit);
>   
> -#ifdef MODULE
>   static const struct cpu_feature kvm_feature[] = {
>   	{ .feature = cpu_feature(LOONGARCH_LVZ) },
>   	{},
>   };
Wentao,

Thanks for your patch, there is static variable kvm_feature
which is embraced by macro MODULE also :-), besides MODULE_DEVICE_TABLE.

Regards
Bibo Mao
>   MODULE_DEVICE_TABLE(cpu, kvm_feature);
> -#endif
>