Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2006372lqz; Tue, 2 Apr 2024 04:45:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXyBgan7fUWtFXx1nexXzT3zO4k6zLvOKIHNcBFfNae+4b2SJXKwsEMYq9QTf1hYhvavbQqpq3ymfSwzdq7DSpBI0/tuX886MNpYOnoNw== X-Google-Smtp-Source: AGHT+IEbYblJUSOnEDE+doQSQxAAMjflzD+HTNdiCApiUBDtWqClyxPw0okP+ZgzLLNCjc2RMWHJ X-Received: by 2002:a05:6a00:92a2:b0:6ea:ab45:6531 with SMTP id jw34-20020a056a0092a200b006eaab456531mr16064067pfb.16.1712058334357; Tue, 02 Apr 2024 04:45:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712058334; cv=pass; d=google.com; s=arc-20160816; b=Wc37TVnJEYiFYsNCJxAnXzCCR9qsWqjZr/L2n0cNoXH0vklv462KQm1RyUiTV0YM5m Lyqe6aIe4UrGYnI+Z8MfBYkWTx7hep/lo6L41SQ7OJli6js6JEUjtz5Xl3bYSyEjvY49 +ZaG9YXrReTEx6jRSIJoKv6H+vlEjyyOzLHbk0BQZ3SpNWSyumCsyRk5OydueHUZPYkL ic0HA7HZlZAwQjfnugQquav3phUUsBjO5MdeNEjngssaOw5mBV39sNZIEyCFawLCv1Lx XDAunvo7Qv+qxtwAvKmknTlo8LlF+3j1hSa/lJuPxpXGVNJXN38BkgyGTdRfdXl1H4LR 5jZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:dkim-signature:message-id; bh=s7KFpUxzWT01JAo7VRwp4/VBJiCBl5ryz2CQ5IR/FwM=; fh=48VwhmcAwZcRwl1G3sa8sMhC0oELlTDE3AJuhVa9XXA=; b=YYBYBEsNO55PJE3OwjNCGtXRCKw8NqkWE+l8oOjHG5OH9lSRjrsnMfMl9b1d0hsBTk jduydagDhM2p8RtmblCf+MkI2uee2+k5CwTet1BLEF79n7sizGoEBxGKw3lO5NYYAh0J 4UUuWsNtKZ2+OP6JWHLtY5CrI/rfGmZIHTWewoYR9AIQt1KVhdNiq8rRXyvKdF9+TR26 Pi22nt7HXg4LgOHqy4wh3a5g5xqgPExvurmyBRljbjboX51RDWYSZGOMKE1k10DhtNGT uVOSOGTasYD6f7oE8YgqsbomJag7HoqbpawLjUpk28JrMeSxGV1s2lWDLt3iKISnAev0 cWwg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kl.wtf header.s=key1 header.b="eCdOfXw/"; arc=pass (i=1 spf=pass spfdomain=kl.wtf dkim=pass dkdomain=kl.wtf dmarc=pass fromdomain=kl.wtf); spf=pass (google.com: domain of linux-kernel+bounces-127863-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127863-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kl.wtf Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id j5-20020a63cf05000000b005dc87f9cc78si11052577pgg.556.2024.04.02.04.45.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 04:45:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-127863-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kl.wtf header.s=key1 header.b="eCdOfXw/"; arc=pass (i=1 spf=pass spfdomain=kl.wtf dkim=pass dkdomain=kl.wtf dmarc=pass fromdomain=kl.wtf); spf=pass (google.com: domain of linux-kernel+bounces-127863-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-127863-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kl.wtf Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 98CFCB223A6 for ; Tue, 2 Apr 2024 11:30:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 04A63657AD; Tue, 2 Apr 2024 11:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kl.wtf header.i=@kl.wtf header.b="eCdOfXw/" Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8828360266 for ; Tue, 2 Apr 2024 11:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712057428; cv=none; b=d9apuTqSTLbzTlNCARgGCK8OUCGDv3BbqhmeTyzgMs3/FVvOPG+qUqobA0BoTaElX9dD4KLHKkpZabdnUWGLtpXni6kDzk5/gdid5oWvuXT+eHB4eal1yRFDZ2X9kQ5hYCDvjh+Ut+9po01O8DhN9UNdkVc1DVkMrH9tCbDPMKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712057428; c=relaxed/simple; bh=tbhpMwHqnguMJFastBE7yT0eZce5xm5zaf4fJ/sIAIA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pf82eeoIo8pENbBXRtpQA4zHKh3gKG/P/HJVrGWTLNHILyokUcUY+Q+/O13JdXIeWRan2X0wHl+JO0tSopRH/MQUzkjMxS0UqDx4NIiJJdXCm/dsmOETVVOkovreNAID5qJQtuI5K59ortA07B1RbCpABa4NOnaeyJP6zM1DxoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kl.wtf; spf=pass smtp.mailfrom=kl.wtf; dkim=pass (2048-bit key) header.d=kl.wtf header.i=@kl.wtf header.b=eCdOfXw/; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kl.wtf Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kl.wtf Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kl.wtf; s=key1; t=1712057423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s7KFpUxzWT01JAo7VRwp4/VBJiCBl5ryz2CQ5IR/FwM=; b=eCdOfXw/NwReOTpDcpJ60uaAifJ04TbNRBRtkvWrYbZ7gVZGhNX98mcGpIeXd59U02gZLg zzBdA0NpQkmhg9V1Y5KTN2iZ+G3oxQOFohwYux6PyecxyFW5qy6GDC+kvpSfJqZHFYhJtB 8R7CiMLzzgqOLpqmC3e8HKZBgVBgRpXnhAz7hjjsqBw2xIKJS5EhD+xbCXyHfy+tDJ4t2K pzY7E21iFXhXRBh4aya1S00Sg8pdr8dC9kMIVUSUoL1vjQlo2vKwTMt9kcNPMVa5LIDJJZ 8EKawZ0ufMqdRHbVZVn8mMwikYF0j8Bl7Q5rIXVEhoDOiLYv3dAgVhOYLS2L/Q== Date: Tue, 2 Apr 2024 13:30:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] HID: i2c-hid: Revert to await reset ACK before reading report descriptor To: Hans de Goede , Jiri Kosina , Benjamin Tissoires Cc: Douglas Anderson , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240331182440.14477-1-kl@kl.wtf> <391c60a4-b86f-48e4-ba64-abdcb79d71ef@redhat.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kenny Levinsen In-Reply-To: <391c60a4-b86f-48e4-ba64-abdcb79d71ef@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 4/2/24 1:06 PM, Hans de Goede wrote: > One small remark comment below. In the hope of getting this merged > soon I'll prepare a v3 addressing this myself (keeping you as the author). A-OK from my side, the abort_reset label is indeed redundant now. (The split between start and finish is also technically redundant when we always finish after start, but I wanted to keep the change minimal.)