Received-SPF: pass (google.com: domain of linux-kernel+bounces-127925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <359c5369-da09-49ba-a900-415f41911fa8@linux.alibaba.com>
Date: Tue, 2 Apr 2024 20:19:52 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()
To: gaoxingwang <gaoxingwang1@huawei.com>
Cc: idosch@nvidia.com, kuba@kernel.org, liaichun@huawei.com,
 linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yanan@huawei.com,
 Jiri Pirko <jiri@resnulli.us>, mkubecek@suse.cz
References: <ZgvpKNFcBw-39SOD@nanopsycho>
 <20240402121618.3575706-1-gaoxingwang1@huawei.com>
From: Heng Qi <hengqi@linux.alibaba.com>
In-Reply-To: <20240402121618.3575706-1-gaoxingwang1@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


在 2024/4/2 下午8:16, gaoxingwang 写道:
> Add missing colon in coalesce_reply_cb()
>
> Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
> Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
> ---
>   netlink/coalesce.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
>   	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> -	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> +	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
>   	show_cr();
>   

Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>