Received-SPF: pass (google.com: domain of linux-kernel+bounces-127935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240322-gpiolib-find-by-fwnode-stub-v1-1-05a0ceee2123@kernel.org>
In-Reply-To: <20240322-gpiolib-find-by-fwnode-stub-v1-1-05a0ceee2123@kernel.org>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 2 Apr 2024 14:30:05 +0200
Message-ID: <CACRpkdZn+eZEa62ZjttxS3sgT63t5bRtpueFmrG3fsrqDw=xSQ@mail.gmail.com>
Subject: Re: [PATCH] gpiolib: Add stubs for GPIO lookup functions
To: Mark Brown <broonie@kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, 
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024 at 5:14=E2=80=AFPM Mark Brown <broonie@kernel.org> wro=
te:

> The gpio_device_find_by_() functions do not have stubs which means that i=
f
> they are referenced from code with an optiona dependency on gpiolib then
> the code will fail to link. Add stubs for lookups via fwnode and label. I
> have not added a stub for plain gpio_device_find() since it seems harder =
to
> see a use case for that which does not depend on gpiolib.
>
> With the addition of the GPIO reset controller (which lacks a gpiolib
> dependency) to the arm64 defconfig this is causing build breaks for arm64
> virtconfig in -next:
>
> aarch64-linux-gnu-ld: drivers/reset/core.o: in function `__reset_add_rese=
t_gpio_lookup':
>  /build/stage/linux/drivers/reset/core.c:861:(.text+0xccc): undefined ref=
erence to `gpio_device_find_by_fwnode'
>
> Signed-off-by: Mark Brown <broonie@kernel.org>

Since we have already exposed the innards of gpiolib as much
as we have I guess it's a must:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij