Received-SPF: pass (google.com: domain of linux-kernel+bounces-127953-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Akhil R <akhilrajeev@nvidia.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
CC: "davem@davemloft.net" <davem@davemloft.net>, "robh@kernel.org"
	<robh@kernel.org>, "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>, "conor+dt@kernel.org"
	<conor+dt@kernel.org>, "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	Jon Hunter <jonathanh@nvidia.com>, "catalin.marinas@arm.com"
	<catalin.marinas@arm.com>, "will@kernel.org" <will@kernel.org>, Mikko
 Perttunen <mperttunen@nvidia.com>, "airlied@gmail.com" <airlied@gmail.com>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>, "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: RE: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver
Thread-Topic: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver
Thread-Index: AQHaedbyTqDDO44+YUOWKfWU3w8p3rFM/XcAgAgBdCA=
Date: Tue, 2 Apr 2024 12:36:41 +0000
Message-ID:
 <SJ1PR12MB63394D2C8C5329DE4B9B937FC03E2@SJ1PR12MB6339.namprd12.prod.outlook.com>
References: <20240319082306.34716-1-akhilrajeev@nvidia.com>
 <20240319082306.34716-4-akhilrajeev@nvidia.com>
 <ZgVCxnI0sZcE04io@gondor.apana.org.au>
In-Reply-To: <ZgVCxnI0sZcE04io@gondor.apana.org.au>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?3jC8nFDWBKiERIYVE/NeAuDSbXfdW0s1o7rjbrY38kj5+B8ZxLOQhCXX90ve?=
 =?us-ascii?Q?GgZZE00bsxaMXXWuARzUF8GcVzxm76rblhtKZx6oi+ywc+RkT54iRO+tegYx?=
 =?us-ascii?Q?OKDDTgEHKST9RhqKSzwkAXt4WCdfgPCT4rwjPDnppf5t7aYazEU85fVShOSa?=
 =?us-ascii?Q?jCeK3ZlYD6Hu9v72gSsH0n2QU6FIJEV6FtvobzA77bJlRWL0iKiNOT1EWpog?=
 =?us-ascii?Q?AxLAOp7aBCMRwKE6e9oNfUeCkBO8td+Y8isuKL299Htz4Fl6OSoeT97VCM3l?=
 =?us-ascii?Q?vhP+yMH3/bdNKrs+JBftFOqskEycuxlZA6ar0dYkxkAtSCgoIABb8Rl82e8d?=
 =?us-ascii?Q?yGtEynmDA2ZWca9r11GWnZ3JPK0Ze8JCxtNFI6pWnSrElTbbgDuuTWG+hh9X?=
 =?us-ascii?Q?/hxbqfPtFp+UlIgKqy9UwvbSmA0rSRAth9TBU7/1J/FGdKG/+vHoFLOSDAIO?=
 =?us-ascii?Q?xsgFSf76MTpT0VQXWo5sGCsa7hACY7A/Q8r379TlbFacaVfxRyONHe9ESnVC?=
 =?us-ascii?Q?wfHzho0g4G2x/xEj/plpV8tZepqDKKDWYyg6J+6KvIJjspUytax6KvuYFh8t?=
 =?us-ascii?Q?TeP2on30xWgbwpgfXDvCVJUCQCDEcbwv5nesq+ylkeb4tcMVakIxV75QwxIS?=
 =?us-ascii?Q?bSkg2cOm5D0XcWbWj8ShII3isEDUwYr2dKpnSLO0txZpGuehWEKYIiKXlg1f?=
 =?us-ascii?Q?nGsaTYOHrJ1mNFeZJmsJyaAjsYycWn7x+Dy4qSFEvug5HZSJZkMsPIvoT90g?=
 =?us-ascii?Q?ec2AAP53quTcapYeFwS5wuzgRXqm7Tsjo1V0cIW92N1S8loMr04NNLgsMZA6?=
 =?us-ascii?Q?2MIa2AYSf1a/YZVGSdgKytEqmjx7Q5xRYNF0dHskUj3mw1/BC70LCHnQSbpK?=
 =?us-ascii?Q?ftil+RrgypeRvhYhhY+mWkGOJY8Z74mt89cbm1a0nvra1VmmgaPL/7n40vV3?=
 =?us-ascii?Q?0iLXikDOko8AGzWfRJXN0nncjf5e2IctzvsMgFw2kjQFmJhKUKgyf8TInpa2?=
 =?us-ascii?Q?gS62Y8wyV7F6KGw4BKumQ2tkiQ6fRDcg7pRx26aVM3OM///MFlEt4leGmG7y?=
 =?us-ascii?Q?NNkov3BpTGlFd4Gni/4k0Sp+MG/Y4Qb7bACAGfh1J2uKQF6epmK8v3wyganH?=
 =?us-ascii?Q?so5bgFqRsC1I82m66wFsBL+U59gdtV8QBrCzeyHn0GMYKVgaiInJzxo6Ww1H?=
 =?us-ascii?Q?tmGmu0u5FO1D6BpUArZRm0dd1Q504Nu2sPM9SA5C4u3IW2pGxHPK39A+k9oV?=
 =?us-ascii?Q?YGQz0lZYCEVdqMHH+IWyNw2p3Cr9d/lrZeg3CEz3of1Gueq7IrI84ADrTesy?=
 =?us-ascii?Q?ybnNAgnq6LHGJ5W7xpco0hYEFxX8GEVBuFzWmVe/OQdtGhrZm+xB3uUApol8?=
 =?us-ascii?Q?fS42jT8uDmeWccXpzjoV4OvTXSesbub91T/NSwtsZoBVHqhO0N7bKHi5U1ro?=
 =?us-ascii?Q?NnITW+DD/1us3mwU4SpTtTNe3IDYUGCSfxTmb4bdXkPlQYsCS40jwOCW7ZWz?=
 =?us-ascii?Q?8658uvHqk3ou53hrz49aRsBYJppVAv8NmRZsBaSmu8nM9sB7KACNxSL63WSa?=
 =?us-ascii?Q?HOGSdVNA/2S1ce3WfUXWur92ghxfHYF49mSsm+iU?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6339.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f855cb73-98f0-401e-a3bb-08dc53118cb9
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 12:36:41.9949
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XEtx3b4EPU+NhxQPQvKhs/j/b4pD5kJhcnbWDAF2FebJaDNJqMCPlf0RKOIvB7qxLFbeZr6mD3NaHh9huSksbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6824

> On Tue, Mar 19, 2024 at 01:53:04PM +0530, Akhil R wrote:
> >
> > +struct tegra_sha_reqctx {
> > +     struct ahash_request fallback_req;
>=20
> This doesn't work because ahash_request is dynamically sized.
> So you'll end up clobbering the rest of the struct if a fallback ends up =
being used.
>=20
> You should place the fallback_req at the end of the reqctx and set the re=
qsize
> based on the fallback reqsize.
>=20
Should I set the reqsize as below in sha_cra_init()? Seeing this in other c=
rypto drivers.

        crypto_ahash_set_reqsize(ahash_tfm,
                        sizeof(struct tegra_sha_reqctx) +
                        crypto_ahash_reqsize(ctx->fallback_tfm));

Regards,
Akhil