Received-SPF: pass (google.com: domain of linux-kernel+bounces-127956-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <5f478d0e-5e7f-4e6d-a7d5-d6d50bb59722@nvidia.com>
Date: Tue, 2 Apr 2024 13:39:55 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V1] PCI: tegra194: Fix probe path for Endpoint mode
Content-Language: en-US
To: Vidya Sagar <vidyas@nvidia.com>, lpieralisi@kernel.org, kw@linux.com,
 robh@kernel.org, bhelgaas@google.com
Cc: thierry.reding@gmail.com, linux-pci@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
 kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20240401150116.298069-1-vidyas@nvidia.com>
From: Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20240401150116.298069-1-vidyas@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3FaRXZYT1BsU01BYktJRTNJZHM1ZTh1aGtvc0plYlFNNXlVdnZPREhVQ0Ri?=
 =?utf-8?B?TUg1czJUb01KNWNxUDE1cjBMcGRUd2oxQmJyVmNQQytobHlLNG5laVl1MFQy?=
 =?utf-8?B?VFpqTXdzVnVBVWhDRXBoQUtGeURkNjFWRCsrUFdWR1hJR1U3VHVFMUsvTXFT?=
 =?utf-8?B?Vncycm9MelRPTi9Qa2EyMS9uUitzUGZyZHZlTzRFcWw2c3RKNklJeklsVGhk?=
 =?utf-8?B?V1VrSGIwUFBxdjZXd1A0UndtUWpFai9HbmVGMjNMWWI0cmJMbmpBcGhMZ1V5?=
 =?utf-8?B?aE9Ta293ZmgzY0lhMVNYVDMxNWFodkxTZWNqZDc0QjBtV1VpS1ZEempjRC9K?=
 =?utf-8?B?Zlh0VTZVR08rL3VTTENKQit1ZDVFZHFWSmRXWXUrSWhGRm9USXRCbk9hUzhS?=
 =?utf-8?B?TzI3NmpEdnNJUWRVbUdXckFWbHVHSDU2S0h5dEhJL0QwMWpqVC9uWFNaZTg1?=
 =?utf-8?B?NEU0Tk56R25DQkNnUHZVUE85NmVLcFBncU5pOGx5eXY2bnNqajJ4OVdGelhq?=
 =?utf-8?B?eTY1MHB6TFRqVmFxNGNzY0JQcDdRckpIU3RuTURmbE0vTWdzV0JnQjlWd0Ri?=
 =?utf-8?B?cmMva0QyZCtKWnFScFc5L1Q3TWhvRVBvNmlaNTZ0WjlIeVd1RGgyWmdnRjBQ?=
 =?utf-8?B?NW1lNTNrdTJTZ082K1laRU9SdmEyYStEWElkbFRaZkpDN1cxTDZZMTIzYlBm?=
 =?utf-8?B?UzROYVZVN085VGFsQUtiOHAvVW96MXFtdjg2L1ZLc1F3NnFqRlZ2TUJXMlZr?=
 =?utf-8?B?bEZVRU1QRDVkcGtYUTJONE50WmVLL0dKeFB5ZktkcStIMU45UjA3T05ia3RL?=
 =?utf-8?B?V24xZnVoOXZCMC9lU2pYMlVVYUlmcWtaUDBXam8zdVZramZGZG9MWE5CSytz?=
 =?utf-8?B?T29WSzBrRUw4YnpnTjVra1doZjFJUFZuMkpaWHFveVkzMzY4dFdYYk4yYkxW?=
 =?utf-8?B?WDZ0V1NZcUJLUm5BVGUwbExHQ1MzbFpHRk4vbmhwTTMwSHdzR0ZGOVVkZU85?=
 =?utf-8?B?SWdLaXNLUFA3dkdDaVNNbmRxS2VBZlVnZ1NyWVdoVFE5eDRXei8rcnJPTUJV?=
 =?utf-8?B?Sy9NRm5KWFRyL1VVVlE3SVYzSWRub1Bkd0VxTzFhZXRyQnFrLy9pQjVONzNk?=
 =?utf-8?B?VGFBVU16UXVLemhTRFhBbFhnYmoydnlUelhqU08zdmd6bjJ4anB4WWVVS0RL?=
 =?utf-8?B?cFZiZk5WaTNQRFN5SG96djRKdVUwN2VudW9VV0t5ZDBOU3VEQjY2cksvVktQ?=
 =?utf-8?B?UjgwaXd6YTFGeW1ZN2x2T0dtcGs1OEluazN4RWlnSGZlNTl5S3J0TEdQQ1ZD?=
 =?utf-8?B?TW02VHJqM09BZllmQWpLZ3diUmErQnl4ck4zbEFnOEo4cjVEQmtYYldWbUpt?=
 =?utf-8?B?VjNtUE9aazI4aHppSFFWWVVTcFBzTEcxcktzTXpDTjJ6T3YrS1BxeDdoMzNZ?=
 =?utf-8?B?UkFKMkgrQUZldUZySElKREU3a1VIYVRGRkxCMTJCYnR3emJZNVdZRzRoWW16?=
 =?utf-8?B?YXg4cEpGcnNxT1hJTHdjVExqSGswQS9KWC94cHVCbmxNb0RQNzZYbUdRVk5o?=
 =?utf-8?B?Z2xsR0xFYkx4NU5uRVhuYWlRSWZ1cytwZGhLVVpCY1kvbjNzcXlSV1dKUm5R?=
 =?utf-8?B?U2F4cThRUm9qVy8rQW5ZdEVWTktjak95eXJ1R2Y3eG5PT1U2Zkx6VHdOL0xE?=
 =?utf-8?B?bmg5ZENuZGVob0ZBU2tnbEtwc2dJUTdiWlpKbldFMDR5TExTVzk4ZFJOSXcx?=
 =?utf-8?B?ZE9lQWlxcXZyU1N1ODcwbWpuanVJYWlsU0dKUTRuQjl5ZktTQk9mMmlJSWJs?=
 =?utf-8?B?b01YYmR6emptc2l3TUI5ZjdSSzRMb1o0NTFJNStaT0t2cmF3ZmVyYXJFN1FY?=
 =?utf-8?B?dXNNWEtpK3BZV2Y0SmNpMExBU0wxNGdwaUxIblV0ZmxqNEYrWnV0Q0lVMk41?=
 =?utf-8?B?c1dSSTJxREEweUoxYmQ3VW1MVmdKdEFQQlpPMWFWUWZnSGV3aTRJRGN2MGlZ?=
 =?utf-8?B?bnd2a3ZrUTZzaEtuNDFzYnFvZkIxWkRQQ0dLbmtPUmFzZ3Z2OWwrdDNEUGZV?=
 =?utf-8?B?eEtaMkpSTSsrWk5rZVdFRjAwckJOZHd6MUNtSXcxL05hTVdQVWxvajBsenRh?=
 =?utf-8?Q?mYOiNOcov4zqgoWsT8/z4nCJb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e946729-5164-4340-fe49-08dc531202d0
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 12:40:00.4234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zW+aB48wBIC4RBoVq9Gd/QYhxg413KkIjFMsIAimm4tsomXrhN4Lvzryz3oPZdV7QWb4jxpXo5S64st2VE3UmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4244


On 01/04/2024 16:01, Vidya Sagar wrote:
> Tegra194 PCIe probe path is taking failure path in success case for
> Endpoint mode. Return success from the switch case instead of going
> into the failure path.
> 
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>

Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194")

> ---
>   drivers/pci/controller/dwc/pcie-tegra194.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 4bba31502ce1..1a8178dc899a 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -2273,11 +2273,14 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
>   		ret = tegra_pcie_config_ep(pcie, pdev);
>   		if (ret < 0)
>   			goto fail;
> +		else
> +			return 0;
>   		break;
>   
>   	default:
>   		dev_err(dev, "Invalid PCIe device type %d\n",
>   			pcie->of_data->mode);
> +		ret = -EINVAL;
>   	}
>   
>   fail:


Otherwise ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic