Received-SPF: pass (google.com: domain of linux-kernel+bounces-127992-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 2 Apr 2024 14:04:19 +0100
From: Mark Brown <broonie@kernel.org>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, Heiko Stuebner <heiko@sntech.de>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ASoC: codecs: rk3308: add dependency on OF
Message-ID: <ec02a779-0917-456e-9bad-c5b12528206e@sirena.org.uk>
References: <20240329-rk3308-audio-codec-fix-warning-v1-1-b9d177fcd6c9@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9EstKrDm8LOGYP/I"
Content-Disposition: inline
In-Reply-To: <20240329-rk3308-audio-codec-fix-warning-v1-1-b9d177fcd6c9@bootlin.com>


--9EstKrDm8LOGYP/I
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 29, 2024 at 09:44:47PM +0100, Luca Ceresoli wrote:

>  config SND_SOC_RK3308
>  	tristate "Rockchip RK3308 audio CODEC"
> +	depends on OF

There's no actual build dependency on OF, please add an || COMPILE_TEST
to improve build coverage and help maintainability.

--9EstKrDm8LOGYP/I
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYMAlMACgkQJNaLcl1U
h9Ay3Qf/Wo0B0hupjC1VmyJdN9I/zAOXTyVjed/agCnRpuM0302J8EzwAEWEQi/1
dLVgsWnXA9iG6B97FvQdMzEM0pDFc0XtzMUJMIuAPBWWy6cgvf770uBXdvx8mZsH
bYSxBXeHgSQ4qTgxF/ZYEt914AuHsQ9olPAWmVzaCUE8t19tRk1MnNDqAgD32N73
acC7pzKDLSCMyc9xtJ1t0S0dMrLZSALFPXBrbIcvuOvT0QZigptSpJG8eh6/+zUZ
eagps6Kmrcm8l13TQbUIRFn56hwzC/a9gBVlvJc1yAtNcP63XbTgCS84MHOmtYGp
E34y5setEMRsMlzc7dO03YPxpplHwg==
=Kd6E
-----END PGP SIGNATURE-----

--9EstKrDm8LOGYP/I--