Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2093960lqz; Tue, 2 Apr 2024 07:09:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV856rPBnKbqkmV9eparj8JIQVoaSFlXmXY10UFja1MoBEJvU0Gs4JfW50YUxVBST7+AANN980suXrzQOm/gPaFBzGUSwwt1oE7AGGrgg== X-Google-Smtp-Source: AGHT+IHB5C0iExValz0CNRfuvL7ORBBu/r8PuRwKcKFtmjXePusTycDctAfOsGfpNtxDsZZ7QASc X-Received: by 2002:a1f:ebc2:0:b0:4d3:43f8:8541 with SMTP id j185-20020a1febc2000000b004d343f88541mr7933867vkh.1.1712066987184; Tue, 02 Apr 2024 07:09:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712066987; cv=pass; d=google.com; s=arc-20160816; b=OXdjg0IcbCNsIIrEzZSEglETEY167JkXVPPvT5Cc8QUc9nLfp2yjY0/MGAKzuySyMs C2uckA4mnYMliYu56JoFqsQaHTe73xaqKyOUfsTG99WK3eThQ0E31IBmE1OPlcNIow9j ycPW9/O9rKt9sWC4XzHOXMCyYTqhXqRPOc7tRNL+j0FDD7VQd8Vft5rcB0xw1zZb84Ui DMicIWhvQuL54Y1mJSPiYgY5bgqPWtxjyYTSslPIy1+Uphys5G3JijGOvuYgDnGVOUmy hdtP3Iodvzpw+D7FIHcm/eQPt7R7LTBY4xeVbIBFU0V2Efmvy492FUaJttg5DcdPP9GD 2+FQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=eapjraBYzS44Xc9a06PLjW9dS+Q5nFmHs+3L6JZLliQ=; fh=oMnFP44GZn5KSs5vtdAIvSX6p76oFoh48gPvpU1naKQ=; b=v99TZh8EBWvESu/C3Vz/TbhIzzEcjki63owfBrKBjntqhcRho7kJ9+6XyCSmJSY3u1 gL9hMSEkm0X2Eo7KDLhnMAMJ8TpxI/9UWSgkjWaCkKskrqpaJm/+Wgu8L/+sBt6QqEdu /kyOY35cnDodb0e/es6SR2GnMDgLqJaxJilLviXD91Fcy/MdIURhCuakGDwl9vvUSsJf 2d1kPwMZTaoCwRe9TCHfEqrxmyPkeroVh1X6emEbTIKDuHvJtsFpjA/GmE+WqxFJSkz6 tmBLSMToiX+NkuSncV7x6oFXzDZTJfvMH7H7q/+fVVZkmGQBIP1JFCF5CRBznfFuG1iK fbPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=vVbYjLtP; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-128107-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128107-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ba37-20020a0561220ca500b004d3a51e4e85si1699959vkb.112.2024.04.02.07.09.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 07:09:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128107-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=vVbYjLtP; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-128107-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128107-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6C0241C226BA for ; Tue, 2 Apr 2024 14:09:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C5A18615F; Tue, 2 Apr 2024 14:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vVbYjLtP" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9093985C46; Tue, 2 Apr 2024 14:09:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712066977; cv=none; b=L1Sc1Ye8PABkITIWePkvI5J20V4z5EXgbDnsMWkIZjRVCBHCT3T4hX96UjpPQ0MWtXBL1leIHLpQOwkDCJtW5ZpFz5n1xw4KDLngjGGdCtiQGn18vQKVOdLGgn3UwLUCFOdki36Eb640wRlpDRyLMwExH4Kllhn3Joe6hJRg2M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712066977; c=relaxed/simple; bh=aGc5dcE7aUaQO/qAQe2vO/xLUnnz35AEw5nLynNCBdE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=R59zMBWomorDiA5oT/KnwSpXckbe1vEIpDBFKABBKSmwTzTpEl4UPpYzWGxUrRbyeSC17OmTc58TdbKh8cOHuIKOgkr0a8GoOaXTJ6xzdxh/4KwQBomhfJmTrjnhNyB7stwoQq5nvOyZ6eo9j21UyyzVNCiaojgwWlB1lt6FJT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=vVbYjLtP; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from umang.jain (unknown [103.86.18.232]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A840466F; Tue, 2 Apr 2024 16:08:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712066937; bh=aGc5dcE7aUaQO/qAQe2vO/xLUnnz35AEw5nLynNCBdE=; h=From:To:Cc:Subject:Date:From; b=vVbYjLtPKNPcuqVuFQf5Bg3RgqaiKdraOEtOciOxbymeG71cp3J9dHiwdt97Ixdis A4CQJX3arv4VUd0N6wXIX7K1p6Wu3iv3hgP3OBLWl3twCoI4P7H2XbFNNREtsB3RKh 96VQMLDzA0XRKoE7aEVLXsRq3nXaCgLt9vtTgfb0= From: Umang Jain To: linux-media@vger.kernel.org Cc: Alexander Shiyan , Kieran Bingham , Sakari Ailus , open list , Dave Stevenson , Umang Jain Subject: [PATCH v4 0/6] media: imx335: 2/4 lane ops and improvements Date: Tue, 2 Apr 2024 19:39:18 +0530 Message-ID: <20240402140924.10009-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Another batch of improvements of the imx335 driver. Patch 1/6 adds support for 2 or 4 lane operation modes. Patch 2/6 call the V4L2 fwnode device parser to handle controls that are standardised by the framework. Patch 3/6 introduces the use of CCI for registers access. Patch 4/6 uses decimal values for sizes registers (instead of hexadecimal). This improves overall readability Patch 5/6 fixes the height value discrepency. Accessible height is 1944, as per the data sheet Patch 6/6 fixes the max analogue gain value. Changes in v4: - Do not change from window cropping mode in patch 4/6. In v3, the sensor was changed to all pixel scan mode to achieve height=1944, but it can be achieved in window cropping mode as well, by fixing the mode registers changes in v3: - fix patch 2/6 where we need to free ctrl handler on error path. changes in v2: - New patch 4/6 - Drop calculating the pixel clock from link freq. - CCI register address sort (incremental) - Fix cci_write for REG_HOLD handling and add a comment. - Remove unused macros as part of 3/6 Kieran Bingham (2): media: imx335: Support 2 or 4 lane operation modes media: imx335: Parse fwnode properties Umang Jain (4): media: imx335: Use V4L2 CCI for accessing sensor registers media: imx335: Use integer values for size registers media: imx335: Fix active area height discrepency media: imx335: Limit analogue gain value drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/imx335.c | 642 ++++++++++++++++++------------------- 2 files changed, 308 insertions(+), 335 deletions(-) -- 2.43.0