Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2095431lqz; Tue, 2 Apr 2024 07:11:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVvxUTyvXMeb0Cduvj8ssWpKa7sckUZBh4Cm+g6r7zYmRd5nGqdHE5Ht9JG9r+k+1hLvGtLpw9eV+92ET9e4HKZcmxfnQVGcQrQB9E6Fw== X-Google-Smtp-Source: AGHT+IEJ/jrdGVv9+TJNagkfMGsqkeJLLAWgQSC6v5Inu4gxGYXxaxQHmB9/j4v57neIdbMmyF2w X-Received: by 2002:a1f:c481:0:b0:4d3:31fc:4839 with SMTP id u123-20020a1fc481000000b004d331fc4839mr7281780vkf.2.1712067100171; Tue, 02 Apr 2024 07:11:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712067100; cv=pass; d=google.com; s=arc-20160816; b=wtsrcTueG5rqce6ChIaChH+zizaCKt7Ggx66AEf051YNRE5/4vx7Xk5WGxKe8l0CSv sylAClc+ZDnSk5qCTFhHA9IXHE2CDo8BBf6ScbBlsUUT3U1f5AwDqAJUI/kN7s6z/wHL halnZ6U8bw6qd1vT1UxDG1DMMEPXHiJrwn6ZSO1qQmy+TrQq8aSJJbBV/If0KP5Fpx+4 Q5XSr2MhF5uImho3eZiseIjH6IiVUiCjepUex7w+AzY6+FVxDXg6VfmVd5rb53V+UsWd ygeouAllCw/lLODRxh4zuatmD3Lomw0LF+L4upUgl05etZTx7hCcK8GUeWtcKEm6/3u+ j4GQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=1KejVCBS8qUa7/lBxxiYR3VMnlZ5Fgf0Q7rB/wL8KZ8=; fh=Wh0rRhYpIr3YqWADih4BR7TgH8kLEKTNQFyDnd/qf4E=; b=ltYkWNi2jow4hFlhRlHm/AMrpviv+rEQ1JMzBgBm/nh1oblbs608PfADxy1xR9kZ+L SZTNa9ED9/E3W/nXitOk3ECmPGTkW+3UPfv2Tnfhr47rPRtZszvoRtPjlBs0E8k2hdQ8 +W5JZhY7P5DO8TVa0oyHBnP7mo1NMVA8mkc/GaYH1KReYEKM0ZXYJYM51bpK3GFx2l9D Pv5iOkJ+rX2VYubz6/txPXNe9QXxqJVretXEioBr+eMFPKrjXDA2N+MGdQopTZ+Y28U0 sKbPFJnW3Dfejdl1rEygzEpVq9syiOXhJYKyerCnms2JAEcmQ0WxHuTn2hCQDmv92JiN TKLA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=CKjMS+lz; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-128115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128115-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id n137-20020a1f728f000000b004d88304bb3bsi1523998vkc.183.2024.04.02.07.11.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 07:11:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=CKjMS+lz; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-128115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128115-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BD7D21C22841 for ; Tue, 2 Apr 2024 14:11:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 004F11332AB; Tue, 2 Apr 2024 14:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CKjMS+lz" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67D5D132C19; Tue, 2 Apr 2024 14:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712066995; cv=none; b=rF9QeiAAtsD2pW5tDNHee6DwTAY3IWK7j3PKx31Ihe4zNmajrqien493qGooWR7zMuUgd1NEnzMRxjLUpUR164JVmsamLuV9XcrYRYgB+luZBwAQSlZU1tcujXnXafFf5HITTYiLe/bnGrQxtAgxETM3iZ3zPS6mtEDF5sGKzuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712066995; c=relaxed/simple; bh=l2R2+ukhGeOdEK5zvxB/TuakwAbZuTzRFW/X96M+/RM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q4Cdh3ajQTCji5dbSNbB4DeiYKdavZdKjo6h3x339jgJzqTlSTRFi/tsARvvMW1u0oWeVzMDuT4nr3e8Dq6suJHXKR2qS4F/nCtyf2w1/VoI5IRPS6Gz3y4CF+mtDf6964FlAvr6wLhhH9oqYEKbxOPF9AMTbbNf8oaNVXw0eck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=CKjMS+lz; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from umang.jain (unknown [103.86.18.232]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 238C266F; Tue, 2 Apr 2024 16:09:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712066955; bh=l2R2+ukhGeOdEK5zvxB/TuakwAbZuTzRFW/X96M+/RM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CKjMS+lz+fDspYkMfyRDBZ+4nFEidcAp8zasjQ/IB5cgjdlUYHPFVm1c05bAc91o3 RsJ7uWSGTOPB7S2deXS6/uSHMFEnzlpCDXJX2S/LyN2s2i/Gx+mqVH9WTRJRx7aNJ8 GgZO/0Zhfl70FO7Zcz7/vQbuhJhk/BU79tb1602U= From: Umang Jain To: linux-media@vger.kernel.org Cc: Alexander Shiyan , Kieran Bingham , Sakari Ailus , open list , Dave Stevenson , Umang Jain , Tommaso Merciai Subject: [PATCH v4 6/6] media: imx335: Limit analogue gain value Date: Tue, 2 Apr 2024 19:39:24 +0530 Message-ID: <20240402140924.10009-7-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240402140924.10009-1-umang.jain@ideasonboard.com> References: <20240402140924.10009-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The sensor gain (both analog and digital) are controlled by a single gain value where: - 0dB to 30dB correspond to analog gain - 30.3dB to 72dB correspond to digital gain (with 0.3dB step) Hence, limit the analogue gain value to 100. For digital gain, support can be added later if needed. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Tommaso Merciai --- drivers/media/i2c/imx335.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index dfc24783dc34..aed3efa9f590 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -52,7 +52,7 @@ /* Analog gain control */ #define IMX335_REG_AGAIN CCI_REG8(0x30e8) #define IMX335_AGAIN_MIN 0 -#define IMX335_AGAIN_MAX 240 +#define IMX335_AGAIN_MAX 100 #define IMX335_AGAIN_STEP 1 #define IMX335_AGAIN_DEFAULT 0 @@ -1175,6 +1175,14 @@ static int imx335_init_controls(struct imx335 *imx335) IMX335_EXPOSURE_STEP, IMX335_EXPOSURE_DEFAULT); + /* + * The sensor has an analog gain and a digital gain, both controlled + * through a single gain value, expressed in 0.3dB increments. Values + * from 0.0dB (0) to 30.0dB (100) apply analog gain only, higher values + * up to 72.0dB (240) add further digital gain. Limit the range to + * analog gain only, support for digital gain can be added separately + * if needed. + */ imx335->again_ctrl = v4l2_ctrl_new_std(ctrl_hdlr, &imx335_ctrl_ops, V4L2_CID_ANALOGUE_GAIN, -- 2.43.0