Received-SPF: pass (google.com: domain of linux-kernel+bounces-128128-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 2 Apr 2024 10:23:45 -0400
From: Frank Li <Frank.li@nxp.com>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de, imx@lists.linux.dev
Subject: Re: [PATCH v2 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY
 binding
Message-ID: <ZgwU8edE3VFYngWR@lizhi-Precision-Tower-5810>
References: <1712036704-21064-1-git-send-email-hongxing.zhu@nxp.com>
 <1712036704-21064-3-git-send-email-hongxing.zhu@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1712036704-21064-3-git-send-email-hongxing.zhu@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hJxfEO4N9WU+aiwhKXp/NLRyolFzLILbCZM0JZASfcpqsr6dS1CYpLVUOhn/?=
 =?us-ascii?Q?Nk8ckfdIvkWHS0sw6Qc4ckUBPQ3F4XEYwJhf9ipOhSQhjpBeaYCGFSQHwnWs?=
 =?us-ascii?Q?dzyKccDYpm4Kqqo+atUo6Z/cQ/A9C2eqQv4pySzyZL0rQTHDlRsbDh259QFU?=
 =?us-ascii?Q?HPUN7RwLtcX1pT7JWZ8E4Srx78SJW0r+JEa+eAP4KVpMB4tkPTJSi93wcAAM?=
 =?us-ascii?Q?sC/xDSFDKL5bvxAeBeNF4/RkM+4+IhmJzLkFGhM9e2MYK0+WMacj3ibeumcf?=
 =?us-ascii?Q?5nbRI3I6phSdZF1hUUprES4S1wOsmNChYIldpi/CsMb5tgiXgd3hmuM3JFai?=
 =?us-ascii?Q?Gy8Fna1ioWplAywo5n2ixd6JHkfQPE/u9n7RbVQZnU8PQo8jzpUblF8WOBpR?=
 =?us-ascii?Q?wNS9cy1pSyIVgF109JIdcuDjZBY6XFouaR7VzxBThm2BvV4KJrE3s0dBaQNC?=
 =?us-ascii?Q?Pqd7V4qLzC2C2dtKMOTSoTv6suar+2AWLov0j3az0Pi8hOR0HvqMukMmnBgu?=
 =?us-ascii?Q?o77W4PPYOsnPTYZT7xRnUFYpW1EWStPD6hKuEqgAbBWoOT89AZd+hPu9SDas?=
 =?us-ascii?Q?iaaws+F0cUoNif68n6IJLAidaYU4WSFsP8e8aP6J747a1yOrc3jqac+rRaF3?=
 =?us-ascii?Q?iP1p1ie/kCdrXkdBMVPVlmegQ/K8cvWWm+08A/2/2PxF0st8+iTQun28KfC0?=
 =?us-ascii?Q?WBDvwEvlFXXhgr0YKVxxbRF9lpZtd6CIPM/JaCEXp8bHHDZhvYxQztAbc985?=
 =?us-ascii?Q?rUfTW45NXq4IipGTtv/pbwTWTLbybZnEoTnxR/syYl+0icWN9Vso0UJ8zScj?=
 =?us-ascii?Q?4vQRYATvVOpWu4nWNXoam09xp50t+Mp1mHdTzHiE+oI1ie+EKrxKqH1Ks2Mm?=
 =?us-ascii?Q?fGbovFLp5gLl8pCVmQUgW2WpJBHBVmGSTYLJcqh4Akqgl4kC9vRx9eloR2s3?=
 =?us-ascii?Q?SgZlKLgBhXxic0ImIWp8STvp805UpL66PM/jO4e8RqTyLRLKL03M2zFxUDkp?=
 =?us-ascii?Q?b9uHmAM0WLmn2V8ZOLWtVaWu2ZurEPUJAqGah002XMZF/pCMFo0JM45XeqHi?=
 =?us-ascii?Q?ASc7wh5P1BZt/5QsXoXHeTlj8Sm6PU15qLgBl9PUQxz/zSb0Oc8ooIeKssTp?=
 =?us-ascii?Q?7uhRNfzlVGkujfHFhKFBsWrHt+hHrSPieWw80OQKwsSkaA2/1+zEppaeQv18?=
 =?us-ascii?Q?u2PLGNtaKsMO/SJ9Via2A9tA4svL+0v4+p/R5wVBs9ROro3SLANcbrOcLGdY?=
 =?us-ascii?Q?1vvEiworlNGKEENXm0T/6Smq7+uXkNPOFRErArQ2YFMomkgriP5JvqlLtn7A?=
 =?us-ascii?Q?OUTstlrIw+2jEEs5a1wFQczV0cc1AQIPhFVoGXPRhYhMoUl49x+aKbgMoyWl?=
 =?us-ascii?Q?24h9JW6GdqO+ZTsm+eFINBLtduQWBnAaSmbkdth66An82aA3RsZVA9pd+0tL?=
 =?us-ascii?Q?CVtvjXVlqzFxvvLGUPyFnoTvcZL19GeEFcnUKXwX6J8pgyPvxv8Gi3fHSHPp?=
 =?us-ascii?Q?uMUKNfLEosbSKt19/jLIN/AHi9RoQsa0E4Gp9E/GyPwr8gKOhHhDLSY9mwOC?=
 =?us-ascii?Q?RIh8BpaPx8D4nLStZyA=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be349250-44b6-40e0-cab9-08dc53208637
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 14:23:53.7699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hws+jl9jV1ofjAy4OpzjvenKfbaOxTuHnnepdFVGbOwGfA9lruKKpmVksve8FUAQv7wMIDU4q4HE4ejDTseieQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8910

On Tue, Apr 02, 2024 at 01:45:03PM +0800, Richard Zhu wrote:
> Add i.MX8QM and i.MX8QXP HSIO SerDes PHY binding.
> - Use the controller ID to specify which controller is binded to the
> PHY.
> - Introduce one HSIO configuration, mandatory required to set
> "PCIE_AB_SELECT" and "PHY_X1_EPCS_SEL" during the initialization.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>

You missed all conor's comments. 
Please double check v1's comments.

Frank

> ---
>  .../bindings/phy/fsl,imx8q-hsio.yaml          | 143 ++++++++++++++++++
>  1 file changed, 143 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8q-hsio.yaml
> 
> diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8q-hsio.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8q-hsio.yaml
> new file mode 100644
> index 000000000000..506551d4d94a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/fsl,imx8q-hsio.yaml
> @@ -0,0 +1,143 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/fsl,imx8q-hsio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX8Q SoC series HSIO SERDES PHY
> +
> +maintainers:
> +  - Richard Zhu <hongxing.zhu@nxp.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx8qxp-serdes
> +      - fsl,imx8qm-serdes
> +  reg:
> +    minItems: 4
> +    maxItems: 4
> +
> +  "#phy-cells":
> +    const: 3
> +    description: |
> +      The first number defines the ID of the PHY contained in the HSIO macro.
> +      The second defines controller ID binded to the PHY. The third defines the
> +      HSIO configuratons refer to the different use cases. They are defined in
> +      dt-bindings/phy/phy-imx8-pcie.h
> +
> +  reg-names:
> +    items:
> +      - const: reg
> +      - const: phy
> +      - const: ctrl
> +      - const: misc
> +
> +  clocks:
> +    minItems: 5
> +    maxItems: 14
> +
> +  clock-names:
> +    minItems: 5
> +    maxItems: 14
> +
> +  fsl,refclk-pad-mode:
> +    description: |
> +      Specifies the mode of the refclk pad used. It can be UNUSED(PHY
> +      refclock is derived from SoC internal source), INPUT(PHY refclock
> +      is provided externally via the refclk pad) or OUTPUT(PHY refclock
> +      is derived from SoC internal source and provided on the refclk pad).
> +      Refer include/dt-bindings/phy/phy-imx8-pcie.h for the constants
> +      to be used.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 0, 1, 2 ]

I remember needn't enum because there are header file.

> +
> +  power-domains:
> +    description: |
> +      i.MX8Q HSIO SerDes power domains. i.MX8QXP has one SerDes power domains.
> +      And i.MX8QM has two.
> +    minItems: 1
> +    maxItems: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#phy-cells"
> +  - clocks
> +  - clock-names
> +  - fsl,refclk-pad-mode
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx8qxp-serdes
> +    then:
> +      properties:
> +        clock-names:
> +          items:
> +            - const: apb_pclk0
> +            - const: pclk0
> +            - const: phy0_crr
> +            - const: ctl0_crr
> +            - const: misc_crr
> +        power-domains:
> +          minItems: 1
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx8qm-serdes
> +    then:
> +      properties:
> +        clock-names:
> +          items:
> +            - const: pclk0
> +            - const: pclk1
> +            - const: apb_pclk0
> +            - const: apb_pclk1
> +            - const: pclk2
> +            - const: epcs_tx
> +            - const: epcs_rx
> +            - const: apb_pclk2
> +            - const: phy0_crr
> +            - const: phy1_crr
> +            - const: ctl0_crr
> +            - const: ctl1_crr
> +            - const: ctl2_crr
> +            - const: misc_crr
> +        power-domains:
> +          minItems: 2
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/imx8-clock.h>
> +    #include <dt-bindings/clock/imx8-lpcg.h>
> +    #include <dt-bindings/firmware/imx/rsrc.h>
> +    #include <dt-bindings/phy/phy-imx8-pcie.h>
> +
> +    serdes: phy@5f1a0000 {

No "serdes".

> +            compatible = "fsl,imx8qxp-serdes";
> +            reg = <0x5f1a0000 0x10000>,
> +                  <0x5f120000 0x10000>,
> +                  <0x5f140000 0x10000>,
> +                  <0x5f160000 0x10000>;
> +            reg-names = "reg", "phy", "ctrl", "misc";
> +            clocks = <&phyx1_lpcg IMX_LPCG_CLK_0>,
> +                     <&phyx1_lpcg IMX_LPCG_CLK_4>,
> +                     <&phyx1_crr1_lpcg IMX_LPCG_CLK_4>,
> +                     <&pcieb_crr3_lpcg IMX_LPCG_CLK_4>,
> +                     <&misc_crr5_lpcg IMX_LPCG_CLK_4>;
> +            clock-names = "apb_pclk0", "pclk0", "phy0_crr", "ctl0_crr",
> +                          "misc_crr";
> +            power-domains = <&pd IMX_SC_R_SERDES_1>;
> +            #phy-cells = <3>;
> +            status = "disabled";

needn't status = "disabled".

> +    };
> +...
> -- 
> 2.37.1
>