Received-SPF: pass (google.com: domain of linux-kernel+bounces-128136-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Armin Wolf <W_Armin@gmx.de>
To: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com
Cc: corbet@lwn.net,
	sathyanarayanan.kuppuswamy@linux.intel.com,
	linux-doc@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/4] platform/x86: xiaomi-wmi: Drop unnecessary NULL checks
Date: Tue,  2 Apr 2024 16:30:58 +0200
Message-Id: <20240402143059.8456-3-W_Armin@gmx.de>
In-Reply-To: <20240402143059.8456-1-W_Armin@gmx.de>
References: <20240402143059.8456-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:cOspIHrHTEk=;M5tS7UAT8pdEkEZ/fNKPrM8LYx/
 LvFCU5LgIxZDnfY61dlgNTz8Ujj4Z95ZTkmljx6H0qMXQnRGu9M1sCSVT6AvZ+wPkW4wOdj8r
 wwqxrV/fxllsvfTF4IvWaFUCQEl3OqSC179eNOgZhA26Ia5+PabrnSq2fUVeLSDXbTo6v+RWY
 n9fRVqwtr226D4u2ql+a7NGDf3dhZaQ/d3q0N0Z4PDvNkeEyNQvoTimNyKRqWbJc0EsgjPjxT
 aiIz9YJ67h4VWD9RV1314B/SrVqabQhxl5wfN3UW5n4T+Lr/3kXRW2C1S0m/WM0fh9042mpuQ
 SdpQCKFkERPds4n3oUwfyPkYpA0J7JPKM8JbqxQ6wtlDQPGcYawh/exQrWQczAYfLVBtJ3b/t
 vPJYGKOcWWKq0ULh3F5Nt00adExqxEIeKtTme1d2BT/X5E5ZUFdvavaXjsX9Ur5ZpZ+mxn/n1
 vzZL+e7V960g62VCoqKzh5wSrKXpzQPL+OCT7BZAYWTx3LMknQ2zri23FBIEvuDtq8ya8r0uJ
 rNRjDGXylfnGJEeQDPGPqOcFLFHh2M9R3ybY+cyR9q6K6kOfdgZq8jgoG4UlJSwt3Xd5sec3h
 7d44e67are2896P7HuUw4khQjfM80ECi60dCosMhpY2MFubELmMa4MxB1OOU8ZHFRlRSE6Ugx
 Rwy57yGLZIBwy3bGtjnDX4b/fkY7fGVkAnfhwMT2Gj4Qmqikmnz2APWpHjAidIvkMzY8wOyKm
 swkw0Yk/RfYVhBGQcJxkc20cZxJ6j2JG32YnFB9vjoe7hW4V2vJ33XtxAVr5lamiym8on9B4e
 ud41QYvxAdL8zPm9YKIkCJdwpFma2AmWe2Mnz8N+kPTak=

The WMI driver core already makes sure that:

- a valid WMI device is passed to each callback
- the notify() callback runs after the probe() callback succeeds

Remove the unnecessary NULL checks.

Compile-tested only.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/xiaomi-wmi.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiao=
mi-wmi.c
index 7efbdc111803..cbed29ca502a 100644
=2D-- a/drivers/platform/x86/xiaomi-wmi.c
+++ b/drivers/platform/x86/xiaomi-wmi.c
@@ -38,7 +38,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, con=
st void *context)
 	struct xiaomi_wmi *data;
 	int ret;

-	if (wdev =3D=3D NULL || context =3D=3D NULL)
+	if (!context)
 		return -EINVAL;

 	data =3D devm_kzalloc(&wdev->dev, sizeof(struct xiaomi_wmi), GFP_KERNEL)=
;
@@ -66,14 +66,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, co=
nst void *context)

 static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object =
*dummy)
 {
-	struct xiaomi_wmi *data;
-
-	if (wdev =3D=3D NULL)
-		return;
-
-	data =3D dev_get_drvdata(&wdev->dev);
-	if (data =3D=3D NULL)
-		return;
+	struct xiaomi_wmi *data =3D dev_get_drvdata(&wdev->dev);

 	mutex_lock(&data->key_lock);
 	input_report_key(data->input_dev, data->key_code, 1);
=2D-
2.39.2