Received-SPF: pass (google.com: domain of linux-kernel+bounces-128150-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 2 Apr 2024 15:34:27 +0100
From: Mark Brown <broonie@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	Dave Martin <Dave.Martin@arm.com>, kvmarm@lists.linux.dev,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v6 1/5] KVM: arm64: Share all userspace hardened thread
 data with the hypervisor
Message-ID: <fb54d7b0-9c83-4a0c-a08b-b722c9381ca7@sirena.org.uk>
References: <20240329-arm64-2023-dpisa-v6-0-ba42db6c27f3@kernel.org>
 <20240329-arm64-2023-dpisa-v6-1-ba42db6c27f3@kernel.org>
 <87msqesoty.wl-maz@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3LQNOITM1KKeWjCg"
Content-Disposition: inline
In-Reply-To: <87msqesoty.wl-maz@kernel.org>


--3LQNOITM1KKeWjCg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 31, 2024 at 11:00:41AM +0100, Marc Zyngier wrote:
> Mark Brown <broonie@kernel.org> wrote:

> > As part of the lazy FPSIMD state transitioning done by the hypervisor we
> > currently share the userpsace FPSIMD state in thread->uw.fpsimd_state w=
ith
> > the host. Since this struct is non-extensible userspace ABI we have to =
keep

> Using the same representation is just pure convenience, and nothing
> requires us to use the it in the kernel/hypervisor.

Indeed, the additional data seemed contained enough that it was a
reasonable tradeoff.

> > the definition as is but the addition of FPMR in the 2023 dpISA means t=
hat
> > we will want to share more storage with the host. To facilitate this
> > refactor the current code to share the entire thread->uw rather than ju=
st
> > the one field.

> So this increase the required sharing with EL2 from 528 bytes to
> 560. Not a huge deal, but definitely moving in the wrong direction. Is
> there any plans to add more stuff to this structure that wouldn't be
> *directly* relevant to the hypervisor?

I'm not aware of any current plans to extend this.

> > @@ -640,7 +641,7 @@ struct kvm_vcpu_arch {
> >  	struct kvm_guest_debug_arch vcpu_debug_state;
> >  	struct kvm_guest_debug_arch external_debug_state;
> > =20
> > -	struct user_fpsimd_state *host_fpsimd_state;	/* hyp VA */
> > +	struct thread_struct_uw *host_uw;	/* hyp VA */
> >  	struct task_struct *parent_task;

> Well, this is going away, and you know it.

Sure, those patches are still in flight though.  It does seem reasonable
to target the current code.

--3LQNOITM1KKeWjCg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYMF3MACgkQJNaLcl1U
h9B5AwgAhpV1i1kBzNj1g27Or01g8HGoRjn1rDwbQhp9el4SuuJTTDy0hC7NoUu4
2yIpwVaql/hK/jq2O4qzjN/WaZpXEg1uQdt0UfSnyTa4LoDGwfnA5Bt7KNTCnCCK
7jnKGBvP1OEPSU/w7pQz029FV1hHySP73XNcXwpnE5YXuu5XVHZ/5x2mAYiP1XKG
SLRnMJ68l0yUMxbCbnJFAuWg04X3MxUmFZjOQtc1McnI5HJRmUN79OI9ifqrOEOU
e9XGatS9m3/Mfdr+z1sDK45sE+XSIHxMBHOFJDo1VY2DAXMoKYO244XiI4asC+y9
9uJmDNEyA7pg/yRI/cujvTKLtha6Gw==
=Gfx9
-----END PGP SIGNATURE-----

--3LQNOITM1KKeWjCg--