Received-SPF: pass (google.com: domain of linux-kernel+bounces-128231-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 2 Apr 2024 17:17:45 +0200
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>, Heiko Stuebner <heiko@sntech.de>, Thomas
 Petazzoni <thomas.petazzoni@bootlin.com>, linux-sound@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ASoC: codecs: rk3308: add dependency on OF
Message-ID: <20240402171745.2cae620a@booty>
In-Reply-To: <ec02a779-0917-456e-9bad-c5b12528206e@sirena.org.uk>
References: <20240329-rk3308-audio-codec-fix-warning-v1-1-b9d177fcd6c9@bootlin.com>
	<ec02a779-0917-456e-9bad-c5b12528206e@sirena.org.uk>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hello Mark,

On Tue, 2 Apr 2024 14:04:19 +0100
Mark Brown <broonie@kernel.org> wrote:

> On Fri, Mar 29, 2024 at 09:44:47PM +0100, Luca Ceresoli wrote:
> 
> >  config SND_SOC_RK3308
> >  	tristate "Rockchip RK3308 audio CODEC"
> > +	depends on OF  
> 
> There's no actual build dependency on OF, please add an || COMPILE_TEST
> to improve build coverage and help maintainability.

I see, thanks for the comment.

While there, an even better improvement is probably:

  depends on ARM64 || COMPILE_TEST

using ARM64 because this codec is known to exist only on the RK3308 and
ARM64 selects OF.

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com