Received-SPF: pass (google.com: domain of linux-kernel+bounces-128293-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e3ab1a65-5551-4a92-9972-14987426ea9c@oracle.com>
Date: Tue, 2 Apr 2024 08:51:52 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: qla2xxx: Fix off by one in qla_edif_app_getstats()
To: Dan Carpenter <dan.carpenter@linaro.org>, Quinn Tran <qutran@marvell.com>
Cc: Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream@marvell.com,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Larry Wisneski <Larry.Wisneski@marvell.com>,
        Duane Grigsby <duane.grigsby@marvell.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <5c125b2f-92dd-412b-9b6f-fc3a3207bd60@moroto.mountain>
Content-Language: en-US
From: Himanshu Madhani <himanshu.madhani@oracle.com>
Organization: Oracle America Inc
In-Reply-To: <5c125b2f-92dd-412b-9b6f-fc3a3207bd60@moroto.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dm0zOUJPcVpnRlJCak5KYjJQS1ZWbEhTYytuZWRjekJPa2k5RTdWU1hKSUEw?=
 =?utf-8?B?L2FnSU1SOW1tUFMwOFl6MTNGUUZtaXBvQlMveGo0VHRyd0ROSUtFTThPc3Yz?=
 =?utf-8?B?czBWS0tVL0Jjd2VnTmd6UmdTU2ZPQzZjcmZHNUk2Q1RUUkVqenNoTEk0Q3FD?=
 =?utf-8?B?ZzZNaXFZQnFUbXk5aHE2eU5SNnNLVC9FdlBDNmRQbVJ4dVF5WXM1UW93SjYr?=
 =?utf-8?B?ZXBGVGd3b3l3S2Y4RzFiMktMVDZQakhWVDFVUTFWT2JoSllhWmcvbkt5cW1v?=
 =?utf-8?B?NityNjB4WHVITVU0eGJEYUFMOWxPaG1lL2tYZVZkbXRYS3NhUHA0cW56Nlll?=
 =?utf-8?B?bGVwZTZOeENaY1pLaDRmbURVNDk3ZzhrNjZDTkxVd09IS2k5bHlnb0VkOU5Z?=
 =?utf-8?B?a2FBSE9mUVhvL2F2bE5YRktmT0lrcGFFL2J0YnJoLzVKc0p3ZlJjazlpWnF0?=
 =?utf-8?B?UTF5OU1RdWcxazhjOUJ4OWRpMkR3RXNYdkkwcGIzNGFCbGw4cnNHNVFkV2c4?=
 =?utf-8?B?dzRMUEd1WDRwRGRkQzdSUEl2bUIwT2h4SmNvV3F2Sm9iM3huLzBHaXJDSjV5?=
 =?utf-8?B?RkJ0RXhHcTJPY2hhODJ6VVhvNnBjVlRVRmJSbjJKbHJhZm1ENmpVeHpWU1N5?=
 =?utf-8?B?bXc0VDZnMFp1T21kbEE4RkVCTXM3WVljSjBrNWRNek53OHN0dGc5a2tVdXBT?=
 =?utf-8?B?eloxZHdJQi9HclZoYUx5RHMrTERlM0w2UTY5bG1qdlNGeS9mNTV6OTFkZ0Vu?=
 =?utf-8?B?UXJxRUFZYXJFL2xNMXo0Wmk1c2QzL1pGRDFsRVdXSlFNUXN5eXNhS1dwYlRz?=
 =?utf-8?B?MnNNVzR1cG0rWEtQZy9rSDJ4SGNkTHROK1F2VGw1MGZGM3BITm5aNW5jWkdw?=
 =?utf-8?B?K3U0aW1hSkpKLzk2bXZwLy9wdXpSZmU4Syt3MS9GdWdJUjc2Yk9waEFVQ1d6?=
 =?utf-8?B?U3cyTjg4WVY0WEpQUVA2M250eXZWazVNQ2ZyTVNiTGxCMzNSSjYyd1JOOTUz?=
 =?utf-8?B?S1FWMnpRZUI3eWMvbGVlT0xLTjQyVEl2QXBGckpTZ29vOVlJKzhzRnFCeGdk?=
 =?utf-8?B?VmRzVUZDYURaclFCWWtaMjY5UzgrSE8vdmdNcVU5WC8rNXhYTTRUekdGa0Fz?=
 =?utf-8?B?UWcxVngvNmxXR3VYdkNRd1g2akZqYzFiZ1Uxb2p6bHlNRkpwU2hXN2E2NEI2?=
 =?utf-8?B?ZEpsQWRRMVZZbFFRY1ZTZkxIR2FMYXFaZ1IvbWtqTEowRlJDc1BoK2F0WEoz?=
 =?utf-8?B?SU9VVFdQOHdLa1hoL1dqUUdGMC81czM2NU0yN3MvbFJkc3o0Q01iWWEyQTg0?=
 =?utf-8?B?MExuNkdpU3NINjlDYjgxVkJaT2pPVm1BY1BHODF2alBzcXFIQUpHREpNVjVl?=
 =?utf-8?B?Zzg5VE80cVBPRUdIVmxFMDlTSFM2NTBlVXB0R29sYXZWQm83dlV4M2xKT0Mv?=
 =?utf-8?B?a3ZPZ3BRc1lKNFdQYXI5aWZaeldGYkJ3MXRhTVRGbnR1TU5qWXVoNWZOODRU?=
 =?utf-8?B?OG1EN3ZjSWprUEZVZ1VFcVUzMHhDb0dRZi9ialI5elRFSXlPOVlpcjZRRzVI?=
 =?utf-8?B?dTh1dlpmS1NjOVZ4bHVjMWhEaGxhQ082THlRRXMvUnJqS2VDcW00T0p3ejJS?=
 =?utf-8?B?RzVRZXZRcy90aVpmRnYwVWZFTXhBNnJJcjgwUndlcElLM2I4dUJxL1RGekFG?=
 =?utf-8?B?T1NaYnJtZkJIWXdwTE9ybTY4NWdGS1hHQjdYV3VHejMzQ0pXYS9WYlduMzhv?=
 =?utf-8?B?VFcyTzcyNUhXdHJ2NThBaGNXYUxSK0pOZmVYRGZpS0xRQnAxcXB2VnZDb1kx?=
 =?utf-8?B?Tkt2enBsT3JwaG5KZDdxb1oyc3lIU09Xc284WnhXcFB0cEo2R1VkOWZyQ1Ux?=
 =?utf-8?B?M2k4Q2lidmJaWXpTQmpXVHpaSVYrZmxqRVpKODkzWW9qWHJHRGdiTkdJWGdI?=
 =?utf-8?B?Zzdxa0RlaSswb2pJMXVtTUxOcFhZN2R4YjRWeUZ0WU5sUittM0orQUdzMWtT?=
 =?utf-8?B?OHZzY3hiOGJ6YkUxZHRXZWMvM1liUWZLOVRLL2I0d2FpVTZyYUlFTXFKUFBG?=
 =?utf-8?B?cVdxTDg0SHpIUHozRWN6VDJqbE1DUmlkbnFzMDBVUThydzhsN3VlYzRvUFNZ?=
 =?utf-8?B?cW1iL1N4cnVicURKaUFKU2dqa0hPcGNWNXp2Vlp0QlpFRzBQTG4rVHhpR2xw?=
 =?utf-8?B?TVE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	2HqcN6YXGjWi+QrszWG8NZG7WHeRg0BnVaOtl26e8zVSnAXLkMlVt+92azwi2+FEXFcdw5LnYeSgE/Rclj2IZmF51fX1o1+8r3kxATJKvXlbQxqBhHy/vmRE2bcAqQujnoWcOPw43LltdqYF6iOx9vrJwHvBbQerg36rG0xh3wdqS0MD09YrWl4SDrw1N8GGVUWoFefwLCVMn2n+anCBOpIZO98prXccd0drNi3ykOcfNVXZX7a1Si42U0s6y9fm02iKK+dN/MmR5P38hCH3BBjkUQxxtY6sEjlzuuGaB+2Mm3z0RUGLNjEm9cKeJ5CIvz4DkoPqDJiWnupb/crocO0i+6+8aZdXbY7vv/kfpnY7XDOS0iISmoQ8USOwPU+KYdkyZa2E8wp+nC4vNMIvw3RMEzbVGg1Qp4q5W8+RlpXur4VpIB5WVsSpmOYqwDzjniwl6FQa/bdDdP4oKJ+9b9jXixCxcIABJfCEH0fzxwTLXyXRR1IDHdMA67AhmrisRwdPVbrgT3neO+kwhwMvDtA7VynJ53hOsUHYh9SK1Wp+DIkMGLBV/OwKDbL6802X7GeBim0oIBeEszH2mNs1BL8ZC0sNLfr/IPpN/t2Mkvs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad323d8a-f63f-4bed-e5a0-08dc532cd252
X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7959.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 15:51:55.3748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dFJ6m/C2R7asGQsRXfndWPub9a8PfwhNYx93Em6veDlL6elISEXDiGC7yX46TfJE4W9JnsQBFYPTNP18bVLhHFZxSGMgjlyws8Eq6AlpYaY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4860
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-02_09,2024-04-01_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 bulkscore=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403210000 definitions=main-2404020116
X-Proofpoint-ORIG-GUID: armxdlEycsGCP7vNQU0Y9QJAW914f9If
X-Proofpoint-GUID: armxdlEycsGCP7vNQU0Y9QJAW914f9If


On 4/2/24 02:56, Dan Carpenter wrote:
> The app_reply->elem[] array is allocated earlier in this function and it
> has app_req.num_ports elements.  Thus this > comparison needs to be >=
> to prevent memory corruption.
> 
> Fixes: 7878f22a2e03 ("scsi: qla2xxx: edif: Add getfcinfo and statistic bsgs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/scsi/qla2xxx/qla_edif.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
> index 26e6b3e3af43..dcde55c8ee5d 100644
> --- a/drivers/scsi/qla2xxx/qla_edif.c
> +++ b/drivers/scsi/qla2xxx/qla_edif.c
> @@ -1100,7 +1100,7 @@ qla_edif_app_getstats(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
>   
>   		list_for_each_entry_safe(fcport, tf, &vha->vp_fcports, list) {
>   			if (fcport->edif.enable) {
> -				if (pcnt > app_req.num_ports)
> +				if (pcnt >= app_req.num_ports)
>   					break;
>   
>   				app_reply->elem[pcnt].rekey_count =


Looks good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering