Received-SPF: pass (google.com: domain of linux-kernel+bounces-128295-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <2ab14f6f-2690-056b-cf9e-38a12dafd728@amd.com>
Date: Tue, 2 Apr 2024 10:54:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Content-Language: en-US
To: bp@kernel.org, ashish.kalra@amd.com
Cc: bp@alien8.de, linux-kernel@vger.kernel.org,
 linux-tip-commits@vger.kernel.org, michael.roth@amd.com, x86@kernel.org
References: <20240312184757.52699-1-Ashish.Kalra@amd.com>
 <20240402144547.18869-1-bp@kernel.org>
From: Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH] x86/sev: Apply RMP table fixups for kexec.
In-Reply-To: <20240402144547.18869-1-bp@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dzJVMUcwekxreTd1NzE4ZVpoQ3JVRXJRdUhDZm5rK2kzdlJVbDdxTkRtS1NW?=
 =?utf-8?B?UHJXRm5ZUjNrUlYwZHJnZU9aK3lPOWtGR3Q3ZWQ0QitMNm8ydWRIYldQaDVt?=
 =?utf-8?B?aGRoRlp1a1cvZVdvWFFFYndDNTVIYTlNaE8yQ29kTDlROHRUbkRTZUlOTC9Q?=
 =?utf-8?B?ZVpNZUoyV293alJLSnZ3V1U0RXhZZ1ZPUUUzczRCRHA1eWlleGo4VTBaYVhh?=
 =?utf-8?B?alU3VDhiZzF4TjV1Q0JNNUlkN000Ymlsd3dwaUJCd3JBNEJ5bFZBRmhmcWMv?=
 =?utf-8?B?b3NUM2NYMWJ0TDk0clRzSnk4NTZGRnNnS3ZtUVZoNTd4V2lkZ0djckVHZUQy?=
 =?utf-8?B?YXVrMnVBNlRTQmpHeHI0dW9rTWNoZTFtWktxbmxFOWYrRmtIbWoxQVhhWXNL?=
 =?utf-8?B?cDhRYTlxbFhleGNneUJ6MlNFMlBEa3VKdEN2Y0VSdnZKM014ZkZpN2lIQ2FY?=
 =?utf-8?B?WExabDF6QnNHdWQ1SHoxakh2Nzkzek1JRDU0QXpqYnlacnFpM3VCOXJQUnFP?=
 =?utf-8?B?VUMzVmlLZGkzV0lOZkRkYVljb2VjQTVObTgyODY2Q0U4dzRVb0o5ZFNwelBm?=
 =?utf-8?B?MEw2dFBsclJ3eXJqSHlGSFJJcXRwSFNrSkNiRXRodWJmcXNkRXhzWFo2RGJL?=
 =?utf-8?B?OENWWkJPdG0vOERBSjlEWllYUWdxVEF4WFRpaUJ2SkRyYkpFNTBCK3pzTG5n?=
 =?utf-8?B?eGdmeDBIV1d0Vkp6Q0IwN1k5d3hRMm1NWkx2WjU1NUlGdktvNkYvZ2dlaTBj?=
 =?utf-8?B?K3ZhbTVNNTdUUzd5VTdXTkFXRGM4Nm1yanQ5TUs3QTExd3NoNlB0NVVRYjlp?=
 =?utf-8?B?QVE1NEx0ekdFNmxoWk9Rak5YZ1E4bWJlNC9vak5Ja09xRG0xOFZVMzBtYm5n?=
 =?utf-8?B?V0xnZVRHdTBYWkRKb1p3ZEQ0YXdiM2tQWFhJK09lb1FEWVdZaHNLTllGV050?=
 =?utf-8?B?c09TL0doejZocDB4WjZVWTlpdjIzdVFEcERDQ2xFSnhaS0E2NkYwS2YydG1n?=
 =?utf-8?B?S1hvbXRWajJxQ1pCZnpiK1YvZU5JdCtRWnE3NndHNktCQTJsdVFrWEdDMStm?=
 =?utf-8?B?R3F4VUR5SjZHc0U1a3B2eUllZ2Z2MnF2Z2NENzAzM0EzOWhvdWw3aUNaZGpY?=
 =?utf-8?B?OEpkM1NSWTdXL0JWd2VWek1QMVhzUU5NSnRzT25sQ1VPTUpWS0lUdmVSUTVT?=
 =?utf-8?B?VkExbmF1cTg2RUUvdTZrQWRoZG5qN2QySUl4R09rdkRjQ0dpT29KbWZKOGFM?=
 =?utf-8?B?WmV6WkxPajJaTlZZcmhVZTdpZGFQTnZMa0U1RjZqcWVOdHZqeUhrMlpidThm?=
 =?utf-8?B?YjdyWlBKRit5RFBQelJvRzRwN242YjVjMkc1QXdEN1pCMFh0ZGt0VU10aWk3?=
 =?utf-8?B?UE9Uc0pJdW9NbS9lQ2dwOVNKZG9JZkNWall0N1N0VDBmRk1LRDZqbThsZndt?=
 =?utf-8?B?bVlGL1NVUnVGVC9UVEVQVFh4RGR1NFd3M054bm5yaTZLazdpN3BVUVdKdGhw?=
 =?utf-8?B?a2pISER1SVloZkZiVnM4bVUzU0pHb3o3S0FlekJrQjFxUDRRejlzNlRUSkNE?=
 =?utf-8?B?UjdocEpNWkJQaHlid2N6STVicEU2bHFuSElzYkpjOFFjeFJnYTZRNGhOKysv?=
 =?utf-8?B?enFwU2VWUVZGSE11ODBOWWlyaUNVZWFtQlV0Q2hwNzJyV0xtUC9OMGdCSXNs?=
 =?utf-8?B?ZkJ5YkU0RXllNk55NEZnUlhlNWRhV0FZR3JKWXlFNXBzR1pNTllPZXpCWGJX?=
 =?utf-8?B?aGhFWjMwWGdEN2FQVnBjcU5PdEE4Y3c0Qzg1azFENllUcEhkSmRoTDV4VW03?=
 =?utf-8?B?b0YyelgwQmx3UytlZTg1R0pPaE1iYlBwQ0pVRWY5SVlPOWdwMXpFZzlrY3dt?=
 =?utf-8?B?VDF5TmdVQU94am5iY1RoZmQzdDlrb2c5Tkd6YTk4d2doQ3NNNkp3d0J2T3hJ?=
 =?utf-8?B?eGM4Wmw5SnJGUWdCRXJmT0R0SzZ0cUNHT2JFZHBYSlNEb2RCeWhjczJuUVoy?=
 =?utf-8?B?NHcvOEc2YVVpNjVrTUJFanMzcEhWV3ZHM3pxTWdmZVB0OHpEQmJrcG1vM1p1?=
 =?utf-8?B?eW1HVUlLY3N3TmFaM0Z4ajFINVAyWjFJMkVHblRPZmtUVG4yVTRYa3V6azk2?=
 =?utf-8?Q?W3p+ch43SSQvmtlRILA50akmc?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f6a692a-221a-4fa4-e273-08dc532d3c10
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 15:54:52.7838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wg6z3XEsBOkpyX6e6YrSQ46a+FmulofJZex3QzxFVxoE11raw/eqVU1emQfApKY5JY+y+Fm3MWjwS+pMw4gWgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8120

On 4/2/24 09:45, bp@kernel.org wrote:
> From: Borislav Petkov <bp@alien8.de>
> 
> On Tue, Mar 12, 2024 at 06:47:57PM +0000, Ashish Kalra wrote:
>> From: Ashish Kalra <ashish.kalra@amd.com>
>>
>> RMP table start and end physical range may not be aligned to 2MB in
>> the e820 tables
> 
> This already sounds fishy. Why may the range not be aligned? This is
> BIOS, right? And BIOS can be fixed to align them properly.

There's no requirement from a hardware/RMP usage perspective that 
requires a 2MB alignment, so BIOS is not doing anything wrong. The 
problem occurs because kexec is initially using 2MB mappings that 
overlap the start and/or end of the RMP which then results in an RMP 
fault when memory within one of those 2MB mappings, that is not part of 
the RMP, is referenced.

Additionally, we have BIOSes out there since Milan that don't do this 
2MB alignment. And do you really trust that BIOS will do this properly 
all the time?

I think it needs to be checked and mitigated in the kernel.

Thanks,
Tom

>