Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2165315lqz; Tue, 2 Apr 2024 09:00:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWnSYGD/v+j6GT8okOBIUOQw0viuU5TXs2C+OYtSNhJvQ/ymSb8n5vjcsXJj+qKdoYfzKqz6O/jiWMMcg4bS2/Hfq7/QPsNT5AtkHz3yA== X-Google-Smtp-Source: AGHT+IEME2RpFqiQ3/ZRTtSKqss6MClNx15SLLGuzvcuATPdgrcP+Si43Q7npCKnA0oxIC12Vl0/ X-Received: by 2002:a17:902:e549:b0:1e0:a7b1:ee92 with SMTP id n9-20020a170902e54900b001e0a7b1ee92mr13612208plf.62.1712073623809; Tue, 02 Apr 2024 09:00:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712073623; cv=pass; d=google.com; s=arc-20160816; b=rzK4O/81XDBlJk3sUQsuO9QHhd76Lqg2tYWAOWfVUjMd2LGlgKOgKRyOd7DszLy038 6lqjzt3lb1mciAUJ7jSzOhnr8aCyUxZczQhZb3InlBfU/duc4H1I+oiDk5bvcXgkwzwl UTsbvPxfQ+fezqZ68KhOmpmQ8xfYtzBtBL6znYWrEyrWmjggt6ef6VxhUEoQrcmOWAnx Rm5m4eruIcnExgQtX7p+Z8lFOdyxgg+9jBF3CHkuY0fFk4fGE+u8QSNTRh2FsUr8jHyi qMGaP6WC9uzbDxznITVD1VMF+cUufty5ncMyieoGRj9lYYRjpMWjMLbmZBVJCLs1019q nivA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=SdjGldcPZPxMS0zls/bPrvPwPFn193dBT3yOh3km2+Q=; fh=FmC2hJpJhN2HT2Kov+KiTeKhNOezP0K1ntHb8ZYpOKY=; b=sOdcjTZX7tSbHS1cZQmo58ZS5sjXjV2H39w1m0fM/5Ta28ZperI7D1uKoB5AEx0TNU PkLr1HeAmT6LR2GBr57nIu1ewt0A4vfz6FQxn662TZk7JMIbPf8sGIyeSCdosyVZYiyA XM2Bk+QPRK38UkMeJZoi6lYTOswAkXbsySCywmh94v8DuTDz4Z9mj0HSncyJWxqfVD1X GZo6l4yjw4Tb1h3dleW/ogC8r2dXYbG0L3KFQcGt0VUkDrEd2oX35gOw80CNY+/627yv yam18rH71ESBzBO9NTWsbfhqhPzgmSza8j6dEVvkY3ohII3Cn+a+LHXdXkUBn9tvnRvt O1sQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-128303-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128303-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id k17-20020a170902c41100b001e08b6c8189si11527958plk.589.2024.04.02.09.00.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 09:00:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128303-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-128303-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128303-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F415D28F098 for ; Tue, 2 Apr 2024 16:00:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BCBC136649; Tue, 2 Apr 2024 15:59:09 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 76652131720; Tue, 2 Apr 2024 15:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712073549; cv=none; b=ndM2xQq5T3Wr75mqxjcIwCb2joZBExCKstXKqeMaX8eNrq6sulT0qie0vsEvKFEDt26qdyz9kJOSVPcr5TKwChm+zkAVBYvgKelIDMUEN9a0wgTcIBP+YdFwpuVqu0E2/vzf0iuavZmVOLfPkcrKaE/BqC2cwroQ3yaqfz2bAuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712073549; c=relaxed/simple; bh=qnN9weQ8zePSFzOoB2/Nqdch/QqBxOvQUT/3iZ1s9A4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JDi9EuK11EhSYuUks0f/JWp1AnvHDSizHhExFuaF91OM0EdXZIdDlbaEHod9J66/sQUFIi1Ks8hjYymP23C/2F95R3+jSoGFxGoJk1WqF2/3V1d/CCASs4YaGZGHIr2tMb9OsCP9aba6VcO5A/lOF+JGoPjrquG36gc1JjzmmBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CB3A1042; Tue, 2 Apr 2024 08:59:38 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.72.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 514333F64C; Tue, 2 Apr 2024 08:59:04 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [PATCH v4 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Date: Tue, 2 Apr 2024 16:58:22 +0100 Message-Id: <20240402155822.505491-5-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240402155822.505491-1-lukasz.luba@arm.com> References: <20240402155822.505491-1-lukasz.luba@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the voltage for OPPs is adjusted there is a need to also update Energy Model framework. The EM data contains power values which depend on voltage values. The EM structure is used for thermal (IPA governor) and in scheduler task placement (EAS) so it should reflect the real HW model as best as possible to operate properly. Based on data on Exynos5422 ASV tables the maximum power difference might be ~29%. An Odroid-XU4 (with a random sample SoC in this chip lottery) showed power difference for some OPPs ~20%. Therefore, it's worth to update the EM. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Lukasz Luba --- drivers/soc/samsung/exynos-asv.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c index d60af8acc3916..d6d003e3a81ab 100644 --- a/drivers/soc/samsung/exynos-asv.c +++ b/drivers/soc/samsung/exynos-asv.c @@ -11,6 +11,7 @@ #include #include +#include #include #include #include @@ -97,9 +98,17 @@ static int exynos_asv_update_opps(struct exynos_asv *asv) last_opp_table = opp_table; ret = exynos_asv_update_cpu_opps(asv, cpu); - if (ret < 0) + if (!ret) { + /* + * When the voltage for OPPs could be changed, + * make sure to update the EM power values, to + * reflect the reality and not use stale data. + */ + em_dev_update_chip_binning(cpu); + } else { dev_err(asv->dev, "Couldn't udate OPPs for cpu%d\n", cpuid); + } } dev_pm_opp_put_opp_table(opp_table); -- 2.25.1