Received-SPF: pass (google.com: domain of linux-kernel+bounces-128304-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Haiyang Zhang <haiyangz@microsoft.com>
To: Jakub Kicinski <kuba@kernel.org>, Dexuan Cui <decui@microsoft.com>
CC: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, Wei Hu
	<weh@microsoft.com>, stephen <stephen@networkplumber.org>, KY Srinivasan
	<kys@microsoft.com>, Paul Rosswurm <paulros@microsoft.com>, "olaf@aepfle.de"
	<olaf@aepfle.de>, "vkuznets@redhat.com" <vkuznets@redhat.com>,
	"davem@davemloft.net" <davem@davemloft.net>, "wei.liu@kernel.org"
	<wei.liu@kernel.org>, "edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>, "leon@kernel.org" <leon@kernel.org>,
	Long Li <longli@microsoft.com>, "ssengar@linux.microsoft.com"
	<ssengar@linux.microsoft.com>, "linux-rdma@vger.kernel.org"
	<linux-rdma@vger.kernel.org>, "daniel@iogearbox.net" <daniel@iogearbox.net>,
	"john.fastabend@gmail.com" <john.fastabend@gmail.com>, "bpf@vger.kernel.org"
	<bpf@vger.kernel.org>, "ast@kernel.org" <ast@kernel.org>,
	"sharmaajay@microsoft.com" <sharmaajay@microsoft.com>, "hawk@kernel.org"
	<hawk@kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"shradhagupta@linux.microsoft.com" <shradhagupta@linux.microsoft.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic
Thread-Topic: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic
Thread-Index: AQHagiFTMR5ZlnaVikeExhfsF+DuY7FPaYIAgASmJ+CAACS3AIAAL1UAgADFKBA=
Date: Tue, 2 Apr 2024 15:59:10 +0000
Message-ID:
 <DM6PR21MB1481D2981B497CB339D84CBBCA3E2@DM6PR21MB1481.namprd21.prod.outlook.com>
References: <1711748213-30517-1-git-send-email-haiyangz@microsoft.com>
	<CY5PR21MB375904FD3437BA610E6BDBD1BF392@CY5PR21MB3759.namprd21.prod.outlook.com>
	<CH2PR21MB1480E02C74E7BB5A52A71859CA3F2@CH2PR21MB1480.namprd21.prod.outlook.com>
	<CY5PR21MB37590FD539C1E380FBDC96B0BF3E2@CY5PR21MB3759.namprd21.prod.outlook.com>
 <20240401211232.57b17081@kernel.org>
In-Reply-To: <20240401211232.57b17081@kernel.org>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=7a53aba1-ff31-4942-97c5-083718b803d2;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-04-02T15:58:11Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR21MB1481:EE_|PH0PR21MB1895:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 4noJW76wByI4bGQgenQ7ju6ZHDd+36JykCVsd8MCMMMZ1ATfv0AWoaYonq9PjCVdfc3aeU4OTh1X443erMMqk7Vz+ohAPdJDSoOn7VcHOy+dt5cn/AWj+y6jKtqm+NPtq8SGKngX0EH+R/WD1eIsXe85nyY75je1cvfD0NFkTqaMHpLCjQ5AoejBECGUAz4jiPlED2xTn445fQwPvVeDqbU60LbVZD9TpkniKGab+9++ti3YKngatQyeROGGzbZxsfgl3qY9bzKb1cQeAEl24mD85ORS67FOanJ+57wH1JE4VkDO1vLumKXsvzC+vw9ftNb6Vt898GNMkoUvkBKbMaO46cR0EWtDx7G91U5UUx7IvI3pEoPDK0GO+IYo91j9G73DsbXDI0a5AF36IX4BjpasJHtsPcA2JZlCzIQvSLO8Nxu60tlyoDXH2G3RqpSvvlOWHvx6C99AIF44S0XR/yjNmKHW/HH/wAT9etvl/WdhEmv3syxv50kehR+1sO9X7z3XeNzcWZUQXJ41Mkef+rd70D7qYVLooDRGAWoNxA096lCw8jeKfvruosDaOT6B8TKjepbmW0dSfbqjlgk1Abqd4RaSekGPd7sI0lrvSVZ6MVwSSA51kYJTZLTNOV+9ZK9owobWi8hYxfh3tXU9Sw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR21MB1481.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(7416005)(366007)(376005);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?YiC2Z4s3wHbecuru4/m6dxVHXVIaFIrgoHoEvgj9krtlSvww2rJGJagZQn56?=
 =?us-ascii?Q?JhgjzjCq4iZKSdyBrska3ub6G3kzRCjfx4ef2uhoOQkcS4Ale+gKKcwWxlRw?=
 =?us-ascii?Q?OAVObSfgaKaN6z6OZ2Yfdayng66AJLiMyUdIK/PzmxOMHgVK3iIUYgSKACHv?=
 =?us-ascii?Q?jsR+W2h3j4u+tPC2DhDZrTuQ8RrQxiYKIzNoBSBwnCZ0m2tgGO8Dl9/Fx08y?=
 =?us-ascii?Q?4TPz/+tVmsVGF1nEHmpEb0Rj8oIQZNBkYm2vwfRqRJ4ptJgyyVEH1VVTagUo?=
 =?us-ascii?Q?EgqLH8tGGqtTR1E2nKh3PRJiNk/6Z881RDBWRRtvNNRFX+tgFnmdRTkbbRWy?=
 =?us-ascii?Q?FFDNaKiUnRXoNxdlfnkT/ZaYJZjnSSfng/HiqlkHjjTQ8siR5lpZczlczq8E?=
 =?us-ascii?Q?TLBbElZBsYMEdqPryB54CisAYXVmm6l/QfXplonEe8KMS3tt5phTDowImBxL?=
 =?us-ascii?Q?k1/M50WiazziHnMTegw6CDap+O+IddDrn2f4HB/wZeoTPCfFgdGpRwvkbOre?=
 =?us-ascii?Q?4hDaEj5lEmomhSTDg54dFBEbdORXqnuMwRhOZRMoDCyPlvumpl+6a50pSDPX?=
 =?us-ascii?Q?n+cWP88cN5mWvK4LjBKXT27GO4z1FuAkbqt5YaoNT6iFo39Ln9O6rzuT0PSj?=
 =?us-ascii?Q?Z75snVvmH7gzgzbrFoGv2r0C3gQ37tqiYHkGWopFqodGjjs0CE7so7yoiui7?=
 =?us-ascii?Q?M022mPBA4YQubr+4pJiqTPGXUSpMIGdaKOIrLwhJ84IkZm3nNYseVAv4u0H8?=
 =?us-ascii?Q?BUJfWRFjRr6K8HwW50KMA4Rw1czdNNJrTxfsLJ6kCd6BIVTjQEtYLgcNRVYg?=
 =?us-ascii?Q?3aPpdxGZnWb2iBduc4qQJtsVLpFIgWcLtAbywbEcbbeyXxwv/fwXgQPKOJ/M?=
 =?us-ascii?Q?uYItGz25wRMT7ugV/kdBqAOZgP0/Zuzbv+u8XBa9eAsBMzzlOpqz4j3ddJHC?=
 =?us-ascii?Q?1wG2anliXKjGD5WZkBRhjNtW0nZWpT/Z5UVcd1fAK7Gz4ZAhxRSuszOMqXnZ?=
 =?us-ascii?Q?Fkr6FBCkSgl6h55kul822rKZyKc5aiEnRQprpd9LuaMOxAIKcnL6iK23xwYS?=
 =?us-ascii?Q?uef7L0PYxbxfsefmLszQXDWNH2ZrWZzxcc2fznl0m2p4X4vsNS6K1EUvoLXx?=
 =?us-ascii?Q?EFdlHq7k+pyWGeP16r0FyKk907ezLoDxE63U3wrB47LRarh08g6/eOQ42OC9?=
 =?us-ascii?Q?DYmYdYj50iwYDk/wmw4vLO6XbOEuITF+AevhI19TMsB34vAULuURkFlz5xIJ?=
 =?us-ascii?Q?5jEPfOwxW5+grMJsU7/rUUWABffUEwaTRRTYLpXjiG2CiX8yDjXN0x1PoFww?=
 =?us-ascii?Q?VxixvmrCJ7S0EPTJK8daC5hFkPFa/m46RJ3WmLUnjBHgJb6soxGnfyC1ju4F?=
 =?us-ascii?Q?f/RXgtzHF6UtNMY26nQcBZMQl7vhbhr5VCQmBo/wbAnSp3APXagfn/5444vJ?=
 =?us-ascii?Q?eLUy+bYV/90/lGAElzLLlAdxcv9ZXsLaIOY6x9AIHxk5yhOAw3RNsHVgx25D?=
 =?us-ascii?Q?hQ4lID7iTm8ZA9HubzT61u7d35nHsdYdJeBeAl/pnTJXQsYujNyNXnsV8nZm?=
 =?us-ascii?Q?ybis8A63Fm2d/OwJ8r8MMWjTgQf+004XM57Rz9Z+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR21MB1481.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04cc9c57-0634-40bc-b68f-08dc532dd60a
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 15:59:10.8862
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tx39MD5Sa15a5jZuJs9NSNqLHaYF3H5zhORVWY4sDxXfO8oB6oXCbNOSUek9I1n5wFsxf6BN9KqrkzFNtml6eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR21MB1895


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, April 2, 2024 12:13 AM
> To: Dexuan Cui <decui@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>; linux-hyperv@vger.kernel.org;
> netdev@vger.kernel.org; Wei Hu <weh@microsoft.com>; stephen
> <stephen@networkplumber.org>; KY Srinivasan <kys@microsoft.com>; Paul
> Rosswurm <paulros@microsoft.com>; olaf@aepfle.de; vkuznets@redhat.com;
> davem@davemloft.net; wei.liu@kernel.org; edumazet@google.com;
> pabeni@redhat.com; leon@kernel.org; Long Li <longli@microsoft.com>;
> ssengar@linux.microsoft.com; linux-rdma@vger.kernel.org;
> daniel@iogearbox.net; john.fastabend@gmail.com; bpf@vger.kernel.org;
> ast@kernel.org; sharmaajay@microsoft.com; hawk@kernel.org;
> tglx@linutronix.de; shradhagupta@linux.microsoft.com; linux-
> kernel@vger.kernel.org; stable@vger.kernel.org
> Subject: Re: [PATCH net] net: mana: Fix Rx DMA datasize and
> skb_over_panic
>=20
> On Tue, 2 Apr 2024 01:23:08 +0000 Dexuan Cui wrote:
> > > > I suggest the Fixes tag should be updated. Otherwise the fix
> > > > looks good to me.
> > >
> > > Thanks for the suggestion. I actually thought about this before
> > > submission.
> > > I was worried about someone back ports the jumbo frame feature,
> > > they may not automatically know this patch should be backported
> > > too.
> >
> > The jumbo frame commit (2fbbd712baf1) depends on the MTU
> > commit (2fbbd712baf1), so adding "Fixes: 2fbbd712baf1" (
> > instead of "Fixes: ca9c54d2d6a5") might make it easier for people
> > to notice and pick up this fix.
> >
> > I'm OK if the patch remains as is. Just wanted to make  sure I
> > understand the issue here.
>=20
> Please update the tag to where the bug was actually first exposed.

Thank Dexuan and Jakub for the suggestions. I will update the tag.

- Haiyang