Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2172603lqz; Tue, 2 Apr 2024 09:08:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW2oVKq2uu3It9VSUNWh+i4i3xdxhl5L9Ehz7UfdFg/e4M9xrx93YHrCA5QX0arr78jUruAHxYt2ODhtnAMITza7a6SumwKmrJquNcfJw== X-Google-Smtp-Source: AGHT+IFSV6DEX6N6Wzd8dKjwWdh4KoD9x+/8+Io4xN2xk+ntRGxrDrL4ZiUb2yumZbGxZ9vRuDTu X-Received: by 2002:a17:902:c189:b0:1e0:b2d5:5f46 with SMTP id d9-20020a170902c18900b001e0b2d55f46mr90471pld.46.1712074131740; Tue, 02 Apr 2024 09:08:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712074131; cv=pass; d=google.com; s=arc-20160816; b=uEQxZCcCCkSZ8Vb5ExJYWvv6mtNvlk+0Mqk7FXoptVY0RU/W7HmweWnBFHGo/zFprx L6Ju6dYTtsp3y1RHqfQkBkfKtj90X5pjAt2IIu+xoS7TsPpJzZBxR6b8EJv3X/tYNy1g x8/5MDsfJt9kU++v6mXAH6PibJl9BeQ0EO0bmWkrQk454TMLKiB4acVrTKoa3UYVYJA+ LWb4bvDhKl6kvqbM6JnWqKxs8btHteZumI68OJe9cA29hwJB9i1IZ/SWp5oi4Lp9SBjy 2bC2miDzLo3Nz4y9pmkB4Jk55idBvLotcLf4U/ZwEyRfRJx/+IyQ001rCRVxEqWB0zyZ h/ug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Jr4TICBirmV0AGcpddZ/N3t3gROdjt4DB8W/pPaIj64=; fh=EzudMwWinj1oUMna/8KWTlFuvyyTlK/cNBKUnWMNQrU=; b=ppvSg/BygdpLhzYiU659f1y2JjJkglJFTwDid+GR5YBCMPIS9pzQZP7eOzPwwZ1D3b FzCEPff0iFKfhPwfbDwIBSGCP4xKGloNnw7TloIfMTrmJWYDnQEe1wAf13X6ANeS2212 WWSXDVSkGwQzcJigJpHF6kp1WMqXDmLGsnBDHFlumlmKtPCrkZVSMQ1y0rdCWsWz5FV6 RSiAlvgLP5Z7Ie0vClmt2OTvG3Zzi0RPvCcydOBFuDJkrMX2Gg/5LBibZgcR3oqWaW9E g1uCUSLoAx+0jMJaBHfwmcJCQ7xU+NCEihCznjj41bbTCrZ5CaXUounnVC6t2Axz/6MG +knA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RQLj9Vkq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128314-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128314-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e17-20020a170903241100b001e2866974e9si486619plo.150.2024.04.02.09.08.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 09:08:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128314-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RQLj9Vkq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128314-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128314-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A3DC028994E for ; Tue, 2 Apr 2024 16:05:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 50D19142636; Tue, 2 Apr 2024 16:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RQLj9Vkq" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5572013F44C; Tue, 2 Apr 2024 16:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712073948; cv=none; b=birTFyLJS9Q0EwzztbB8udfFzTpFym7n4CH0pDY5G4+EWxYp7PqBDWS8zmuz7ceVtpRJ4b3uhMZD3Ui0P2Gk0NQIgWxZeLWXhcqv8IYvR6mQY9yWgyq50iSM/vx0ZGFuwBW1OsBcjlaennU/z8Sw5SUvzdMVqq8Bovi/G6LlzJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712073948; c=relaxed/simple; bh=7cOFNsG+sn2clFX8iSG+nyW2cjK90YkAvpcESEHfbyI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XieNO0mBE7zXtfyhRV1UC/aiYw89AwCg/04LJBDfKZaRyTMqxfhKed0wPuAtORoAEEn1kPTmDSZ5fESJsEat6Dbd1agzbtxevoKdCO3E7zAXyZm/8gsIP1x+mHXrG0ToTquTE2Df8EFBmwlN4Knyeyxm3iqGEBEOJYsBJe1UkAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RQLj9Vkq; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 964B1C433C7; Tue, 2 Apr 2024 16:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712073947; bh=7cOFNsG+sn2clFX8iSG+nyW2cjK90YkAvpcESEHfbyI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RQLj9VkqL3Yd4bSTm8AXVoKsGxa3g49q6+f+v62RoIq0pOxCw55n5OU32s1E9xsoM vV16QvE/R1ptCV/dQahrvTwSdkqXDpHHNV6d+mAmEMy0qeZvS21T05jfUYN13kzRgB BdsoSnIMyCdSOndCPyt9lDfujYsAiPcV+FZH/sy/7uoB5gd4MmyrorTPHY8/aH/6VL F7727KkSiANEH2iTd4cWiI/u+EjNQJHLDDoDTnYy3Fh8PQ3nYOLDxgaJH76VILSxyV WmWFh7YAbrZmODjN2Mn/ML259REGCAnDwKZ3Y0TVzigI58N6Q3ZLvhXjcQ4SRZWSiz /TsTw2GOH8ozw== Date: Tue, 2 Apr 2024 11:05:45 -0500 From: Rob Herring To: Satya Priya Kakitapalli Cc: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Dmitry Baryshkov , Ajit Pandey , Imran Shaik , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: clock: qcom: Update SM8150 videocc bindings Message-ID: <20240402160545.GA223060-robh@kernel.org> References: <20240401-videocc-sm8150-dt-node-v2-0-3b87cd2add96@quicinc.com> <20240401-videocc-sm8150-dt-node-v2-1-3b87cd2add96@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240401-videocc-sm8150-dt-node-v2-1-3b87cd2add96@quicinc.com> On Mon, Apr 01, 2024 at 04:44:23PM +0530, Satya Priya Kakitapalli wrote: > Update the clocks list for SM8150 to add both AHB and XO clocks, > as it needs both of them. I read this as you are adding 2 clocks, but it is really just 1 you are adding (iface). This should have more detail on why breaking the ABI is okay here. > > Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings") > Signed-off-by: Satya Priya Kakitapalli > --- > .../devicetree/bindings/clock/qcom,videocc.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > index 6999e36ace1b..68bac801adb0 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > @@ -75,7 +75,6 @@ allOf: > enum: > - qcom,sc7180-videocc > - qcom,sdm845-videocc > - - qcom,sm8150-videocc > then: > properties: > clocks: > @@ -101,6 +100,22 @@ allOf: > - const: bi_tcxo > - const: bi_tcxo_ao > > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm8150-videocc > + then: > + properties: > + clocks: > + items: > + - description: AHB > + - description: Board XO source > + clock-names: > + items: > + - const: iface > + - const: bi_tcxo > + > - if: > properties: > compatible: > > -- > 2.25.1 >