Received-SPF: pass (google.com: domain of linux-kernel+bounces-128337-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 2 Apr 2024 12:15:56 -0400
From: Frank Li <Frank.li@nxp.com>
To: Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, imx@lists.linux.dev
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH v5 0/5] PCI: dwc: Add common pme_turn_off message by
 using outbound iATU
Message-ID: <ZgwvPB/LbPRshVCy@lizhi-Precision-Tower-5810>
References: <20240319-pme_msg-v5-0-af9ffe57f432@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240319-pme_msg-v5-0-af9ffe57f432@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tLpR1Y50JzXDqDOlbiZgdQHBuq19xZlQlXstkoCPhdjZH72B2kAok3cY1qCG?=
 =?us-ascii?Q?qHOMggCmd93sp/zHRw/VYFd48OiX/QCm2e4arU3BK2KICmMILfCi2UsNc5te?=
 =?us-ascii?Q?Wf/Ig1XX581cPdAb/N23aTgoQ/sP+TPmKvdXZHhLYtXtGkw/6M+2HF60VTRc?=
 =?us-ascii?Q?4C3hdkcV9sgLWTHi+iODiGkMU2aAVhfu2QXallCF6vOYFLOh5BxFD0EIc1Uw?=
 =?us-ascii?Q?fSNPRuqV1HefqEHOIek7OP6wCIbRm/8Mo0wUwco7ymX9DhhLZFJ82t5yclYi?=
 =?us-ascii?Q?J0p4887UwMBuMNofx+M+HuneDf2lgnFEvwbkaFC/iS3I8rNzYXyPRDr56S29?=
 =?us-ascii?Q?xO0BtdVXHQ4ZJJDn7YFEUCuayQX9OwXZII3C47Pu+FD+ouTy8XfQAfmlPQX+?=
 =?us-ascii?Q?I8Dfx4IH3p7Bj/B4HRmeUm9kco2aZk+fbzwSOxMdqpXspxLdP0yoAu9v4DhF?=
 =?us-ascii?Q?emodIzekECVi0H8LVuEKAxUToLzdhsrTkdQArjGDmoKTWmx/9pUYcXsUeJ5f?=
 =?us-ascii?Q?s/x4doA+3KmcKOtt+o2G+VWYZ6lm1wT55U02D2/JaBhYvyL3kNwsNGWw/GsG?=
 =?us-ascii?Q?Ivmm68foRjvtbZVcjZzlsGMVq1jxa1BdMzHrvO5J1f5BtxR0PcHA2qkMYYcg?=
 =?us-ascii?Q?Dywv4yCaIG1o2bdKgWYxq7qJvmtqVSFfhc+qbqXrldHbH5rZ5Xmkqvd2A78h?=
 =?us-ascii?Q?dP1ilvoSNKDOxkH34n6CAdANdkGCaM7da0jz/DG3hm8tEgQZBAi25CJDdUL2?=
 =?us-ascii?Q?HEYLHtcijhQfQfXHS0jX3iLZZDKmbOKVEzmYHiQoZ44HiEDGXNbK69YkwLbe?=
 =?us-ascii?Q?ZIXONHE/oKDaMYv5AeoWTca1aACDtNFJILyHIOsU0Q+e1ExPx5jKoUPaPdOp?=
 =?us-ascii?Q?kqPBXNhU1XSyApItj4Ud4qCXBHbqQKKFnmYY60x1f4M2y0zJU2MoGgual7Xp?=
 =?us-ascii?Q?ebJcGXwuClO4a6KBAIe1AWXabzf3jwe/rNQdUcSNW2U+u0qzsva286nUCpkD?=
 =?us-ascii?Q?LzyoAK+PcUnCPBSn+jbrhCa3d6TYTOvh7iOWBowUBd642k9J5Ax53PJaWjev?=
 =?us-ascii?Q?U6Q+01r6FQIMS8mKBOGWlyvQpuRgErEthZVMEZbhD2Mp+OyKzkcgk6LttEO2?=
 =?us-ascii?Q?RzshkYcrpvW9sS9EvhIa71ogL6G4GruHbphQoZVHRuN6EzHdiXzhd1mLQuWa?=
 =?us-ascii?Q?Ao+T0JGB0pw88I/P3O7b5gZeb0DJGjBJ4e412BpbwwShM8gebippw5z2NwYe?=
 =?us-ascii?Q?rxrLSnwv7drKGtopck0L/dZsTf3N4MOVTxUJAhBQ7HfJ3S/0laAnmpgRlbvE?=
 =?us-ascii?Q?cYsJBPWqK5cZj3ZP9xAJ6vkyuO08sGolsKeSs2sapxEpu4GNAfc8HnLji3up?=
 =?us-ascii?Q?J6CCo1LqSVwBGfVzn+mKJMwTZmanz1WQDtlDFDOCETpBGM1xYewFUvJV3Hf5?=
 =?us-ascii?Q?o1GbAvVgCq9UFBJ4XsrDeOWI5I2XLYE+juhsGpx0pa0ZH+0i58KvbYRKBvfp?=
 =?us-ascii?Q?c7ahhJpR7JA4f0yi5TCYTvr3PDdN4Lsf1xcIZfTZTExoyxZyTXZvco81E3tu?=
 =?us-ascii?Q?Dowq7ajaRU23iUeIE6/W890zvgH8W5ggExNcnRa6?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f8d4fee-e2d3-45a5-4b9c-08dc53303203
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 16:16:04.4025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gu9Q0E4Hlp1S/z/aD2I8MIBPscFfbQqTL4Ierhiy0j86pr8Bqvx93q5ChsDTlwBXgNNrObkrpBcvzq4gasKLgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7731

On Tue, Mar 19, 2024 at 12:07:10PM -0400, Frank Li wrote:
> Involve an new and common mathod to send pme_turn_off() message. Previously
> pme_turn_off() implement by platform related special register to trigge    
> it.                                                                        
>                                                                            
> But Yoshihiro give good idea by using iATU to send out message. Previously 
> Yoshihiro provide patches to raise INTx message by dummy write to outbound 
> iATU.                                                                      
>                                                                            
> Use similar mathod to send out pme_turn_off message.                       
>                                                                            
> Previous two patches is picked from Yoshihiro' big patch serialise.        
>  PCI: dwc: Change arguments of dw_pcie_prog_outbound_atu()                 
>  PCI: Add INTx Mechanism Messages macros                                   
>                                                                            
> PCI: Add PME_TURN_OFF message macro                                        
> dt-bindings: PCI: dwc: Add 'msg" register region, Add "msg" region to use  
> to map PCI msg.                                                            
>                                                                            
> PCI: dwc: Add common pme_turn_off message method                           
> Using common pme_turn_off() message if platform have not define their.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Changes in v5:
> - Default disable allocate TLP message memory windows. If driver need use
> this feature, need set use_atu_msg = true before call dw_host_init().


Mani, lorenzo and bjorn

Any comments about these patches? I already set this feature default as
false. It is common for all dwc platform. 

After this merge, imx6 and layerscape many customer PME code can be
removed.

Frank

> 
> - Link to v4: https://lore.kernel.org/r/20240213-pme_msg-v4-0-e2acd4d7a292@nxp.com
> 
> Changes in v4:
> - Remove dt-binding patch. Needn't change any dts file and binding doc.
>   Reserve a region at end of first IORESOURCE_MEM window by call
>   request_resource(). So PCIe stack will not use this reserve region to any
> PCIe devices.
>   I tested it by reserve at begin of IORESOURCE_MEM window. PCIe stack
> will skip it as expection.
> 
>   Fixed a issue, forget set iATU index when sent PME_turn_off.
> 
> - Link to v3: https://lore.kernel.org/r/20240202-pme_msg-v3-0-ff2af57a02ad@nxp.com
> 
> Changes in v3:
> - fix 'MSG"
> - Add pcie spec ref in head file
> - using function name dw_pci_pme_turn_off()
> - Using PCIE_ prefix macro
> - Link to v2: https://lore.kernel.org/r/20240201-pme_msg-v2-0-6767052fe6a4@nxp.com
> 
> Changes in v2:
>   - Add my sign off at PCI: dwc: Add outbound MSG TLPs support
>   - Add Bjorn review tag at  Add INTx Mechanism Messages macros
>   - using PME_Turn_Off match PCIe spec
>   - ref to pcie spec v6.1
>   - using section number.
> 
> - Link to v1: https://lore.kernel.org/r/20240130-pme_msg-v1-0-d52b0add5c7c@nxp.com
> 
> ---
> Frank Li (2):
>       PCI: Add PCIE_MSG_CODE_PME_TURN_OFF message macro
>       PCI: dwc: Add common send PME_Turn_Off message method
> 
> Yoshihiro Shimoda (3):
>       PCI: Add INTx Mechanism Messages macros
>       PCI: dwc: Consolidate args of dw_pcie_prog_outbound_atu() into a structure
>       PCI: dwc: Add outbound MSG TLPs support
> 
>  drivers/pci/controller/dwc/pcie-designware-ep.c   |  21 ++--
>  drivers/pci/controller/dwc/pcie-designware-host.c | 146 +++++++++++++++++++---
>  drivers/pci/controller/dwc/pcie-designware.c      |  54 ++++----
>  drivers/pci/controller/dwc/pcie-designware.h      |  22 +++-
>  drivers/pci/pci.h                                 |  20 +++
>  5 files changed, 199 insertions(+), 64 deletions(-)
> ---
> base-commit: e08fc59eee9991afa467d406d684d46d543299a9
> change-id: 20240130-pme_msg-dd2d81ee9886
> 
> Best regards,
> ---
> Frank Li <Frank.Li@nxp.com>
>