Received-SPF: pass (google.com: domain of linux-kernel+bounces-127767-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 2 Apr 2024 13:47:08 +0300 (EEST)
To: "Luke D. Jones" <luke@ljones.dev>
cc: Hans de Goede <hdegoede@redhat.com>, corentin.chary@gmail.com, 
    platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/9] platform/x86: asus-wmi: support toggling POST
 sound
In-Reply-To: <20240402022607.34625-5-luke@ljones.dev>
Message-ID: <0c8635b9-db16-9125-63bc-7761800e3e96@linux.intel.com>
References: <20240402022607.34625-1-luke@ljones.dev> <20240402022607.34625-5-luke@ljones.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1894852132-1712054828=:1019"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1894852132-1712054828=:1019
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Tue, 2 Apr 2024, Luke D. Jones wrote:

> Add support for toggling the BIOS POST sound on some ASUS laptops.
>=20
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> ---
>  .../ABI/testing/sysfs-platform-asus-wmi       |  9 ++++
>  drivers/platform/x86/asus-wmi.c               | 51 +++++++++++++++++++
>  include/linux/platform_data/x86/asus-wmi.h    |  3 ++
>  3 files changed, 63 insertions(+)
>=20
> diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Document=
ation/ABI/testing/sysfs-platform-asus-wmi
> index ef1ac1a20a71..41b92e53e88a 100644
> --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> @@ -194,3 +194,12 @@ Contact:=09"Luke Jones" <luke@ljones.dev>
>  Description:
>  =09=09Set the target temperature limit of the Nvidia dGPU:
>  =09=09=09* min=3D75, max=3D87
> +
> +What:=09=09/sys/devices/platform/<platform>/boot_sound
> +Date:=09=09Apr 2024
> +KernelVersion:=096.10
> +Contact:=09"Luke Jones" <luke@ljones.dev>
> +Description:
> +=09=09Set if the BIOS POST sound is played on boot.
> +=09=09=09* 0 - False,
> +=09=09=09* 1 - True
> \ No newline at end of file

Add the last newline please.

After fixing that, please add:

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>


--=20
 i.
--8323328-1894852132-1712054828=:1019--