Received: by 2002:a05:7208:3003:b0:81:def:69cd with SMTP id f3csp4191136rba; Tue, 2 Apr 2024 09:46:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXiERqxJHWQ6Hbg4bWW1j6q8QNTMmt1Rf3jPZ3YtuhY+FiroTlGsiyYsB5vXANGls3hbvlzn1rWonbs5HFOARxVNRpcy99DdtR2hyKW1Q== X-Google-Smtp-Source: AGHT+IGs6bFWXZOuQ0WTA9LeVZVFLBG2OQE8CS3gocr8l5XYbLoWnqtVgBqekdBmZVFm1uMz0Jg+ X-Received: by 2002:a17:903:8c8:b0:1e2:2d16:cd6b with SMTP id lk8-20020a17090308c800b001e22d16cd6bmr17051475plb.28.1712076404701; Tue, 02 Apr 2024 09:46:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712076404; cv=pass; d=google.com; s=arc-20160816; b=xNMp1Ed2SK2L++Uv9ALverrxTs5BHGlsl1HU5nhsH/LrL82KTNgH5F8lIxg0s7Vcq1 SPBapOXy65WzLYDZu3RJpMz1jceDpIrDRahf1Y0MIwi+7lGTQNsDVKtE4wZVaKQTEyJf BJzOq4vxWL2VAGelkqiONrW8BnriXXqoBo4cpOZ+YH8AnQBcLEvOfV6cTOTKkyXE8r+H Vdl7/xe0O6XCanrkXaTMIiAxC4+csJRi3znUTckFK2KtgHaazm8m5aRJWqerAK/ejg+K bhBtyk0bqrSNZanQdhUTpzLC1SLq3es+7dQv+D82+JI9baCI57i/WsrygG0u5EOde97j Amig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=IfZ3U3KA3m7+rlF0c1rXbQM13vzumjkY/zbbPelbxk4=; fh=+RP73K3e0IdUnG3tHa0DFXpBuusLjtSXp2td+uYUzX8=; b=QqoWVoZvmZmSn0SN/eEQCWVj9sKaqhvG8KWGIpUNWDQmh7arzoa4liTdb9Hc7YL212 +cxgVEIdfOPRQ2yclW4MfAjhGQMYnUogHI9kZQpUG41D8QTvCpHDKroQTsegM000Fy3p bja5XTpFzP9w5iuTeubp0DeVnqRGhSXMWhbDKmtyXGG7mFfCDx9boe8KKgP6G74YaPAS w/TZf5qXYmj/X3L+XnzfmvwnziFfucYqBUw5mo4O4o69LVZjvOFGmjYD9WA7hNrd1FO3 jj5RJzwK07nVwbdbtP3750phMZK7LLBZgFGMvQ7lrzhI+9Pj0/1rbrPUMXbVeFwBOsas lgNA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=MKfSNfAX; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-128368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128368-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q14-20020a17090311ce00b001e096d44a94si11733686plh.355.2024.04.02.09.46.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 09:46:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=MKfSNfAX; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-128368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128368-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 69AFB282FEE for ; Tue, 2 Apr 2024 16:46:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 097831598FD; Tue, 2 Apr 2024 16:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MKfSNfAX" Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E37615991B; Tue, 2 Apr 2024 16:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712076374; cv=none; b=DHRD8d7Cbia+tLTWwB1maj0EeJDxR3iH9pAdSkhmCWYnHFxybqb+JXgQ0d+7qfV3Jg5+m9sjGVmWqCXcBfie20wGSf/iY5p4iRgn5aajWROOLGOFbv/tBhJISicRyc+G+I6s2+UeDNt+tozysTLUB4SOppJwspNMoUk32KKKC2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712076374; c=relaxed/simple; bh=7kOXS7xyu2N48jimAAbbKaii/CuXqgupeAVBYRS/FAY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KRoZkT2mO2UliDvHWcwikuDazApI/45flC2snHwum4PpJg3sMVRC3oBngDvNpHuQFm/6Sr2D5CEsZrfcV479O85MP0JEQLbwqEK9wZz5vEpzST0bKhgh6TtcaxNBrpaTz0CPxJpTPv9ZbugmlrVg21xTwt1M8BjLX0psKL9qitE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MKfSNfAX; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2d6ff0422a2so74116701fa.2; Tue, 02 Apr 2024 09:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712076370; x=1712681170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IfZ3U3KA3m7+rlF0c1rXbQM13vzumjkY/zbbPelbxk4=; b=MKfSNfAXdk2gWsJJiR+uH8RuG9XiPrD9jpa0/9xSarT7gPyDPaPlJX2oq4hLtpaFpV VUnC7Wv0N6dGw5a0dY4R6Ame97ENlbpF9B+yln1uB7C3P1/gn3f9g6fzYBDlFS4c3E57 OGoBz/HFUflSJKq8exzuI+3XXLcRndnm3y5vbuzcbirKxJi0r5zq/7L59g3Kx7RqtZa1 ga2zRUX+RQwik92+bLTslmmdqlCDnZ5ipGQGFv2FqKgfM0GRGVdCOWgl9KFBr9t+fYxO OmeH3SLndajO62PwouMDuemNyM3tbnwKIpyekV+dCKyXDViijgSI8FW6GavgmyioO9C2 lNxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712076370; x=1712681170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IfZ3U3KA3m7+rlF0c1rXbQM13vzumjkY/zbbPelbxk4=; b=kgb3gNQoyNqG9FnTyerXPa+cZ6Br306LPeqtda5MJXhHPkNSw3lOZzEO0ffsT1gggs Aw4NV0YF6KYmf4gsP2we6pw5sGF6XTJi4mrTuYUdkzt1p5/cwKfKIXHIyry1huM+LX13 /XwH+AdU4xEk6K7DYM9+f4JDEUHUFEnFWulG56iNtoRdZiE3geS/mOEmctptMX8Ht0k3 j5BvVZLOLwFJGQsTMqwPRf8DjOt6mf6t4kiCp49jQ/SA/5Ia1r/XNlvbn8ABXa/V5uSR 3/7UuQeXspFajU/gCeweryRFk+91cpNmNgkUUqmgd5LPG9u8bgeKzD5PGIynBMqahOAZ S7qA== X-Forwarded-Encrypted: i=1; AJvYcCUupJ9nOax1o2aUvxr59AapIPguYlML9ey2ZA1lVgd7B27W6tbjNDva6C0AHJO1A0aCudjoV87FL8ethpHSqbt16Zzku0kxa5ROOhhF X-Gm-Message-State: AOJu0Yz6ilX4U9Tl+UW0hEew8hTvc9rjzPv+spWxcwYcHPJNQnpSFwhH XJLNX4xx9PBeF2TDEfUxmySOYhqnvA1yKpY/SrUE27omAYkPaZR2nTif8oA1mTveSA== X-Received: by 2002:a2e:804a:0:b0:2d2:6193:6d53 with SMTP id p10-20020a2e804a000000b002d261936d53mr8109439ljg.13.1712076369699; Tue, 02 Apr 2024 09:46:09 -0700 (PDT) Received: from localhost ([77.91.78.25]) by smtp.gmail.com with ESMTPSA id l20-20020a2ea314000000b002d2c3bb7525sm1699840lje.134.2024.04.02.09.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 09:46:09 -0700 (PDT) From: Mikhail Rudenko To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sakari Ailus , Laurent Pinchart , Jacopo Mondi , Tommaso Merciai , Christophe JAILLET , Dave Stevenson , Mauro Carvalho Chehab , Mikhail Rudenko Subject: [PATCH v4 02/20] media: i2c: ov4689: Sort register definitions by address Date: Tue, 2 Apr 2024 19:45:33 +0300 Message-ID: <20240402164552.19171-3-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402164552.19171-1-mike.rudenko@gmail.com> References: <20240402164552.19171-1-mike.rudenko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Put register defininitions in the order of increasing register address. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart --- drivers/media/i2c/ov4689.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c index 5a509e908e3c..a6c101044eb3 100644 --- a/drivers/media/i2c/ov4689.c +++ b/drivers/media/i2c/ov4689.c @@ -19,15 +19,15 @@ #include #include -#define CHIP_ID 0x004688 -#define OV4689_REG_CHIP_ID 0x300a - #define OV4689_XVCLK_FREQ 24000000 #define OV4689_REG_CTRL_MODE 0x0100 #define OV4689_MODE_SW_STANDBY 0x0 #define OV4689_MODE_STREAMING BIT(0) +#define OV4689_REG_CHIP_ID 0x300a +#define CHIP_ID 0x004688 + #define OV4689_REG_EXPOSURE 0x3500 #define OV4689_EXPOSURE_MIN 4 #define OV4689_EXPOSURE_STEP 1 @@ -41,12 +41,12 @@ #define OV4689_GAIN_STEP 1 #define OV4689_GAIN_DEFAULT 0x80 +#define OV4689_REG_VTS 0x380e + #define OV4689_REG_TEST_PATTERN 0x5040 #define OV4689_TEST_PATTERN_ENABLE 0x80 #define OV4689_TEST_PATTERN_DISABLE 0x0 -#define OV4689_REG_VTS 0x380e - #define REG_NULL 0xFFFF #define OV4689_REG_VALUE_08BIT 1 -- 2.44.0