Received-SPF: pass (google.com: domain of linux-kernel+bounces-128398-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <29bc2adb-07d5-416d-b357-4cf084b45ed8@amd.com>
Date: Tue, 2 Apr 2024 10:02:57 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net] pds_core: Fix pdsc_check_pci_health function to print
 warning
To: Jakub Kicinski <kuba@kernel.org>, Brett Creeley <brett.creeley@amd.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shannon.nelson@amd.com
References: <20240321063954.18711-1-brett.creeley@amd.com>
 <20240322180251.69167fd1@kernel.org>
Content-Language: en-US
From: Brett Creeley <bcreeley@amd.com>
In-Reply-To: <20240322180251.69167fd1@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dmFOTFd5aG1oa2xjWjlOQUY4c2Y0NTk1NVd3RU1Sc1Y1UVFlOXF4anpuSTdN?=
 =?utf-8?B?bE84U2ZyVlEzUW11Vkh3UkxZVjN4MFluWjdVVi9QcSsxbUdOK24raUpRVmIv?=
 =?utf-8?B?ZUdlMTJBY0poZ1lGV3ZSNCs4MzZyY1V3VlAvNmJoem1LV09UdER6amJtclhX?=
 =?utf-8?B?cm4vTm9oNThyTmlpTUZXNFJyRDRSc2VXb3MrSVFGV3poNzRnWTBOTFhPWnNu?=
 =?utf-8?B?bHFQYkN2N015OStFTEpjenplaU9YK0JZc3VjZmJZRW9taG9OWDhsUEYwSzA0?=
 =?utf-8?B?TEY2Nk00Tmc1Vk14V05xS1NtbWFCUFZtY1RpWDFzaHYwVU5aTXNwZ25tOFRI?=
 =?utf-8?B?UE04Q0ZlR1VhckhvMjJ5Unh4WWwxZUtaN25ST3lTWUpJd0FoVW1RWXR4dWwz?=
 =?utf-8?B?L0hPZ1JBRFhTUm9yd2FSaFFjOW9aWklxQ016OXJrNlJTdnJ3c2tDWXJ5UFJU?=
 =?utf-8?B?M1JKclFlWG5sQmVYSmFoUDBXU1MwRmdsdVZkWXpEUlJFWE5xbGxrL3Ivc0d5?=
 =?utf-8?B?Qm1PY1ErUlFqaUoyc1NUYmdHd1VLWCthSlJIWDh0Q0hzd3U1N0NjOEticEkv?=
 =?utf-8?B?QmVGUmF6YlBnOXRNQ3ZZZkI2dkdvL3dmcWJyN0hOSDJCVmppSGl4cVhPVjJq?=
 =?utf-8?B?a0kzblpHcDlBeGVKTGtHYnRlWFBXWmx1V2JZblB2WkdKSUNBZzZKeXZ1S3FW?=
 =?utf-8?B?RlQ3QkphT3UyU0c5M3VmYUozelRGWDA2d2w5cUt3NXdLSWJZZ1NFL0ZSK0ly?=
 =?utf-8?B?R29wak1jekEveGVQd0VNelNIS0RvbmRNbEdOdncxRWF3eGNvQjVQZnk5c3pj?=
 =?utf-8?B?bzJQVks3TEtWN295dTBJcXlrOTBpZU5vZGRLd2NaYVU3MjQ0UTJGckJlQnV6?=
 =?utf-8?B?enNHNlhlTmZ3UE1ZZXVyVEhoamxzL1dBcTV3Rml2bFREd1M2N3VXVDlDNk1s?=
 =?utf-8?B?S05yNlNDMW52ZFllWEo5dnkrWkNleGxOcHcvNGdQaGwwdWdxM3UvOGQyWXNa?=
 =?utf-8?B?TTFSUXVvL3dkbFhsendqc0M5cUNKVXQzclVFMkdqOUI5SERRcCsxeWZBNm1l?=
 =?utf-8?B?cDc1U1NzdTh6UDMxNEFIei9ObW9iSTVGWWJNWXNDZlBjSk8rNHhiK0Z1S2FU?=
 =?utf-8?B?TktBM0NKeWtRTllHZGozQkpXL2RGQnlVelZ0REdQeFJjaTg4azRFZERRc0Qy?=
 =?utf-8?B?Y1RoM082VzBPZXUvMURjUXBKUG1BN2Q1dzlEZDdRNCtNakxhV0NDL3Rabm14?=
 =?utf-8?B?ejhVWXR0T00xMmpYaFZZR1ZsVFpTWEg1anhOY2kvSTJ5VHl0MWlLWkNjajh2?=
 =?utf-8?B?MndNTjRybVl5VWtOS0d5QVplOEhLWHJlRUVMdHJPaGtzODNZYlNjVCtNd1RK?=
 =?utf-8?B?TTdQY1g0YngrK1R2dzR0eGZ4bCtlNWZ6dEtPYUR6ZDVjdnZXdXl2RzZLODNZ?=
 =?utf-8?B?dWFyR1hHRjNWeFJjc2pGM1B5VmVTTDBBWG9ieGFjU2MzT2c3VC8rL1diWldx?=
 =?utf-8?B?d2ZSanY1OGhRWFF3alRDMlVTS1hOQnBWS2pYM2xMWkFqeUd5TVdsR2hQNzVl?=
 =?utf-8?B?aVhsbVJmMGxucnFaZU1zTjB5RHVjRk9PNFdkanc1SlNSN2J5T1VDZkhNZUF5?=
 =?utf-8?B?dFU3NDlXakxVKy9RRHBGbnVTaDRwMktwaldzNHhoY1ZuRDhrOHcwL3VLNm5w?=
 =?utf-8?B?YkFYM3Y4d25La044YVU4NGtDbGpzSDBFU3NuM1JhWnZ5RXFqMk02bms4UGJx?=
 =?utf-8?B?dHZqUlEzb1Q0V0pSalBhc1I3VDV4eVkrU0ZnblRwZ0J6YXliT3pWK2gyM1Yx?=
 =?utf-8?B?MEwrS1cvb0ZBaTBhY2hsRmViOWpVbWlDWHVyMlpybnhrNjZ0dmxLaUI0UG93?=
 =?utf-8?B?SDlZM21kOW9qeDBVQUJPdk1xWWpqbkpFNVU2bDB1VXA0WEt6K2hNQmhHY0s1?=
 =?utf-8?B?VUYrZXh1ZGNRa1krYTh6U2dQL1dJL0lEN2JwQXhYdmo3STNzOFNBT2c2YWtw?=
 =?utf-8?B?YkM0Nzl5VVlCUUoyb0FwT3ZENy9oaWFQSWEyRkxZNkJMM1RjUEZWd3lzdVkw?=
 =?utf-8?B?aC9YWk9Jd0xUNWxVdVpoN2pDdWNMOVB3Y24zU1FBeERUeXRCQkJhSGVJaUdm?=
 =?utf-8?Q?dD1gdD7tf1Z4+/how9iHyWY62?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 655c31cc-6ec3-4ec5-1d7c-08dc5336c07c
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB7992.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 17:03:00.4366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8sgjALLNVXVu/S9CapOJHWSD4DcQklJueNYMJ3Ug0n8sZ/2kf0ryeekNRSPJ4ooN7mIKDSH23uCY5acGTIaX8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4401

On 3/22/2024 6:02 PM, Jakub Kicinski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Wed, 20 Mar 2024 23:39:54 -0700 Brett Creeley wrote:
>> When the driver notices fw_status == 0xff it tries to perform a PCI
>> reset on itself via pci_reset_function() in the context of the driver's
>> health thread. However, pdsc_reset_prepare calls
>> pdsc_stop_health_thread(), which attempts to stop/flush the health
>> thread. This results in a deadlock because the stop/flush will never
>> complete since the driver called pci_reset_function() from the health
>> thread context. Fix this by changing the pdsc_check_pci_health_function()
>> to print a dev_warn() once every fw_down/fw_up cycle and requiring the
>> user to perform a reset on the device via sysfs's reset interface,
>> reloading the driver, rebinding the device, etc.
> 
> Dunno, to call PCI reset you don't need much device context.
> Perhaps you could allocate a work entry, throw it onto a per-driver
> workqueue, and return. Basically some minimal viable way to
> "asynchronously" call pci_reset_function()?
> You can take a ref on the device so it doesn't disappear.
> And flush that queue on module unload.

Hi Jakub,

Yeah, this is better than my proposed solution. Now that I'm back from 
vacation I will work on a v2.

Thanks for the review,

Brett