Received: by 2002:a05:7208:3003:b0:81:def:69cd with SMTP id f3csp4206079rba; Tue, 2 Apr 2024 10:08:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVsdsGR3AJNlE+f/3WVKiXGG/oTWs1H1GCXdb7HUurP2j1+jqLwO7SBKofLxf2KEt/tjl1P0fFrrRFCyVNNeEHXGqkW+HT4il9UkipfAQ== X-Google-Smtp-Source: AGHT+IEnQfij9iKM2vJ1F1eCu8obRvrDhJUTJZKSPjZTyiQJPiMp9sEiG5AJGztaXtgBgqhIdnmY X-Received: by 2002:ae9:e402:0:b0:78b:ea24:cf66 with SMTP id q2-20020ae9e402000000b0078bea24cf66mr4437038qkc.55.1712077698908; Tue, 02 Apr 2024 10:08:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712077698; cv=pass; d=google.com; s=arc-20160816; b=v6q6jUscy3pj/DjKcHpt9kHOh7JpxguhhDIQCCjRZBFY2q72C3vhvRN49u4eC5kKWZ 8kMkcEVhxX1pfhR8XaB8OYDbwh1oQXVqCS3svfMX58WQo3N44iP5mPzuwgP8Igmhy27M kgUfRC+ErCslKLROsIGYe6apbH7rgMNjZ9by3Q/lFiF3tyrM4CSAlb9B7ojrBIjxq7EW UkTMx26WTukOs246+xDFLWvfMzxqirQE8xLpKCxgRcSO+KQ3wdaNoiURvHJa5VElrmhj wKMerHkpeFc4LT63pd+wHoiSh86MEu81TLedKg46K20SGta9U7O7PJWWMuQBbKBOOuOA uClA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=0M6rIVNmeNWKLEgACO/4h8yeipnsgRz/AkJ1tkmyQzY=; fh=lkpO3AiYG0AYrwVXkdmXC2eYzWs0RX0NVpE7bANU8jY=; b=ON/vecaZLxrtWWrhfy20pCOuEG+w+UDfRCpsE4uvy5CvkCLKWisUjNuH6IyjQXHbpA JaMshXaplvAcUH4F7Ln6J9SVtiCf01KMmQ+711JraHXLkdlNJil4WNECDU3OotER2iAG 68mFXhBJCgtYQnwu4hSx+IbsNOiHPxy39GwID4KkexsBcjHd0sZgqDRxntj4z1cTcSUk PDRuXLbII+SJzUj/KbJbNNQK1l8hfDdwObbPKB6pHh6J5BfY7Sn9Hk9ABZW/L0rASGhr cjm3UjAL2MArmt/wdYV5/s0x7wG7fbJmOppYTNsN+sK8+uoUnqcxV/s0VGHutmWHYDUA hR6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p562LXWq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128404-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id wl26-20020a05620a57da00b0078a5e5386b9si12398209qkn.574.2024.04.02.10.08.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:08:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p562LXWq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128404-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8A6301C2285C for ; Tue, 2 Apr 2024 17:08:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 66FE515A487; Tue, 2 Apr 2024 17:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p562LXWq" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BD9E15990A; Tue, 2 Apr 2024 17:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712077648; cv=none; b=TkxrRaxPlk1cmi9/qH8WaHYhf5USmAvIxFO+oCODTRxTyXI8zu4Y7895h7Npyl5zTiMD/tBW7NWJuf80kvh9/PLkfEDtQ9ZEC8/vgqcZvs0F9iSoLb0peKtH5qPF7sQokhfypA9gLILtWSkGTGkWoD2iDTd59JBXFjxqDiUweO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712077648; c=relaxed/simple; bh=N2mTXtynJzd6hDyCQblGT1NKDEqb1Nqa7bobWw39oGo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gdLtAKfsl/2qEei/yn+U8vtT4RfeXwmwSR3PsSRf0kRXx3uGeDuFjWNAi+vhKoV6eEQlQ3gzSvmgMZ3vRh9eTmjGiq2o3T+dutEiogkSx2KcIJAJE6Y4f1INQ1NeM0j5wXVB+7DaS4C0fx1/aveDhlyIvJmNKMNp4fiV+dhWNSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p562LXWq; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ED93C433F1; Tue, 2 Apr 2024 17:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712077648; bh=N2mTXtynJzd6hDyCQblGT1NKDEqb1Nqa7bobWw39oGo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p562LXWqGCwJ52oQOOMED/b2EvAEZDHuuAQR0R1sLV5mK2tKhQNjyLsKpPCKCXqFy fkyVgMYpyrBCp0ipdutnv3f7ky5N5sNmPRti00JuZpjEDqn/rYnHeqSPaeoMCjZphi 4pCyW5KKF6wmR2+68I8TdjSPxz7oYrKT67mv/LQ1wnTl86UWDLzbTIJUgygAkSxkHv ZQ7f+RQv3eTZzDYtDlZZqFUaap6biCPIfGCg9/MeHx5wITgtUaRKzacRhwYjzORMj5 f1vZPh3rSEyWE1gtW0LPQMg/pUmnk67xMugToHOHB5t8nh+T4f3XFZTymhOJtlTU97 ZJugRBCdGz3pw== Date: Tue, 2 Apr 2024 10:07:26 -0700 From: Jakub Kicinski To: Cc: , , , , , , , , , , , , Subject: Re: [PATCH net-next v1 4/8] net: dsa: microchip: ksz8: Refactor ksz8_r_dyn_mac_table() for readability Message-ID: <20240402100726.0516e762@kernel.org> In-Reply-To: References: <20240402131339.1525330-1-o.rempel@pengutronix.de> <20240402131339.1525330-5-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 2 Apr 2024 15:44:30 +0000 Arun.Ramadoss@microchip.com wrote: > > int rc; > > If rc is initialized with 0, we don't need to assign rc = 0 in the > success path. Not so sure -- it's easier for the compiler to catch uninitialized variables than "accidentally stale" values.