Received-SPF: pass (google.com: domain of linux-kernel+bounces-128399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <6f0d2ccf-243c-4073-a470-21e2f404595a@amd.com>
Date: Tue, 2 Apr 2024 12:06:07 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/sev: Apply RMP table fixups for kexec.
Content-Language: en-US
To: bp@kernel.org, thomas.lendacky@amd.com
Cc: bp@alien8.de, linux-kernel@vger.kernel.org,
 linux-tip-commits@vger.kernel.org, michael.roth@amd.com, x86@kernel.org
References: <2ab14f6f-2690-056b-cf9e-38a12dafd728@amd.com>
 <20240402163412.19325-1-bp@kernel.org>
From: "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <20240402163412.19325-1-bp@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WUtlM0hoL3MxYk5ZRkdEY3pZdnJmK3dvZVkya0U1UmVBdzNON0pVN3RnTWRP?=
 =?utf-8?B?MlZTczJTcU5DUUkvZ0R3OGJCd1YxVGEwaFJia3YwV082Sm5FQ080MjlzSVZV?=
 =?utf-8?B?dVBCTzAwZXRaNncvQ2JVeUZCSlFQbGNkVnJJb0Nna2Y0dHdNRmZkQTVXNU55?=
 =?utf-8?B?anBsVCtRV2NMWHlNSEVwcU1wSUg3MisvRDFYMnJCZzRYc2dqQmdpQlQxYkhW?=
 =?utf-8?B?RXBCdFJEUk91a1d6aWZBa2YzZHN1ZHRLRE56eEZsZy9aejl6SnBGcHpzbS8w?=
 =?utf-8?B?MXBTWEVwRTl1V0hld1ZRMkluaHRmRHIybnVQOXdkc1ZMZ3c4TGFLSCtRT0Y1?=
 =?utf-8?B?Y3VnSXo0VmptT2k5ekQzYnlEWGtqV0hZYjRydXJpWEpzYzJROVAvR3FsTTRm?=
 =?utf-8?B?N29zbWExUUJHU2xDWFhFbkh2a1ZBWjUydFhYc2dya1NUTG10R0dTcW1FOFM5?=
 =?utf-8?B?RXpxeTU3WXYyMXZwdUFYbkE4blo3ZXk2QWI1ZjFNVVVzNEZ0N3ZVRkladmZR?=
 =?utf-8?B?VnhqRWhBVjZnK25vcENGMjlFaTZJNXZLUENQbnBScjJkd2JiYjdpUEZubzRC?=
 =?utf-8?B?RSs4TE56WWhKcmlpQXd6dElJcVVwTnpBenVqdFlVKzErYVp0NW9GT3dwck9Q?=
 =?utf-8?B?cjJnRGNtYWJ2K1prVG9sd0oraU9RUklpVGVDUWdjOTlIb1FhMmxvR1huMHN1?=
 =?utf-8?B?aGxvVVNsUndTVnNkY1B6aVhLd3pSRG5jYnZlSUhOSDY0aHNyeHFkcFVGT3A4?=
 =?utf-8?B?UWgwakVwNUlSUkRldUhuN0RDeVRYWUpXamlsMmk5Tnl0azB2ZkdNV0JPWU1P?=
 =?utf-8?B?QmxhMXVlU016RDJUTEgxYXN1S0xmWElXR1VxSDNud0JadmlBQ1U2WlVPYTdG?=
 =?utf-8?B?V2QrWmNiSmorMVFCZ2d3Y3ZMRnFvaFBJT0Y4NXlmTlVKaW0zM3RYMDhsRDkr?=
 =?utf-8?B?eUprMi9zdjhtdkNBTFN1MDVkcHIrQjNLT01lM3Ryc3RIVUprZmhLOTJUWWVY?=
 =?utf-8?B?SzVQd1lPMlNqYTJIZWp6Nkk1T3VlVEVzY0xxaHlLOWJIODBXdDNkd2g2cXVW?=
 =?utf-8?B?K29FZEFRRDU4Y2Ruck1WSW16ZkhwUU5TTXRKS2VzYmpsc09mUE5KS09lVTNQ?=
 =?utf-8?B?TTJUSVJDaldsaGhQbTU5Z0I3VU94cVRZdUZXNE1jeitLeEE5TXFSdFJIQVlT?=
 =?utf-8?B?b0liVEYydjZyaDFRTXJ4WndjTlR6K1N2dUxESmNaVFp0WWpQVGg1VENzNFVj?=
 =?utf-8?B?VEdOUlozRTcwMDFLM3dvQjZ1ZXdub1dJekVQUStDRUMvRzJZQnU2Ukx5SUg4?=
 =?utf-8?B?OWU2a3I2QUE5c3VBOWkvVFVQWDNLQkNrMnI2SlJKcThaTHVsak5Sb0o4Vjh3?=
 =?utf-8?B?eDRxZURGanhpUkduZ3k0UzdXSk9GeFZITzZOaC9ab1ZsK0ZkL0JodXdmWTJR?=
 =?utf-8?B?UHhzTERYSDViN1BqbW9uMm1LN2FKc0xWOGxjb3hkc0JUZHluSkZDSFdTTHFr?=
 =?utf-8?B?QjBRT3NjTFo3cEV1cEU5RHl1bDVianVOellFdGJEZ2orVmVPR0ZraGRRelg2?=
 =?utf-8?B?eUc0aDZOMHpiQzQwRjNXSnI5eExnOU50Y29DTDlOQlRlc3JyN1R4cENvQjBB?=
 =?utf-8?B?TWFzV1J2cjZwVWdPMExUR3JleDFpbUZRVkxvS3EvdW5JcE9hcVg3UTZRVHBG?=
 =?utf-8?B?b0xiQnBNdkVwTXhHRE1PRVNJT0dieXRPcVRFZ0VVSXZHMXBOZ1pVTGQxYVdu?=
 =?utf-8?B?Y0lIRG9oNjh1VTk2ZnkwUTlQcEtIUXRGMjUwc2NCV0hsZ2pjclY3bVJJSDFH?=
 =?utf-8?B?bHE5emFabVFKM3ROcGJPUWo5c1g1TDdkSFRqeHdjZW1pZ1YzdkVkSERNK0Nr?=
 =?utf-8?B?b3BNaTlMUkRnRjk5RDFYdzUzVE5kY1h6eHVzWEZjdjQ0VjlEQ29xZWJKSzcz?=
 =?utf-8?B?RDRWZWI2SHhYYlp5WGJ6TmFIU3RyaFVEZStiY1ZWMWlNZkQvd1FaN21YdlpW?=
 =?utf-8?B?KzZTSGw5L3VseElURG5UdnhwUE1LbE9VRE1ac3ZZLzhubXM5US9POS94U1Fo?=
 =?utf-8?B?RWM3SjFzRUt6UjQxZ0JXUndCSWdJSHpRdkUzRlFweXNwc01EMDJTOXBTZjls?=
 =?utf-8?Q?A/hRybWCnqwcRvkxzwQOhzN0v?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d6bc42c-fb02-4ab1-8d58-08dc5337310b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 17:06:09.2633
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4K4BuMTI7tn8mYQVHmW5wT5GJhnUZQMrAdBLGc4hmSX5d5W0xaQuXeVAq3Ul/HJIoaigvVuIi6vfaLVUNj++fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8916

On 4/2/2024 11:34 AM, bp@kernel.org wrote:

> From: Borislav Petkov <bp@alien8.de>
>
> On Tue, Apr 02, 2024 at 10:54:50AM -0500, Tom Lendacky wrote:
>> There's no requirement from a hardware/RMP usage perspective that requires a
>> 2MB alignment, so BIOS is not doing anything wrong. The problem occurs
>> because kexec is initially using 2MB mappings that overlap the start and/or
>> end of the RMP which then results in an RMP fault when memory within one of
>> those 2MB mappings, that is not part of the RMP, is referenced.
> Then this explanation is misleading. And that whole bla about alignment
> is nonsense either.
>
>> Additionally, we have BIOSes out there since Milan that don't do this 2MB
>> alignment. And do you really trust that BIOS will do this properly all the
>> time?
> I don't trust the BIOS to do anything properly.
>
> So why isn't the fix for this simply to reserve the space for the RMP
> table to start at 2M page - even if it doesn't - and to cover the last
> chunk *also* with a 2M page and be done with it?

But, it is the BIOS which reserves the space for the RMP table.

And if you mean the reservation in the kernel page tables (directmap) 
then that will not help as kexec uses it's own identity mapped page tables.

>
> Not this silly overriding dance.

This overriding dance is required to fixup all the three kexec tables, 
as there is no interface/API available to do modifications/fixups in all 
the three possible kexec tables.

Thanks, Ashish

> Thx.
>