Received-SPF: pass (google.com: domain of linux-kernel+bounces-128409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <359264a1-e4ef-438c-8f24-32848e131272@amd.com>
Date: Tue, 2 Apr 2024 12:11:03 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/sev: Apply RMP table fixups for kexec.
Content-Language: en-US
From: "Kalra, Ashish" <ashish.kalra@amd.com>
To: bp@kernel.org, thomas.lendacky@amd.com
Cc: bp@alien8.de, linux-kernel@vger.kernel.org,
 linux-tip-commits@vger.kernel.org, michael.roth@amd.com, x86@kernel.org
References: <2ab14f6f-2690-056b-cf9e-38a12dafd728@amd.com>
 <20240402163412.19325-1-bp@kernel.org>
 <6f0d2ccf-243c-4073-a470-21e2f404595a@amd.com>
In-Reply-To: <6f0d2ccf-243c-4073-a470-21e2f404595a@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGMwSXdLY0VaeXNsWDdiWUlSc3Aza09kRGluS1pjSjlkNGVMWjE0bFU3N0VS?=
 =?utf-8?B?ekpDaG01cjlOa3BEU2tia0tuRHhPbGpoSVdMVDkyMGZkWkh3Z082Q2xPRHVH?=
 =?utf-8?B?VVNTaDlRcWhxTFEyZnZXbm5zWjdaczA2RFpNK1lXOGt6T2NDN2xyZDdyOThw?=
 =?utf-8?B?K2hkR3RqazltdmdEbXJGbEFTUk1qOEM1MGZuUkhqckFUaXdkaWwrNk4xWXlW?=
 =?utf-8?B?T1gzUzVuanhNMWdxSWhxb2hhZjRzMzJDWFF4ZkpsdEMrY0dsaWdSQlJKTHZK?=
 =?utf-8?B?V2FOT3AvY1ZoTVE3eXM5OXRCbExLNGxmdlA3dmtpRUpQcnlnUkZYeHd4RUNi?=
 =?utf-8?B?YlZ3N29RaXBVd1U2ZHdFM1ltR2xCejIwWkdYU2Vxb3piM3AxaVN5LzZhR3lr?=
 =?utf-8?B?TFdHeWxQcm1TdVl4SFRCZGVHcFpicnVPY1hQTUNHdWRKSS90K3Y2Sk93dlVm?=
 =?utf-8?B?WU1wVU54ZVRMQVZQaVpYYkt4MlZ6VmkranJFclpvTHlaeWhTODNUZk05aG5B?=
 =?utf-8?B?RXh6YmpLVUk4TERKL2cvSFdQTENXWXlRcUwyRjE3YVJjeXU5QTNrdzJmbjht?=
 =?utf-8?B?M3U5N1l0VERyQ2VvN1VhZkpEakdPeXdSRFM1a0JYamFpL3ZsRXVhZjV3Q013?=
 =?utf-8?B?a2dFb2lyc2VpT0ZCYkdVQi9CcFk0ZThwVEV0aEROSW5RVUY2a0NxdUM0WHBU?=
 =?utf-8?B?LzBSdkYxWmphcFdRa09oQXBWdjFSNnIrMTF0TmFOclJ2N0xqSE1od2h5ZnFS?=
 =?utf-8?B?V2dnZnRYRWhSUmZoVDBtOExwVVM5VmI4ejRjNk1IRlhOVWVnQTIwU21wZE5L?=
 =?utf-8?B?Z0ZiTkV2WnNPYUQxcjNFbGJoaHNmM0lGRkU3Q2xMWkRsN1lhL0N1NEFFN2t4?=
 =?utf-8?B?Vi9TVTFPS1JJeFlpL1RYVXlSdHNpWTZoNnI2Y1NZNExTRFNjcS9BZnZlRlNh?=
 =?utf-8?B?Y0JzQ015OExrbzZJSHhKYUdzZjFjMm9FbUh1SGx6Qnp4SUx6NmNsSWpTYzFh?=
 =?utf-8?B?cWZFK3gvYit3REV0dy96d1N2QXpCai9ZK1dacUFMRG1nMVgySDB5VVF4WWxm?=
 =?utf-8?B?TDVpOXpueW41YzMzQWQzZkluaHp5dGowMFFHOVVhMW9nMk85K2tMK3FjNEl4?=
 =?utf-8?B?cmp5ZTFuSnhqeGtMdCtQYkNhbngxR2ozOW5HQ0k1azdrU3BxYXppY0FkZzBZ?=
 =?utf-8?B?OGtPdGl1TFhZQTUyWW02SkhMSTZQYUlLYjAwVHZaNWRpQmdYQWdVNXowY3l4?=
 =?utf-8?B?L2w3OXVmb3c5KzQ2NHZWZFZ1QzdvRS9sd1JDMjA5NXpOczZ3Tk5vNkRxdkta?=
 =?utf-8?B?S3I4REJQQVYvSCs5MkRpR0tUMFhvaXk2S0M1Q3IwOTZWVzQ3UlBGM2JwVFUx?=
 =?utf-8?B?bjJnZlBLTUM5VmZKNUg4YVB5eFBxcEYvdnpmWkN0ZmJtNE9KczFkSWhGVWtH?=
 =?utf-8?B?RGJqcmE3b1dyWjExN09CQlovcG9ZMjNub1FPK291U2lNYmdTTFlaekxlMnF2?=
 =?utf-8?B?N21xWVU0TWppSWNXamVrbkdPeWFldzlsY1Z3dnRwSCtDcWNnb0g3OUo0QlZn?=
 =?utf-8?B?UEY3anp1RFN2WG5oUzlGaDRneThvbE03b0NyZGtmOEJENVR6WDZkYnc0Z2xh?=
 =?utf-8?B?QlB1RVFSUzBFY3JzQ0pDay80TFhxMzZUbVB0b3ExakV6S0pKd3RKS0tWdUh3?=
 =?utf-8?B?eGlhTmRySFhvRFRZN1krMDZHbTZHT2I3TU9UZnJ1V0p0NkFBYWJrNUh6b2g0?=
 =?utf-8?B?OVJjZjltRlN6TlY5M2tQakk2d0ZaeEsvV1I0RWJUSXd5eGNYTk11L3VKbExZ?=
 =?utf-8?B?TTdRbHVuZVlLT2VOZEVSd2pBQXVhc2ltUmNnR1VWQk1VdmYxWG4xM25SN2Nu?=
 =?utf-8?B?TURTN3FpY3VtQzRZY0FsbmJFQXZoaWF3QW82VXJ0MGVvc1RzOEVvaThwZ2di?=
 =?utf-8?B?bTdzTlhUd1N0Q0J1bnJVMXd3bzRNVVlzOTEyQTcvdGV3Ky9FdUxaMUNLOENH?=
 =?utf-8?B?clVheWwzV0Z3K3RIbzYwMTRxVEtES2FhbEczc1BBMG83K3lwbitYbElyY3A0?=
 =?utf-8?B?TVpybW1PYlJ6KytGZUhIL2tIcVdPaEhPTm5lMEpKV2hOUFFWSE80T1RmR3F2?=
 =?utf-8?Q?dCAU7CgZE8UbebkYvMlNH8cZl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd7a7a0-df9c-43a0-ceb7-08dc5337e1e0
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 17:11:05.8945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kZWBZjZ+mBofhtMkhDXcIOrHwgiYShGUqOq9jzw1iocYz0tx561uw2ETO5DNKg2Say+dmuAYH0Fc4aN9UvZLUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8207


On 4/2/2024 12:06 PM, Kalra, Ashish wrote:
> On 4/2/2024 11:34 AM, bp@kernel.org wrote:
>
>> From: Borislav Petkov <bp@alien8.de>
>>
>> On Tue, Apr 02, 2024 at 10:54:50AM -0500, Tom Lendacky wrote:
>>> There's no requirement from a hardware/RMP usage perspective that 
>>> requires a
>>> 2MB alignment, so BIOS is not doing anything wrong. The problem occurs
>>> because kexec is initially using 2MB mappings that overlap the start 
>>> and/or
>>> end of the RMP which then results in an RMP fault when memory within 
>>> one of
>>> those 2MB mappings, that is not part of the RMP, is referenced.
>> Then this explanation is misleading. And that whole bla about alignment
>> is nonsense either.
>>
>>> Additionally, we have BIOSes out there since Milan that don't do 
>>> this 2MB
>>> alignment. And do you really trust that BIOS will do this properly 
>>> all the
>>> time?
>> I don't trust the BIOS to do anything properly.
>>
>> So why isn't the fix for this simply to reserve the space for the RMP
>> table to start at 2M page - even if it doesn't - and to cover the last
>> chunk *also* with a 2M page and be done with it?
>
> But, it is the BIOS which reserves the space for the RMP table.
>
> And if you mean the reservation in the kernel page tables (directmap) 
> then that will not help as kexec uses it's own identity mapped page 
> tables.
>
>>
>> Not this silly overriding dance.
>
> This overriding dance is required to fixup all the three kexec tables, 
> as there is no interface/API available to do modifications/fixups in 
> all the three possible kexec tables.
>
I meant the three e820 tables out of which two are used for kexec, the 
e820_table_firmware and e820_table_kexec.

Thanks, Ashish

>
>> Thx.
>>