Received-SPF: pass (google.com: domain of linux-kernel+bounces-128453-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240308204957.2007212-1-justin.ernst@hpe.com>
In-Reply-To: <20240308204957.2007212-1-justin.ernst@hpe.com>
From: Len Brown <lenb@kernel.org>
Date: Tue, 2 Apr 2024 13:45:50 -0400
Message-ID: <CAJvTdK=R+XQZ4Vov8iXGiMADShgrwSoDL8-Jqfhii7YruRLDsg@mail.gmail.com>
Subject: Re: [PATCH] tools/power/turbostat: Fix uncore frequency file string
To: Justin Ernst <justin.ernst@hpe.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for the patch, Justin,

Looks like the probe part of this was already fixed in my git tree, so
I lopped off that hunk and kept your 1st hunk.

Let me know if it works, or if I screwed it up.

latest is in this tree:
https://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux.git/

thanks,
-Len

On Fri, Mar 8, 2024 at 3:50=E2=80=AFPM Justin Ernst <justin.ernst@hpe.com> =
wrote:
>
> Running turbostat on a 16 socket HPE Scale-up Compute 3200 (SapphireRapid=
s) fails with:
> turbostat: /sys/devices/system/cpu/intel_uncore_frequency/package_010_die=
_00/current_freq_khz: open failed: No such file or directory
>
> We observe the sysfs uncore frequency directories named:
> ...
> package_09_die_00/
> package_10_die_00/
> package_11_die_00/
> ...
> package_15_die_00/
>
> The culprit is an incorrect sprintf format string "package_0%d_die_0%d" u=
sed
> with each instance of reading uncore frequency files. uncore-frequency-co=
mmon.c
> creates the sysfs directory with the format "package_%02d_die_%02d". Once=
 the
> package value reaches double digits, the formats diverge.
>
> Change each instance of "package_0%d_die_0%d" to "package_%02d_die_%02d".
>
> Signed-off-by: Justin Ernst <justin.ernst@hpe.com>
> ---
>  tools/power/x86/turbostat/turbostat.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turb=
ostat/turbostat.c
> index 7a334377f92b..2a15a23cb726 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -2599,7 +2599,7 @@ unsigned long long get_uncore_mhz(int package, int =
die)
>  {
>         char path[128];
>
> -       sprintf(path, "/sys/devices/system/cpu/intel_uncore_frequency/pac=
kage_0%d_die_0%d/current_freq_khz", package,
> +       sprintf(path, "/sys/devices/system/cpu/intel_uncore_frequency/pac=
kage_%02d_die_%02d/current_freq_khz", package,
>                 die);
>
>         return (snapshot_sysfs_counter(path) / 1000);
> @@ -4589,20 +4589,20 @@ static void probe_intel_uncore_frequency(void)
>                 for (j =3D 0; j < topo.num_die; ++j) {
>                         int k, l;
>
> -                       sprintf(path, "/sys/devices/system/cpu/intel_unco=
re_frequency/package_0%d_die_0%d/min_freq_khz",
> +                       sprintf(path, "/sys/devices/system/cpu/intel_unco=
re_frequency/package_%02d_die_%02d/min_freq_khz",
>                                 i, j);
>                         k =3D read_sysfs_int(path);
> -                       sprintf(path, "/sys/devices/system/cpu/intel_unco=
re_frequency/package_0%d_die_0%d/max_freq_khz",
> +                       sprintf(path, "/sys/devices/system/cpu/intel_unco=
re_frequency/package_%02d_die_%02d/max_freq_khz",
>                                 i, j);
>                         l =3D read_sysfs_int(path);
>                         fprintf(outf, "Uncore Frequency pkg%d die%d: %d -=
 %d MHz ", i, j, k / 1000, l / 1000);
>
>                         sprintf(path,
> -                               "/sys/devices/system/cpu/intel_uncore_fre=
quency/package_0%d_die_0%d/initial_min_freq_khz",
> +                               "/sys/devices/system/cpu/intel_uncore_fre=
quency/package_%02d_die_%02d/initial_min_freq_khz",
>                                 i, j);
>                         k =3D read_sysfs_int(path);
>                         sprintf(path,
> -                               "/sys/devices/system/cpu/intel_uncore_fre=
quency/package_0%d_die_0%d/initial_max_freq_khz",
> +                               "/sys/devices/system/cpu/intel_uncore_fre=
quency/package_%02d_die_%02d/initial_max_freq_khz",
>                                 i, j);
>                         l =3D read_sysfs_int(path);
>                         fprintf(outf, "(%d - %d MHz)\n", k / 1000, l / 10=
00);
> --
> 2.26.2
>


--=20
Len Brown, Intel