DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=YmPWS1WC9BThzMZF4LBzvm++VIK5Ujr2rKGFYT2623+5PbEVauZZI3GhGCqewbyOCLnelirhUjb8+3tRZr/PTwUYmjaQNKHAqwHPHIcbq3vy7AeGy7kIr4RIJuUhAIuaI/xmkYpN/XAS+z6CS3nv8RbBgGP8aIl09jZsu21uI1E=
Message-ID: <bc64b4640801191418m6b8197c8l498e181d267bb200@mail.gmail.com>
Date: Sun, 20 Jan 2008 01:18:40 +0300
From: Dmitry <dbaryshkov@gmail.com>
To: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
       liam.girdwood@wolfsonmicro.com
Subject: Re: [PATCH] Core driver for WM97xx touchscreens
In-Reply-To: <20080119215506.GA7400@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080118162627.GA28974@rakim.wolfsonmicro.main>
	 <1200673631-366-1-git-send-email-broonie@opensource.wolfsonmicro.com>
	 <20080118120148.ZZRA012@mailhub.coreip.homeip.net>
	 <fmqq50$te0$1@ger.gmane.org> <20080119170030.GA469@sirena.org.uk>
	 <bc64b4640801191148m39ae5cd6ra190ac8e9c40fba7@mail.gmail.com>
	 <20080119215506.GA7400@sirena.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1762
Lines: 46

Hi,

2008/1/20, Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Sat, Jan 19, 2008 at 10:48:32PM +0300, Dmitry wrote:
>
> > Well... It's a common suggestion not to duplicate code. The wm97xx bus
> > looks mostly like platform. The only difference is the name. To help
> > visualisation, devices can have parents. Just set (in pseudocode)
> > wm97xx-touchscreen->parent to wm97xx, do the same for wm97xx-battery
> > and so on. Thus all devices would be on the platform device but with
> > proper parent <-> child notation.
>
> That's exactly what I had understood you to mean.  I guess it's just
> that using the platform bus for this purpose feels like an abstraction
> violation to me due to having platform devices parented off a device on
> another bus.  Obviously it's just my model of a platform device that's
> wrong here.  I will change the driver to use the platform bus for my
> next submission.

Hmm. I forgot about rooting this onto ac97 bus. But I would still suggest
using platform bus just for the sake of code clarity and simplicity.

>
> > git://git.mnementh.co.uk/linux-2.6-im.git#tmio_dev_try3. Look for
>
> Thanks, I'll take a look.
>
> > 2008/1/19, Mark Brown <broonie@opensource.wolfsonmicro.com>:
>
> > > current patch series these chips all also provide an audio codec which
> > > requires a reasonably substantial driver for full support.
>
> > This would only touch child devices organisation.
>
> Indeed - I mention it mostly for additional motivation.
>


-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/