Received-SPF: pass (google.com: domain of linux-kernel+bounces-128473-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 2 Apr 2024 12:59:53 -0500
From: Andrew Halaney <ahalaney@redhat.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>, 
	Konrad Dybcio <konrad.dybcio@linaro.org>, Neil Armstrong <neil.armstrong@linaro.org>, 
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] soc: qcom: pmic_glink: notify clients about the
 current state
Message-ID: <2bj6m72cnuuscp4me6zwygehyf6fo7b72q5f5pkp7d4c4uwdmu@6arpnxh6wsw2>
References: <20240402-pmic-glink-fix-clients-v1-0-885440b81c65@linaro.org>
 <20240402-pmic-glink-fix-clients-v1-2-885440b81c65@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240402-pmic-glink-fix-clients-v1-2-885440b81c65@linaro.org>

On Tue, Apr 02, 2024 at 08:07:07PM +0300, Dmitry Baryshkov wrote:
> In case the client is registered after the pmic-glink recived a response
> from the Protection Domain mapper, it is going to miss the notification
> about the state. Notify clients about the current state upon
> registration.
> 
> Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver")

This looks and sounds reasonable to me.

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  drivers/soc/qcom/pmic_glink.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c
> index c999358771b3..089cdfb1c9d1 100644
> --- a/drivers/soc/qcom/pmic_glink.c
> +++ b/drivers/soc/qcom/pmic_glink.c
> @@ -83,9 +83,14 @@ struct pmic_glink_client *devm_pmic_glink_register_client(struct device *dev,
>  	client->pdr_notify = pdr;
>  	client->priv = priv;
>  
> +	mutex_lock(&pg->state_lock);
>  	mutex_lock(&pg->client_lock);
> +
>  	list_add(&client->node, &pg->clients);
> +	client->pdr_notify(client->priv, pg->client_state);
> +
>  	mutex_unlock(&pg->client_lock);
> +	mutex_unlock(&pg->state_lock);
>  
>  	devres_add(dev, client);
>  
> 
> -- 
> 2.39.2
> 
>