Received-SPF: pass (google.com: domain of linux-kernel+bounces-128491-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a268f388-8a2c-c192-02ca-134c057086e2@quicinc.com>
Date: Tue, 2 Apr 2024 23:46:29 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH 3/7] clk: qcom: Add DISPCC driver support for SM4450
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd
	<sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Vinod Koul <vkoul@kernel.org>,
        Vladimir Zapolskiy
	<vladimir.zapolskiy@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Taniya Das
	<quic_tdas@quicinc.com>,
        Jagadeesh Kona <quic_jkona@quicinc.com>,
        Imran Shaik
	<quic_imrashai@quicinc.com>,
        Satya Priya Kakitapalli
	<quic_skakitap@quicinc.com>
References: <20240330182817.3272224-1-quic_ajipan@quicinc.com>
 <20240330182817.3272224-4-quic_ajipan@quicinc.com>
 <CAA8EJpqZjysw+YE=vKguearf_abSzocvYtMvW9eHAZD-tMKs0g@mail.gmail.com>
Content-Language: en-US
From: Ajit Pandey <quic_ajipan@quicinc.com>
In-Reply-To: <CAA8EJpqZjysw+YE=vKguearf_abSzocvYtMvW9eHAZD-tMKs0g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/31/2024 6:58 AM, Dmitry Baryshkov wrote:
> On Sat, 30 Mar 2024 at 20:29, Ajit Pandey <quic_ajipan@quicinc.com> wrote:
>>
>> Add Display Clock Controller (DISPCC) support for SM4450 platform.
>>
>> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
>> ---
>>   drivers/clk/qcom/Kconfig         |  10 +
>>   drivers/clk/qcom/Makefile        |   1 +
>>   drivers/clk/qcom/dispcc-sm4450.c | 781 +++++++++++++++++++++++++++++++
>>   3 files changed, 792 insertions(+)
>>   create mode 100644 drivers/clk/qcom/dispcc-sm4450.c
>>
> 
> [skipped]
> 
>> +static int disp_cc_sm4450_probe(struct platform_device *pdev)
>> +{
>> +       struct regmap *regmap;
> 
> Is there a MMCX power domain on the platform? See how other dispcc
> drivers handle pm_runtime status.
> 
Thanks for review , actually SM4450 doesn't support MMCX power domain 
pm_rumtime support is not required here.
>> +
>> +       regmap = qcom_cc_map(pdev, &disp_cc_sm4450_desc);
>> +       if (IS_ERR(regmap))
>> +               return PTR_ERR(regmap);
>> +
>> +       clk_lucid_evo_pll_configure(&disp_cc_pll0, regmap, &disp_cc_pll0_config);
>> +       clk_lucid_evo_pll_configure(&disp_cc_pll1, regmap, &disp_cc_pll1_config);
>> +
>> +       /* Keep some clocks always enabled */
>> +       qcom_branch_set_clk_en(regmap, 0xe070); /* DISP_CC_SLEEP_CLK */
>> +       qcom_branch_set_clk_en(regmap, 0xe054); /* DISP_CC_XO_CLK */
>> +
>> +       return qcom_cc_really_probe(pdev, &disp_cc_sm4450_desc, regmap);
>> +}
>> +
>> +static struct platform_driver disp_cc_sm4450_driver = {
>> +       .probe = disp_cc_sm4450_probe,
>> +       .driver = {
>> +               .name = "dispcc-sm4450",
>> +               .of_match_table = disp_cc_sm4450_match_table,
>> +       },
>> +};
>> +
>> +module_platform_driver(disp_cc_sm4450_driver);
>> +
>> +MODULE_DESCRIPTION("QTI DISPCC SM4450 Driver");
>> +MODULE_LICENSE("GPL");
>> --
>> 2.25.1
>>
>>
> 
> 

-- 
Thanks, and Regards
Ajit