Received-SPF: pass (google.com: domain of linux-kernel+bounces-128513-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <37321af9-aee4-4ba6-81ac-0df4cef38644@amd.com>
Date: Tue, 2 Apr 2024 13:41:05 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/sev: Apply RMP table fixups for kexec.
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: bp@kernel.org, thomas.lendacky@amd.com, linux-kernel@vger.kernel.org,
 linux-tip-commits@vger.kernel.org, michael.roth@amd.com, x86@kernel.org
References: <2ab14f6f-2690-056b-cf9e-38a12dafd728@amd.com>
 <20240402163412.19325-1-bp@kernel.org>
 <6f0d2ccf-243c-4073-a470-21e2f404595a@amd.com>
 <359264a1-e4ef-438c-8f24-32848e131272@amd.com>
 <20240402174540.GAZgxERNxsRJUCb1yp@fat_crate.local>
From: "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <20240402174540.GAZgxERNxsRJUCb1yp@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VlU2RGpDUzN5MTBEOVo2VmpuaURvc1VIeXZpYTRuRU1VZFhQaW9SVW9wS2ho?=
 =?utf-8?B?OUFWSHFVWTQvNmRVQlZrMXY5TlZxUnMzYmk0QXcwUEtYS2VRdXJQNXpXWVpC?=
 =?utf-8?B?N0l1NVAzcklqaHE4L0hjR1JaVUNjNC9JdUc0YmRzdUwrU2p1TWRCaEtlVWpP?=
 =?utf-8?B?dDE4aFlYblFkeHhVVG5FbkoycnRpUUU2eHFkd0t4UGhLd2tHK3hLMUdGTmVm?=
 =?utf-8?B?MlBWTFhsYmd6d1hsLzNkaUd4alZZUEROUys1WFVxSXRBbC93dDl1akhlZmNE?=
 =?utf-8?B?WnV6M1g3U1Z5a0krRk1ZSGJDUFZJTWRJaXhQVUtNbVFja21JUjZPTVJmbDdO?=
 =?utf-8?B?SktseVNmcGJKWjhrZkV4YW5jblErZW0vK1duMERuaHhDcUdrRXk2MXlqRzgw?=
 =?utf-8?B?OGlEcG94UDNZTjVpeHc4TEVROEx6eDZkeWs2SmhMbXVsa0hvMzRNWFRMNUxF?=
 =?utf-8?B?aG5QREJHdmFHNnoxWmNtZzRIcFd0V21xVlE0VStqd2VEcDNRSDUxaitNUGVz?=
 =?utf-8?B?a3lmell4Y1JIQ0g0RzFIMHk2YkxJT1ZucWU2bTBMNjdtKzJ3aTZYQ2xzT3Rk?=
 =?utf-8?B?RGozc0ZZRmZDMWVDWGNiNjFUK0ljbTFnMjNnUmpWeXlLU2g2Mi9EZFY4QUlF?=
 =?utf-8?B?cVNoTFh5ejFVQVhoek1tRTRORTVCSmhBNm83dXg2dTJGZkk3VGVvTEhieS9l?=
 =?utf-8?B?L0pkS2N0aFlESUs0QU9YSGRJa1BXSjBOdURXR3lsL0Jtb1lzRVVOTzM5ZFkx?=
 =?utf-8?B?NkZtTGpwSE8wZ0tEYXVORTZMK1U5MForZUR3dU93S2FUZ0l2dzIzRnNOMllT?=
 =?utf-8?B?UFpxaW41RmFjcDZQdDlSRWZLeUI5STdpam9MS3V0RHhEWUV4RmVYVEdvM2R0?=
 =?utf-8?B?RUVxM1F4Ry8wZFpUWTRNNWVxaDIvVFdTRldPN3pPZzl6TFRObzFqQVhVYTVv?=
 =?utf-8?B?dkROaDN6bEdFUHUzRmt4UjEydlN0ZW55eXptQThsOENPYW1sdGg5cnplTzk3?=
 =?utf-8?B?MFVNVkxSQkNjMGoyM1R1a1ZTeWQzcDd4bVA3TysyRkk4dHVmVXg4b1h4Vndx?=
 =?utf-8?B?U0FSNy9pdVlkQWdRZjRQbHdIb1RlMzdSRnRZbG5PSklqZDE3VDhHZ1R1Zk0z?=
 =?utf-8?B?cmpaS2RVenY2YzVRK2hicEUzS1krVDVkMlRWeE5oTUpQS0xpTXc3YkZuSmNU?=
 =?utf-8?B?TjN5d3dDWDJSRHV5NjBxV2U2QmNXUmFETmJ2Q2hzZ2lvR2s3VjRUSFh3YmRY?=
 =?utf-8?B?eC9QdnA2ZFZzZWt2amcwbzg4cmpHYTV5enJBenphYmJZS0x4S0lYaE5KMEtC?=
 =?utf-8?B?ZHN2LzkwVTZNYzV4TEZGR2lhV3pWdDRaTVNYSFJsZ3cxeUZQUzRjRDFTTEpW?=
 =?utf-8?B?dk9meldINlNiNEpqMTZkejVLaThLUEI2SEVuSThHblJuelVQQ1ZmNHVabVFP?=
 =?utf-8?B?TXBwZkY4bHh0MVZOOU9zQ21LRXdRUDhjRStORWJTeHNqZXNXZXIyTGNEc3dY?=
 =?utf-8?B?VmxyZ0Qzb3RPRHpYOThKSFBLQW9lQ0Y1WXdpR2xaUUtRRlBTbEQxVVhjZmZW?=
 =?utf-8?B?b2ZzTVYwYzJkOWNFYzViODIxemlMM3czUWFyS1FxaEY3M1hpV3VGWGdBSHV3?=
 =?utf-8?B?UzUwQzRXZGQ2dGFYQWFaR2pzdW9wNVJOb0Rmd2wyam1kNVBaU2loclQvaDdE?=
 =?utf-8?B?b2w0bWpydEYvOVQyOFEwZVN0ZGIzQUIvSktEdnV2dE90Nnd3RXkzdXl1S3NZ?=
 =?utf-8?B?UG9VdmdLdnp0M1YxUlFxZkx6L3hCMWZuTStYSVB1UFNEZE1GSFhIVVg3bHV3?=
 =?utf-8?B?akg2OE1rd0hHT21jVzNsc3B0VTNkOGJ2VTYzUkdmRnRRejdZSU1HMkprdEJ5?=
 =?utf-8?B?OGp4QVNIdjlPeHZ4NmQvM2RSTFhTM0VnOXFUYzB4cldyelFwbExwdDNmdHg2?=
 =?utf-8?B?cHRJdnpUbi9TNU5oUWhVVEFxM01DVjlaelA3eWZPZm00WHFrN2RxY3hjRkZz?=
 =?utf-8?B?WmE1S0k2QTh4MUo1Y2lYTlQ0cEVDcGlRZ2ErMVAvVm1Gc2pVMkx0Y2dPb0g5?=
 =?utf-8?B?ZlVIenNqTjlPQU1pRVJOZm9iWjNPWXdDUS9DS1pobzE2ZmtIbjlmUDAvUmIw?=
 =?utf-8?Q?xpFv+QgL0ZifhbpIQ+I4caLAX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0252f511-9b8c-4138-1f3a-08dc534475d3
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 18:41:08.0621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qmr0wzRC7mZ7RsfT5D8A7Tii7ig6mk1matF9pNdu9J4anZ0mFrfISx9tI/cHDnI4EBLMgsNV2pz4Nw0GV82R7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6071


On 4/2/2024 12:45 PM, Borislav Petkov wrote:

> On Tue, Apr 02, 2024 at 12:11:03PM -0500, Kalra, Ashish wrote:
>>> And if you mean the reservation in the kernel page tables (directmap)
>>> then that will not help as kexec uses it's own identity mapped page
>>> tables.
> So how hard would it be to *always* reserve the chunk of memory at the
> 2M boundary where the RMP table starts and up to the 2M boundary where
> the RMP  table ends?
>
> In *every* kernel.

But, that's what the e820 table fixup is doing, it is reserving the 
chunk of memory at the 2M boundary where the RMP table starts and ends 
in the e820. Kexec is referring to the e820 table(s) for placing it's 
segments in memory for the kexec boot.

Thanks, Ashish

>
> By default.
>
> Thx.
>