Received: by 2002:a05:7208:3003:b0:81:def:69cd with SMTP id f3csp4269351rba; Tue, 2 Apr 2024 11:54:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWRE0wgeXMLRFyUrLbyuVY8k4CxSxc+nhaqd5iRw3VdiD89V0kLq3orWjOlWVzV/eYvDYRx6p9rOLXrGgzYt9p9tyBnVn8733cO2VNarA== X-Google-Smtp-Source: AGHT+IF6ZxYSAyB02lIttwIfQvQKLLuvCvcJP1WJMltOhBXgHlCE7YZXNp/8Y/aJcXrTGjartXsC X-Received: by 2002:a05:6a00:2e2a:b0:6ea:e2fd:6100 with SMTP id fc42-20020a056a002e2a00b006eae2fd6100mr14168671pfb.30.1712084040128; Tue, 02 Apr 2024 11:54:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712084040; cv=pass; d=google.com; s=arc-20160816; b=AscYHD7Lt3CeozJ4p0eGh8y6KuDmd8xP3hP33WbTe9s5fDk5dufV2ZkmVpguXvW/NA UuTW8kkSYvFwn8xZoQhRjJ4UTZAJ6zJj/XanIhiUHgIKDbEuK3e4bhX1NE0Mj7TPfiGM qfPJJLT4cMuCj0PSVIoCwDdVwCBoq2QQ2gNwA4FZycPrWYw6SXlHKmocKbnsnhtdGe7V aHKsl7ldQH0BoL7+NUvUhy0tXXxeE4c4DgWJdJtqmubBXBAnD7QsNlgophG2P1zN01/x JhuQt0qJFKyaZuTCyNXZEL81dpfjwJzhNXmaupcPh/qxJdTaPxz3O5Y3QNrHx4i8PPo6 LrZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=bXmjFZ75IuGQzJEr3GrHKDI7T5XAobh0xzx+9kJXJbk=; fh=FmcY7oDfIa4h9nEUf2SigcnXWgQk7/QZKVndLUq3KPo=; b=TqTx01fNhVMYIEOaza4NIg27ojf+H2ePwqY9kosnp+g0QvcaG6N5pKZ0Shz0jMoW9m uWpa0cLqLOPQt9ANRvXGrrICopK/o9oCZsIrLloQ8bXwDkzd6hPOQemon3BOK3A0zYLg OQ7646pvZeQrrpGsQCASnMYTpgtZw374NcCebD7Zt0vgToUZcw6wsFT7JLisC2TFBSfP 4I6i9ITzj24TJLpZT6aUTrM5qna/SH+Kw3A/1hQFy0XnnsncQgr5wLiYg0NUFSUtKeKV 57UcycX0tm10SFQtz2WlXpY/Qckw7MPWQK4Q+G+oNTI4reho6hyc6Avcpc5GNZKgDZXi xstQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=S0kqj66T; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-128194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128194-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jc2-20020a056a006c8200b006ecb8e34b77si3792277pfb.313.2024.04.02.11.53.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 11:54:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=S0kqj66T; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-128194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128194-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F11C52838EC for ; Tue, 2 Apr 2024 14:49:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 24B86133293; Tue, 2 Apr 2024 14:45:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S0kqj66T" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99A35132464; Tue, 2 Apr 2024 14:45:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712069134; cv=none; b=cS/TMeohMzFaSWU9b/O6wcl8jLchYfChZM2irCHDvSixxJ3q/n6M/ABhDo4Vasvsb/C1N7y5hTSqSZvb8SKo8wwyp+EIICE/gZHNLgX/Z041cMp0GhTeq4m3GwXXkRS4+9rOsz2sQ72+a3oJk4EmHqOnfRcWPHEkSZ/n4/ucS2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712069134; c=relaxed/simple; bh=U8zDJrGwvowmpbloCTeIyqdQQakbZMEd/jFHCNTTLss=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WX3xxzl9d2Fset36uElg/McBY1R/mZJ+WTv3DNxfpCKJ5yp2Kh24BPrER8IAeIHYGOffXQHBBTOwXuAO0d+ggxu0t5uKCSVlW/F3XEXsxl2+NFzm68E4YQt4pU1is3oC52Dk9zQTRsB1TgrWO+/xN6LKBazYTI1UBSAuQg+1F6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S0kqj66T; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712069132; x=1743605132; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=U8zDJrGwvowmpbloCTeIyqdQQakbZMEd/jFHCNTTLss=; b=S0kqj66TeD1781/tm/7XMBx0BXWIeEPs7X5JdCJ/LV/2KCgrCSdXZsDn 01W6kNUV74jaU2t52/oFCrm+CDsLKIGsRuDMXxKvhROb4MuVuxec4o4iV Rxxo6p6g409WaoOeca5vpDJdhXMjxt/+pFenoW8C7MhYPBY+YCrKBJwKn DK9ISR/6FIgFTKwvd5ltnE+GlmS3jjRfpv6SiXxmGtL4npMFx6y4x/7iy b66+Po1E1Q27vBnONZnEWY+fMv9eomZ2dHTH8+dgQ+0Lj2VGkuVL2HbOW ryhALfBc1ZfxHmrGax4Q0w4JdVtRticZl/xzQyGKdWLaOzjJVnELmj/G3 A==; X-CSE-ConnectionGUID: QE11SRfWT2SN+1+kTMkQPQ== X-CSE-MsgGUID: nAy9J8YQTTCLK+gYGDkhKQ== X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="24735380" X-IronPort-AV: E=Sophos;i="6.07,175,1708416000"; d="scan'208";a="24735380" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2024 07:45:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="937083583" X-IronPort-AV: E=Sophos;i="6.07,175,1708416000"; d="scan'208";a="937083583" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 02 Apr 2024 07:45:28 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id D756E1C5; Tue, 2 Apr 2024 17:45:27 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown Subject: [PATCH v1 1/1] spi: pxa2xx: Call pxa_ssp_free() after getting the SSP type Date: Tue, 2 Apr 2024 17:45:23 +0300 Message-ID: <20240402144523.3402063-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit pxa_ssp_request() implies a reference counting, hence the pxa_ssp_free() must be called when we are done. Add missed call. Fixes: bb77c99ee6d3 ("spi: pxa2xx: Skip SSP initialization if it's done elsewhere") Signed-off-by: Andy Shevchenko --- drivers/spi/spi-pxa2xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 86d0f1064a45..1348249f8178 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1379,8 +1379,10 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) type = (enum pxa_ssp_type)value; } else { ssp = pxa_ssp_request(pdev->id, pdev->name); - if (ssp) + if (ssp) { type = ssp->type; + pxa_ssp_free(ssp); + } } /* Validate the SSP type correctness */ -- 2.43.0.rc1.1.gbec44491f096