Received-SPF: pass (google.com: domain of linux-kernel+bounces-128542-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.81 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.81; helo=repost-eu.tmcas.trendmicro.com; pr=C
Message-ID: <87ef3f80-77aa-4833-b74e-a2e950bac442@seco.com>
Date: Tue, 2 Apr 2024 15:06:52 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] net: fman: Remove some unused fields in some
 structure
Content-Language: en-US
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 Madalin Bucur <madalin.bucur@nxp.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
 netdev@vger.kernel.org
References: <425222d4f6c584e8316ccb7b2ef415a85c96e455.1712084103.git.christophe.jaillet@wanadoo.fr>
From: Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <425222d4f6c584e8316ccb7b2ef415a85c96e455.1712084103.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 Pafn6gjJNxIoxh6Z5e3+vy94DNUy7pxmQ17bMlquz1BQnlx0/4hzsdrVetH8KbpJ2jTXR8IlTvn/B1S5F7hc7BHIMFiFE7g+Sx9/hu9VGMMtEXzp24MSJcbw85Ag9O22pUfxKom9xG1PZF73muNZukKJ8CStrvkFrevWLOz2MmJAWXT1GtRgpoi2wxB0H917y2zxEr1g2lDQetGHaQgO9I8Ak3N2K0L7CKaXa3+IOT7NxXeDiI/G7DJ9TyPZ6TsDijyL5gp6cK121vZQsI36MaKY7UNvwCNhuk864ncr4Yap4MDN0p7IKfaqz/dJ+ZV/2WNCd6F4+8rEbIenSzOfMuo6CnxZ/fVezycvW3jWGDW+lWXVP5EuqrX+DGCWSEET83+Er3D0B93Ki3e107WBdiuDwsqwpXYMAj/EMRGT32hJQST7yumOovUHVJ+KHoVMrWzEDKwgO/HQJF1J3rLXFv6bBH+u1qUFZ69zEq5WbxcnqIciZi1hCK15Zk92HNqRk4+vzsmbyhXd+ctuK6c8HMIA0Iudz1GE+v4fDNfnwU83Kf+N9h6X6y7p4yeGF0pLiAZbzKGJU8lP2R14lYisJKbhFAc6k/TxmlYSvuUUWwnpfXR+y5jPoDZjuAf6aNJ45dpkWYd7UdAKsz0ss+c04IWOwx1JArKnYF7lEB33+rP2BxPDPWFWEch7sSDG5Z/AHPzm9NCbdAMXkHaHfjIkJf6uNsiJBnR7jJThfms1iNc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(376005)(1800799015)(366007)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6363
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM2PEPF0001C717.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ccfbb59f-bfd1-4185-3510-08dc534814f0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Nle2OV/3GN+Y3/Cnh3FdAJKU4o0RRX6Uy/hzCitG4O9E5nzAZGkBheiCNMuMrwONiwOlzT7UbW9gJBqExAJSu5SzIF/U4RtD/aEipN0aJIyl/Ct//qaKKc/RjqoA04ApltOBB46t2yliXrTwRMjlX5vK02MfyY7SPgt1f0DMMsCOMAJH6z69RNJXPs2XgcfFGPhWa+XZ/s+0lLZpH5nX6ueVJBvjlQYBOMP5v6m7llt6jCmj/U87aIMRfkWyroxBTwgUTlEk3iIm0hhoZGJsQlCZiHeZxh67FaSZiUhHTkT00HzJDZ+7/pfO49lhzC9iwiIcyzG9xmxoxD3Y9ocAO6whq1uLbhIaCpDPd9mK5LNCLFhxtfShp84SaKQSTy1goLktwjzNEx9BuHjvqoXaujQg6rkBduWR2bGRWwVE9nG6lq+SgVHSGUAPyItxA5uALHqcHOC2fOT1S4XO//BlgHaac7zQWB5yFyt3Bjo6HlTKm+xAH6ezfeiCc3RiCd/to+cAHKy5asl0urdTOSDbT8MrYipm0pydxm4hcjC6+mFOugmLadzgfXK9wZhk406HLlXwO82+ZGE/DzpLeW+cOeo/q7dBEv3DGNdqcj3PWzS47uurlpTHKbxSTuERrAaL+c0r3quDxAf7qh0sDANIbNU//7ILowgkEBr6kTCi6P9QZss0+7DYnmwishfMYxNxCIN955MvvB/9hkpqoY6k7O5igrM9ZbCgJEgnwstrUvLXyjNn6bkiQfuwVxQ246zN
X-Forefront-Antispam-Report:
	CIP:20.160.56.81;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:repost-eu.tmcas.trendmicro.com;PTR:repost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230031)(82310400014)(376005)(1800799015)(36860700004);DIR:OUT;SFP:1102;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 19:07:03.3336
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ccfbb59f-bfd1-4185-3510-08dc534814f0
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.81];Helo=[repost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM2PEPF0001C717.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7330

On 4/2/24 14:55, Christophe JAILLET wrote:
> In "struct muram_info", the 'size' field is unused.
> In "struct memac_cfg", the 'fixed_link' field is unused.
>
> Remove them.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only.
>
> For fman_memac.c, I think that it is a left-over from commit 5d93cfcf7360
> ("net: dpaa: Convert to phylink").
> Maybe, #include <linux/phy_fixed.h> can be removed too, but it is not the
> purpose of this patch.
> ---
>  drivers/net/ethernet/freescale/fman/fman_memac.c | 1 -
>  drivers/net/ethernet/freescale/fman/fman_muram.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/n=
et/ethernet/freescale/fman/fman_memac.c
> index 758535adc9ff..92b8f4ab26f1 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_memac.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
> @@ -267,7 +267,6 @@ struct memac_cfg {
>       bool reset_on_init;
>       bool pause_ignore;
>       bool promiscuous_mode_enable;
> -     struct fixed_phy_status *fixed_link;
>       u16 max_frame_length;
>       u16 pause_quanta;
>       u32 tx_ipg_length;
> diff --git a/drivers/net/ethernet/freescale/fman/fman_muram.c b/drivers/n=
et/ethernet/freescale/fman/fman_muram.c
> index f557d68e5b76..1ed245a2ee01 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_muram.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_muram.c
> @@ -12,7 +12,6 @@
>  struct muram_info {
>       struct gen_pool *pool;
>       void __iomem *vbase;
> -     size_t size;
>       phys_addr_t pbase;
>  };
>

Reviewed-by: Sean Anderson <sean.anderson@seco.com>

[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embed=
dedworld2024/Register/ew24517689>