Received: by 2002:a05:7208:3003:b0:81:def:69cd with SMTP id f3csp4289024rba; Tue, 2 Apr 2024 12:28:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX+p1zrTEt2p/xcaF6/nA6DmXwfddTJjHLrXK+gEI3HZl3zU7G8xnXrxf8vmtFCvrc072D0CdJKQHeS/c88v3THOl2o2UloEWghrHBV+Q== X-Google-Smtp-Source: AGHT+IHBDuVsRh18UVaP0d1mcPNl7j9mfp5AEemgJdOqFLJ38jrG9vbuW7Cd8HD4fm6I8ucWx4CE X-Received: by 2002:a05:6808:398c:b0:3c3:d2ca:a4fe with SMTP id gq12-20020a056808398c00b003c3d2caa4femr17821112oib.7.1712086089038; Tue, 02 Apr 2024 12:28:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712086089; cv=pass; d=google.com; s=arc-20160816; b=wxrhTeZ1CzGrQdhtV41c2dVkPshMKi4clESPCBMM4dj6rYRoHmWgWEAh/X11OBSh8D 4Eq4siI2Z5553rnl0iK5gUE3TZ4uXfBOje2LT6pgAZHmMj9S2G/hPB27v4yfV3IINU4P CEXlign460BfkrpSQDlJGNDp/Ka32F91yLZLI0q04hJmmCl7izTxXkXzf+1sgCDGmm8M 4toLy+C4jMuzW69sMrkztZ1PXn1dg38xCtdLe9JpzR+m5X5GwIJ3kh0sCMf9yHOgyQam LN91GxNXYc9tFP32HLO/4AohRB0nUu3ppqR3QojD2rl+NMkMiSEP1Hlu/EIeo6B1wmhy srjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2IvxhZTeRGMzJtd2ZyOSnbmig+nTZ2hJJ3tE10xMgUk=; fh=4/ek9RprG/Dr7aJ0mEdbYn4R0WxxpeoHGvbrF76N/M4=; b=TjfYUFe0NudlSoojWu3CmUq3+B7lwBAkgqViri+AR0a+zJxbSHxRqMvJEpqBM0C06Y j7YnwMQXXznzkVs2fzE+qQ0/G2O0tKHHOSe51t1+yanzTKrBTIRRgXFBKO94S1mV7arC gWDfyxSnSoEeJL7luKNOdamjh/lAsQh+mqMB94yxnwRc7fBoCmiDE2w5r9r8FLjNGGUT z/uQK4/XJ5GwTxKdeFoQrvzqQ0X8hoaNq3iMGUSSlmMmrLIJKFCL2s7Dt0Gc4K+ww9q+ dbqInQxKrPvINa8pdy35Twbx++uqUUlgH6/ZvnKhHUPaXn7ADFn2hVJqhz88a3wRw7qo 0+vw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=IAMIajiP; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-128566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128566-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id m19-20020a05622a055300b00432b64eb7a3si12348907qtx.603.2024.04.02.12.28.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 12:28:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=IAMIajiP; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-128566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128566-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7E3DC1C22E94 for ; Tue, 2 Apr 2024 19:27:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ECE1815B971; Tue, 2 Apr 2024 19:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="IAMIajiP" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7108D15B963; Tue, 2 Apr 2024 19:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712086030; cv=none; b=gRZWAIGoGNxcLa9n6PO6uDSdnhiqRXE+ImM3r5ASA0ogBwXJbPP+D/P+NumJXPGweM7PRxaATXF7SKJ1/SfmLn1aT7UA3cF/M8+L3QpUa2Gl/eVcd7hM19liZsp7kONnaVKVSz8wOu7WT03WBLnVmNNEvUP2s6c3MXSF7FIIWpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712086030; c=relaxed/simple; bh=hg49FgYaH4GuMBzIb8C7D7yRNHB16wAyclAyJ4VU55A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=abqXDlh0QuHxJOH62DSfWLY2xS5GmIR+3nxdVAZeGp74ECZgiSNJ7S7ZsaOY2J5sU/KfHav8xUzT0BRPsu6zZOfZNIVCWcd/7v6Ic65K+U1CVEygJsaFuGuFauY89sKP2Bak7to+rhxLF51WTm5KgLduiVsxdDb8KaSPbJA9B/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=IAMIajiP; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=2IvxhZTeRGMzJtd2ZyOSnbmig+nTZ2hJJ3tE10xMgUk=; b=IAMIajiPWl4V8UpSiU0IzV5Cer M197q8FTSCL5rAG9aEpZq39W0vV0WjuTvyg4kESmQ+V14cuO2Ckt65/r/5HL55E1WuY6fgnZCKUO9 G7zEMAMR4TSeaRPDynLkn6mEiCnEgIOoYvIRLXPQj7CpCHwdGVbr9vTm0B1+fMcVpm+0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rrjme-00Byla-Io; Tue, 02 Apr 2024 21:27:00 +0200 Date: Tue, 2 Apr 2024 21:27:00 +0200 From: Andrew Lunn To: Krzysztof Kozlowski Cc: Robert Marko , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: marvell: espressobin-ultra: fix Ethernet Switch unit address Message-ID: <09201a97-7e7b-4d72-8ada-f58f85887349@lunn.ch> References: <20240402183240.49193-1-krzk@kernel.org> <20240402183240.49193-3-krzk@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402183240.49193-3-krzk@kernel.org> On Tue, Apr 02, 2024 at 08:32:40PM +0200, Krzysztof Kozlowski wrote: > The Espressobin Ultra DTS includes Espressobin DTSI which defines > ethernet-switch@1 node. The Ultra DTS overrides "reg" to 3, but that > leaves still old unit address which conflicts with the new phy@1 node > (W=1 dtc warning): > > armada-3720-espressobin.dtsi:148.29-203.4: Warning (unique_unit_address_if_enabled): /soc/internal-regs@d0000000/mdio@32004/ethernet-switch@1: duplicate unit-address (also used in node /soc/internal-regs@d0000000/mdio@32004/ethernet-phy@1) > > Fix this by deleting ethernet-switch@1 node and merging original node > with code from Ultra DTS into new ethernet-switch@3. That is a bit ugly, having the exact same code twice. Could the bulk of the switch node be put into a .dtsi file, and then included as needed &mdio { switch0: ethernet-switch@1 { reg = <1>; include "armada-3720-espressobin-switch.dtsi" } } &mdio { switch0: ethernet-switch@3 { reg = <3>; include "armada-3720-espressobin-switch.dtsi" } } Andrew