Received-SPF: pass (google.com: domain of linux-kernel+bounces-128555-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <88eeb7a5-540d-487b-a267-37d724f142d2@nvidia.com>
Date: Tue, 2 Apr 2024 20:20:28 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: tegra: correct Tegra132 I2C alias
Content-Language: en-US
To: Krzysztof Kozlowski <krzk@kernel.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Thierry Reding
 <thierry.reding@gmail.com>, devicetree@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
References: <20240401140854.97107-1-krzk@kernel.org>
From: Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20240401140854.97107-1-krzk@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WUhQRC9BNlEvSS9JVk5LRnNaNkRDUjFHZk1ZbmI4bUZ6K1pXZ1FnTFAvY3lW?=
 =?utf-8?B?N3IxcTNTVXFrbVVyRmhNdjZJYjdqYXYxcjNFd2RFVTc4Z2Q5L2RpZk05U3hk?=
 =?utf-8?B?aG16bXZJazJ6Y1Z1bmFmOXhwMkI0cWZWbWErTzkrQ2JKUTRuR1ArRndYME8w?=
 =?utf-8?B?TEJTYmVjczRwa0pvb1lJOFJncUJ5N3piMTBFQkswYXY1SjJBUjN0QUQ3ODB3?=
 =?utf-8?B?TG5uRWVtTlVzN0IrUHdxMFpHSnFWN1RmV1ZDMGNwN0dUWnhTRDNldVVPV1VO?=
 =?utf-8?B?VVY2bkpkQjJ2dzJWRHl4b2F4aHlsRTBGM3pxUjdUUDM4dGRSbElUdGNmVmV0?=
 =?utf-8?B?ZnA4QjVwUW5lQmNCL0VDcE1ROWRNaTBEQWh3QjU0VTMxbTVNMlYrZHpwVUt3?=
 =?utf-8?B?K2doc2hKZ0lxTTU1RmlDdUhOT3U0YkdlcEhTNUQxSElJUWxTTkQ3YXdKV0wy?=
 =?utf-8?B?aHJ3WjRQVWdOWjAyVEl3Q0MxN3p2ZlZrOHNNRWZmRHMwOUYyaUlZYVRGdTE4?=
 =?utf-8?B?NnhzaERlZlB1RDRKOUkwZ25Gd3Y5SkNreldrdnNHb0JPSHNCc3VaOVltYjhi?=
 =?utf-8?B?VC9Za1Y5R1NWQVFNTEdHa1B1Z3NLS1pzcGVRTGxOUk5Va3hTS0lDRGF2ZzVX?=
 =?utf-8?B?RlFoNG81eEJwb1ErNzEwMmdpUWx6am43WXp2bFBRM3l5L3RpSFY4Z0JVaTJ6?=
 =?utf-8?B?MVIyeTl3MHMxUnNyN1VzYTNySXY5NkI4WW95N1NaR3VzbU9IbTlObkxwVmRH?=
 =?utf-8?B?NjREQk5INmc5OWFmWk04RGZTNERwMU16N3ltTkoyR0VWWUhOOTdxUUt3bnd1?=
 =?utf-8?B?Ty9nQytvcEk5dld0Q2dMOUQ5b0RrNFJFdFYyUEx3UzcvZkZYM2VNdmx3b1V4?=
 =?utf-8?B?dWJJZVR6ZVBZYTkveHA3dHVydVBxdmR1L3d0NHVrWGdTc3o4WlhYL0tGOGxE?=
 =?utf-8?B?QWU0MytYakVZZFpveUxwYXdwS25vTGt2VVZpdGRpdVRtSy83aFNPTksrbnEx?=
 =?utf-8?B?Q21Dazc3V1NySENVNzR1VW04dVduYW5mbHl1LzRzTFdCWEJvdjEwcWlQcXM2?=
 =?utf-8?B?bVVoWUJ3dkxDMmlGYXFBSCtpQXZ3QlZVYXBuektsZThlRWp6N0pNa0RZblc5?=
 =?utf-8?B?WmxIWjVTOHkwdXFVYy9vSldvSk53bENaWVBQQnc0aXRkYlJndExxQmlSZUdk?=
 =?utf-8?B?TjBqZUw1aXBZZlltL2lkeDR6bThrcld5aEZZcXlheGk5OWN1elJ6cForbjh6?=
 =?utf-8?B?aUMwM2poMlROZGF5YlYxZ2ptU3ZJdHB5Y01FKzVDL3ZTc2xUb08yU25mMEU5?=
 =?utf-8?B?OTdLdUVPUGJmTnV1bU11TzhPVmc5YW5DQVdCVTBkYzhyM0g4OERScjhPZ25j?=
 =?utf-8?B?WW1VUUh1Y1NxUjJaQU9XT0hGYU1UOXhvc2p6aXYwdjFqSVp5NU9SRFMyUC9Z?=
 =?utf-8?B?amFSOFBEY1JzUzNQUTcyRmRvM3VhbHo5YXFyT0l6dmtldFdQUWFHTGpJc2wr?=
 =?utf-8?B?d3ZCaFFRdmF6Z3l0aUd3ZWl6aHFRN1ZsejY3aS9teko1dzUyZklIaXYxWDhE?=
 =?utf-8?B?NVFJcGRaNEdtSkJGV0tMeWpLeG1hRDJLMUZ3L0Z6SEUzMFNFOGFJRkVuYU9U?=
 =?utf-8?B?MXNvNnFPRjhUMmkrUldyNkdrUGVDblA1NE5TdDNZSHROYWpmU0NUNWY0bE53?=
 =?utf-8?B?T2RlVlNxNThNZ2I4VGVQYWdNbnFKcm1nQzV1Vi85cGw2Q2x0ZmVBQXFnM2cr?=
 =?utf-8?B?ZGRKeXAwWlg5b2I4dFFLZ3M4aW9jbUwzNjlsZUVNRFRvdVQwQkhMWUZJK0Y3?=
 =?utf-8?B?UFlPWndEaURRUWJ6VCs2THp2RXhMcHRBRGJUL3BnT2FzdjRqdGpuQWF3Ykhk?=
 =?utf-8?B?MDAyNldGeElRVGo0MmtCWUpLNDRIbk5VRmwwU0U0eGM1NXpWc2dlcXcrRGVx?=
 =?utf-8?B?Q1VMMUpRa3BnVXNvU3pSY1FJckhEelR1RE90VWIwSnYySW16TEtSdDl0VFNo?=
 =?utf-8?B?UHlNckxFQ0NuRE9MUUFGZi9oUWtGRnhIRDc0RVVBZ3J2Z2NLVHo5STduQXVx?=
 =?utf-8?B?N3YwTldQZm8xR0lmT2V4Vm05WHg0NUhYSFdraUJPZmpub0xEelFqdWxmNnE1?=
 =?utf-8?B?bnNiMVFhZ3BCVzZQbHlJQmlzSzI0NGRlYk9oTkNZOTU1UG1Tak8rdCtqemky?=
 =?utf-8?B?c3c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3a4ab89-5eb7-49da-427b-08dc5349f7ad
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 19:20:33.5944
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Eqy8H7wx6f3nt23TJaQeghOFFfFjc0SS4dFUQGNUoab0RD7z3JxXQxDox3Ve7jSsQOBaetjxHA3is65NTQt78A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8072


On 01/04/2024 15:08, Krzysztof Kozlowski wrote:
> There is no such device as "as3722@40", because its name is "pmic".  Use
> phandles for aliases to fix relying on full node path.  This corrects
> aliases for RTC devices and also fixes dtc W=1 warning:
> 
>    tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@7000d000/as3722@40)
> 
> Fixes: 0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>   arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++--
>   arch/arm64/boot/dts/nvidia/tegra132.dtsi       | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> index 14d58859bb55..683ac124523b 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> @@ -9,8 +9,8 @@ / {
>   	compatible = "nvidia,norrin", "nvidia,tegra132", "nvidia,tegra124";
>   
>   	aliases {
> -		rtc0 = "/i2c@7000d000/as3722@40";
> -		rtc1 = "/rtc@7000e000";
> +		rtc0 = &as3722;
> +		rtc1 = &tegra_rtc;
>   		serial0 = &uarta;
>   	};
>   
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> index 7e24a212c7e4..5bcccfef3f7f 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> @@ -572,7 +572,7 @@ spi@7000de00 {
>   		status = "disabled";
>   	};
>   
> -	rtc@7000e000 {
> +	tegra_rtc: rtc@7000e000 {
>   		compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
>   		reg = <0x0 0x7000e000 0x0 0x100>;
>   		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic