Received-SPF: pass (google.com: domain of linux-kernel+bounces-128581-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8daf448f-eb52-4b1f-9f98-099a83665321@amd.com>
Date: Tue, 2 Apr 2024 14:33:44 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/sev: Apply RMP table fixups for kexec.
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: bp@kernel.org, thomas.lendacky@amd.com, linux-kernel@vger.kernel.org,
 linux-tip-commits@vger.kernel.org, michael.roth@amd.com, x86@kernel.org
References: <2ab14f6f-2690-056b-cf9e-38a12dafd728@amd.com>
 <20240402163412.19325-1-bp@kernel.org>
 <6f0d2ccf-243c-4073-a470-21e2f404595a@amd.com>
 <359264a1-e4ef-438c-8f24-32848e131272@amd.com>
 <20240402174540.GAZgxERNxsRJUCb1yp@fat_crate.local>
 <37321af9-aee4-4ba6-81ac-0df4cef38644@amd.com>
 <20240402185039.GBZgxTfwvEP45OxVjm@fat_crate.local>
From: "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <20240402185039.GBZgxTfwvEP45OxVjm@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?djdGVHREdzRHdTBKODF2NjdYTGowWGNWUGVxNms2ZmdYYngwa3dzY1hybnFw?=
 =?utf-8?B?ZENhS0FiZWhIZGt1NlV3T1cwTHF3VSthZUZ6Mmp1NndLUnVrQXAzVG1PZkw3?=
 =?utf-8?B?TVJ5NVZKT1JvQk54djVraFFRNENpTWxUR3BuTnNMY0VqekNkSlR6K2xFeUlJ?=
 =?utf-8?B?NkNMcS95eHdsUTkwWm8yelljT2w0cWMxK1o4TGF3MEI5U3Y3UzdKK1l4MDFZ?=
 =?utf-8?B?WjRGVXVrUUhKWGhDdmNBV1AyNnM2YmFHR1l3VE5SVzIrNnE5ZDFmNDRsUElC?=
 =?utf-8?B?azRQNzVyaElEMVhlZWRSQnhUVXdwU3pTZUV4V3hPcUdONTJ1QlVOR21sQXIz?=
 =?utf-8?B?MjNoZVBBYVIxZnJsbEk1dDhsK2U1NUhCN1dJbStNc0RsOEFjUjNiSzlSN1Rn?=
 =?utf-8?B?RkR2N1ozY0xWb1dmU2wybkw1MjZqS3BJU3ZHbEVKSW1yVDgxNTNUWWx5MXhK?=
 =?utf-8?B?UnNsRXB4bGUwVVVicUdieUY5blZoWUh2SUdqMEN4MUUyR01lSmNPR1NYTldP?=
 =?utf-8?B?T05qUVVpVUVUdWswM2xpQWJWZlZER29LcHpaNCtqcDN5N1pYLy9GSGgrV1ZS?=
 =?utf-8?B?Ni9yb2lJdXVSYTQxQzBadFZ4a2tpUEFtN0hEbDJzTWlsSmF1TlQ3NkVoYUZW?=
 =?utf-8?B?WEowZFB5RE9TZDlIMDVHM3NVbDJ4dWtKN0FhSlJWSHBYaFFqOEQ5YVh2a0Uz?=
 =?utf-8?B?by9nc1hSOHlwTmN2eFNyUDUzQk9DTU1CRlFLYTljRkhybEsyOHltSGEyRkx6?=
 =?utf-8?B?ckVEK21DVmc1M0dUMWt6dkp6TFFiVTdJR2RMa3NEQTU0ZlpBN1ZGd2RKUHhK?=
 =?utf-8?B?YzFkTHFPQWhpaTIvT09iS2hsRFVja0JZcFp6blFzY2NrY2prRjF1QjdxNG9h?=
 =?utf-8?B?dzgxeXVpUG12ZmxNTUhBaEgvcXpnazlKaXFBM21XRnNJbS9GWVBqVUJwZTQw?=
 =?utf-8?B?RDQ0eW84bDBjdlNBNU5Ed0xwellUZmNkWjBWeHFWWmVkcHZ0K1hKMGl3NDh0?=
 =?utf-8?B?K3UvenFPTXF4QmUrRVFUMFlNWmx4dkZyUnVjc0lXd1pEM3dWYWs1UUdlMnRU?=
 =?utf-8?B?a1JVODlLUXc1QUVGaWkrc0NQQlNpVzdYY0RmeGhnUjNycE9zbzd5aXNoYTdx?=
 =?utf-8?B?NU9ySTJlUWc2MzdxMlFOUWhnVk4yMjdQV1VtZEYvWG5vVnhYcURudjd3V2w5?=
 =?utf-8?B?bU1nVjZBNEluVC9kQ3N3UTk2YlRkWCtYQ0MzRnNNZ2tsT3FTSVlXS2JXVXZl?=
 =?utf-8?B?TnA0ZUFKQW5iZVU0dlE3T2RMYkhpaVBqRGpDU2Y0ZzRpUlQ5U2drYTQyMHJv?=
 =?utf-8?B?TExLV3pVVTZuRkxxNlgxNVRnV0owaHpIeDFDVnFBNlAzQXU5L0w0ZEcvUURr?=
 =?utf-8?B?VmkxUXJQVGRYQ3FDNjlaTlg5UFBiSDA0TnBXZTR4MHJid09XcEN0WldCeU5D?=
 =?utf-8?B?cFU2WDVhZTJrQmZPTEloOFFGVWRYd3NKbHcreTVHUHY0Y1l6NGZoLzR0STRZ?=
 =?utf-8?B?MEtWQnVIcE10TkNuak9Oa3AzZXlNczVUdk5hN2R2M2pLWXA5UzFybGxHTkZ0?=
 =?utf-8?B?RkVGRmEwWUo5bHJhV3A0WVlsdnpybjJuMUhicXRQQmNNS280bmdxUkFjSzdW?=
 =?utf-8?B?Y1hOVnNMVUhjNXkxOGlJdnhhVlJINWxtOUpkeUU4OUMyZEh5MjVMUnoyVkxZ?=
 =?utf-8?B?TmJnZ29LMzRqK2hCUHhFN1QyLzIxWmlCL0tFaGRGZ0JwMlBuNkhETFRXZUd1?=
 =?utf-8?B?NjJqOE92aUFEQ0ppVnFNd1JtSTBLSVh1Nlh4UW5NSW9iOGppVFFsa2pjNXg2?=
 =?utf-8?B?RDRjeCtqUS9PUVJNRkhXbjNvbHpNQjVCT3MxVW1uSTNkWWdwTDVEY2hYYU15?=
 =?utf-8?B?dUFRdHBpR2k5Yy8zTjFzWC9VdTBqMjN0S3l2SnJ2ak41anFWcjFVQlhBVnl0?=
 =?utf-8?B?U2xReWNWZEN1TXhHeDdkNGw1Ri9MU0JsL2NxU0dZbkVvRWJZUUNJaXNJY1BY?=
 =?utf-8?B?TDZsK2JNTi9IVExHbE9kQUkvN1J2VndCNmZhZUpNc3NoZmw1bVZ1cTBlMDAy?=
 =?utf-8?B?MmV6cll1QXNxcUlFTmpyVWk1U09EZmhNK1lnU21GNWNPR3ZDbTFoYVhJd2wy?=
 =?utf-8?Q?4HQdoeGv3jJeBd6vpzTIqmc7t?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 175691a9-c9bd-4aa5-d508-08dc534bd029
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 19:33:46.0753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HoQ5qmMt9KH33SjL7qCFsFBueLVLkfoc7i+zzEgrnVJFSB1CLm+XmdQLe4rifrjluSgp0SE6nyOhqsVLkxhEcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8756


On 4/2/2024 1:50 PM, Borislav Petkov wrote:
> On Tue, Apr 02, 2024 at 01:41:05PM -0500, Kalra, Ashish wrote:
>> But, that's what the e820 table fixup is doing,
> And can it be doing it in snp_probe_rmptable_info() where all the RMP
> table stuff is being done?

The e820 fixups has to be done on both e820_table_kexec and 
e820_table_firmware (to handle both kexec variants) and this has to be 
done when e820_table is used to populate both e820_table_kexec and 
e820_table_firmware and this is done in e820__memory_setup().

But, snp_probe_rmptable_info() is called as part of early_cpu_init() -> 
early_identify_cpu() which is called earlier than e820__memory_setup() 
and e820 tables are setup much later e820__memory_setup().

And we can't do this in snp_rmptable_init() as e820_table_firmware can't 
be fixed at that point and by that time this table has been mapped into 
sysfs (/sys/firmware) which is used by kexec -c variant.

The function e820__memory_setup() has an optional platform quirk 
available to override/pick up the firmware/bootloader e820 map, and 
that's why i am using this platform specific quirk to override it with 
the SNP specific RMP table e820 fixup function which internally calls 
e820__memory_setup_default() to pass the firmware/bootloader e820 map 
(set in e820_table) and then add RMP table fixups on top of it.

Thanks, Ashish